[$250] Workspace - Emoji is cut off in workspace description

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.14-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go to workspace settings > Profile.
3. Tap Description.
4. Clear the description.
5. Enter an emoji.

Expected Result:

The emoji will not appear cut off.

Actual Result:

The emoji is cut off.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6556673_1722285843876.ScreenRecording_07-30-2024_04-39-55_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b019349deac75487
• Upwork Job ID: 1818038948071955386
• Last Price Increase: 2024-07-29

Issue Owner

Current Issue Owner: @c3024

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[chiragsalian]

doesn't look web-e related. removing deployblocker label.

[jasperhuangg]

This is a super minor display bug that I don't think warrants blocking app deploy, I'm gonna see if it was caused by any of the PRs in the checklist but removing the label

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b019349deac75487

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The emoji is cut off.

What is the root cause of that problem?

We enabled isMarkdownEnabled in

App/src/pages/workspace/WorkspaceProfileDescriptionPage.tsx

Line 111 in df69c80

isMarkdownEnabled

so the emoji is bigger (20px) than normal, but the lineHeight is still 20 (it should be 24)

App/src/styles/index.ts

Line 1216 in df69c80

lineHeight: variables.lineHeightXLarge,

What changes do you think we should make in order to solve the problem?

In BaseTextInput we should change the lineHeight to 24 if isMarkdownEnabled is enabled

What alternative solutions did you explore? (Optional)

We can update the emoji's fontSize from RN-live-markdown

Result

[dominictb]

Updated proposal to add the screenshots

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[c3024]

This is not reproducible anymore.

emojiCutoff.mp4

This can be closed. @kevinksullivan

[c3024]

@kevinksullivan @jasperhuangg

Gentle bump on this above ^^.

[jasperhuangg]

Thanks for taking a look @c3024, apologies for the delay was OOO recently. We can go ahead and close this out.