Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search v2.2] [App] Create Chat contextual filter #46587

Closed
luacmartins opened this issue Jul 31, 2024 · 21 comments
Closed

[Search v2.2] [App] Create Chat contextual filter #46587

luacmartins opened this issue Jul 31, 2024 · 21 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 31, 2024

Implement this section of the design doc

Issue OwnerCurrent Issue Owner: @shubham1206agra
@luacmartins luacmartins added the Daily KSv2 label Jul 31, 2024
@luacmartins luacmartins self-assigned this Jul 31, 2024
@luacmartins luacmartins moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Jul 31, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 5, 2024

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

@luacmartins
Copy link
Contributor Author

Still waiting on doc reviews.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 6, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 13, 2024
@luacmartins luacmartins added the NewFeature Something to build that is a new item. label Aug 13, 2024
@luacmartins
Copy link
Contributor Author

@shubham1206agra will be taking on the implementation!

Copy link

melvin-bot bot commented Aug 13, 2024

Triggered auto assignment to @zanyrenney (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 13, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Aug 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 15, 2024
@zanyrenney
Copy link
Contributor

@shubham1206agra do you mind please updating this issue according to the KSV2 cadence?

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2024
@shubham1206agra
Copy link
Contributor

Actively working on this. I am waiting on #47181.

@zanyrenney
Copy link
Contributor

Thanks for the update @shubham1206agra

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
@zanyrenney
Copy link
Contributor

We're waiting on the issue linked above by @shubham1206agra

@zanyrenney
Copy link
Contributor

Issues linked above yesterday!

@zanyrenney
Copy link
Contributor

Just a heads up, I am going OOO until August 30th. I won't reapply the bug label as we're far from payout, but please can you keep this issue updated daily with your progress @shubham1206agra

also, @luacmartins, can you confirm what the day for the payout should be, please? Some of the issues were merged 4 days ago but some still in draft so not sure how we should be counting this one.

Thanks!

@luacmartins
Copy link
Contributor Author

This is still being worked on, so we don't have a date yet. The linked issues/PRs were related to this issue, but weren't directly implementing these changes.

@melvin-bot melvin-bot bot added the Overdue label Aug 26, 2024
Copy link

melvin-bot bot commented Aug 26, 2024

@luacmartins, @ikevin127, @zanyrenney, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

@shubham1206agra
Copy link
Contributor

Waiting on #47753 to merge

@melvin-bot melvin-bot bot removed the Overdue label Aug 27, 2024
@luacmartins
Copy link
Contributor Author

@shubham1206agra PR merged, let's keep up the work on this issue

Copy link

melvin-bot bot commented Aug 30, 2024

@luacmartins, @ikevin127, @zanyrenney, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Aug 30, 2024
@ikevin127
Copy link
Contributor

@shubham1206agra is still working on the PR (I think), tried to help move it forward in #47690 (comment) with my investigation of the current blocker, but the author replied:

I don't think this is the right reason since we are using Same Anchor Renderer everywhere and it has not affected anything else at all.

I think in order to move this forward we either have to ask the author if they have capacity to actually work on this and move it along to open the PR, or with author's approval, ask somebody else to work on the issue and open the PR.

cc @luacmartins

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Aug 31, 2024

@ikevin127 I asked you to help me on #47690 (comment) since I am unable to find any fix yet. And this is the only blocker for the PR. Can you please help me with this?

Edit - This is fixed now. I will open the PR shortly.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Aug 31, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 10, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins
Copy link
Contributor Author

We'll handle payment for this in #46588.

@github-project-automation github-project-automation bot moved this from Release 3: Fall 2024 (Nov) to Done in [#whatsnext] #expense Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants