Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] After clicking on a search result it took 4x OpenReport requests to open the final report #46594

Open
1 of 6 tasks
hannojg opened this issue Jul 31, 2024 · 21 comments
Assignees

Comments

@hannojg
Copy link
Contributor

hannojg commented Jul 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


What performance issue do we need to solve?

A customer was searching for a chat, clicking on it, and then it took a long loading time and actually 4x OpenReport queries for the final chat to open:

Screen.Recording.2024-07-31.at.17.12.17.mov

What is the impact of this on end-users?

TTI with the chat

List any benchmarks that show the severity of the issue

I have a copy of all network requests available. As they contain customer data I can't post them here. If you're working on that issue please let me know

The customer also shared a profile trace with us:

Firefox 2024-07-25 10.42 profile.json.gz

(note: the trace also contains other test cases as well)

Proposed solution (if any)

None yet, I will go through the profile and see what can be optimised, what exactly caused those lags.

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

not available yet

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Version Number: v9.0.11-5
Reproducible in staging?: not tested
Reproducible in production?: yes
Email or phone of affected tester (no customers): customer
Logs: See performance file
Notes/Photos/Videos: See attached video
Expensify/Expensify Issue URL: n/a
Issue reported by: @hannojg
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1721919928992729

View all open jobs on Upwork

Copy link

melvin-bot bot commented Jul 31, 2024

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

@hannojg
Copy link
Contributor Author

hannojg commented Jul 31, 2024

cc @sakluger (feel free to assign me as I (or someone from my team) will work on this ticket!)

@sakluger
Copy link
Contributor

sakluger commented Aug 5, 2024

No updates

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 5, 2024
@sakluger
Copy link
Contributor

sakluger commented Aug 8, 2024

No update

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 8, 2024
@sakluger
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Aug 12, 2024
@sakluger
Copy link
Contributor

@hannojg should we leave this as a daily, or will it be a week or more before you can prioritize this one?

@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels Aug 15, 2024
@sakluger
Copy link
Contributor

Moving to weekly for now since Hanno is out until Monday.

@sakluger
Copy link
Contributor

@hannojg any updates on this one?

@hannojg
Copy link
Contributor Author

hannojg commented Aug 22, 2024

This is a rather tricky bug as reproducing it is hard. We have this currently as low priority to address overall performance issues first!

@melvin-bot melvin-bot bot added the Overdue label Aug 30, 2024
@sakluger
Copy link
Contributor

I asked for updates in the main tracking issue: #46595

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2024
@sakluger
Copy link
Contributor

sakluger commented Sep 6, 2024

We're focusing on the slow search first. We have a WIP PR for that, I assume we'll look at this again once that is done.

@sakluger
Copy link
Contributor

No update

@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2024
@sakluger
Copy link
Contributor

No update.

@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2024
@sakluger
Copy link
Contributor

sakluger commented Oct 4, 2024

No update

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@sakluger
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Oct 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 22, 2024
@sakluger
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Oct 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2024
@sakluger
Copy link
Contributor

sakluger commented Nov 1, 2024

No updates

@melvin-bot melvin-bot bot removed the Overdue label Nov 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@sakluger
Copy link
Contributor

No updates

@melvin-bot melvin-bot bot removed the Overdue label Nov 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2024
@sakluger
Copy link
Contributor

No updates

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 29, 2024
@sakluger
Copy link
Contributor

sakluger commented Dec 2, 2024

No updates.

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2024
@sakluger
Copy link
Contributor

No update.

@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants