[HOLD for payment 2024-11-05] [$250] Chat - File does not appear with strikethrough style when uploaded offline and deleted

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.15-4
Reproducible in staging?: y
Reproducible in production?: no, production has different behavior
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Go offline.
4. Upload a file.
5. Right click on the file.
6. Click Delete comment.

Expected Result:

The file will appear with strikethrough style when deleted offline (production behavior).

Actual Result:

The file does not appear with strikethrough style when deleted offline.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6558583_1722458558630.offline_upload.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @OfstadC

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f435ef631a03057d
• Upwork Job ID: 1825625197125448253
• Last Price Increase: 2024-08-19
• Automatic offers:
• Krishna2323 | Contributor | 103626009

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

We think that this bug might be related to #vip-vsb

[roryabraham]

cc @kidroca I think this might be related to #44889

[melvin-bot]

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

[roryabraham]

not sure this needs to be a blocker

[roryabraham]

Curious for design input ... what should we display when you upload an image and then delete it, all offline? What should be the "strikethrough" equivalent for images?

[dubielzyk-expensify]

Good question. There's a few things we could do:
A) Delete it altogether and not show it
B) Put some sort of visual treatment over it similar to what we do with the offline thumbnail. So something like the mock to the complete right:

I'm leaning B so that we're consistent with the other offline behaviours of strikethroughs etc.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - File does not appear with strikethrough style when uploaded offline and deleted

What is the root cause of that problem?

We aren't handling deleted state for attachments.

What changes do you think we should make in order to solve the problem?

• In AnchorRenderer we have the parentStyle which is being used to check if the action is deleted or not, we can pass hasStrikethroughStyle to AnchorForAttachmentsOnly and then to DefaultAttachmentView.
  

  App/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx

  Lines 58 to 59 in e0f17df

  	const hasStrikethroughStyle = 'textDecorationLine' in parentStyle && parentStyle.textDecorationLine === 'line-through';
  	const textDecorationLineStyle = hasStrikethroughStyle ? styles.underlineLineThrough : {};

• In DefaultAttachmentView we can use the prop isDeleted (hasStrikethroughStyle) to apply the line through styles. isDeleted && styles.lineThrough
  

  App/src/components/Attachments/AttachmentView/DefaultAttachmentView/index.tsx

  Line 43 in e0f17df

  <Text style={[styles.textStrong, styles.flexShrink1, styles.breakAll, styles.flexWrap, styles.mw100]}>{fileName}</Text>

• We can also do the same for image and video renderers. In ImageRenderer we can create a variable isDeleted just like we created that for hasStrikethroughStyle in AnchorRenderer. Then we can pass isDeleted to ThumbnailImage and use that prop in ThumbnailImage to render delete icon when true.

• We also need to remove isUploading check from AttachmentCommentFragment otherwise the stylings will be only applied when attachment is uploaded and deleted in offline mode.

App/src/pages/home/report/comment/AttachmentCommentFragment.tsx

Line 18 in e0f17df

const htmlContent = styleAsDeleted && isUploading ? `<del>${html}</del>` : html;

• Test branch

Note: Test branch only fixes for attachments and images. We should also check for other components in AttachmentView and should also apply the change for videos if required.

What alternative solutions did you explore? (Optional)

Monosnap.screencast.2024-08-20.02-26-09.copy.mp4

[Krishna2323]

@roryabraham, I don't think this is a regression. The same can be reproduced on production, only difference is that we were showing uploading attachment... text before and now we have a preview for attachments in offline mode also.

production_deleted_attachment.mp4

[roryabraham]

I'm going to demote this to NAB

[OfstadC]

Reassigning as i'm out tomorrow and Monday

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[OfstadC]

Looks like there is still active discussion on the PR - so things are still moving along here?

[mananjadhav]

@neil-marcellini Can you confirm #47971 (comment) ?

[OfstadC]

Looks like the PR is still moving along 😄

[mananjadhav]

Yes I am halfway through the code review (mostly final) and finish the checklist soon.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Chat - File does not appear with strikethrough style when uploaded offline and deleted #47971

If no regressions arise, payment will be issued on 2024-11-05. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[OfstadC]

@mananjadhav please complete the checklist before November 5th so I can issue payment - Thank you! 😃

[mananjadhav]

I would treat this more of a feature request. But I think we should add a regression test for this one.

@OfstadC here's the regression test proposal:

1. Go to any chat
2. Upload a file (format: .txt/.html/.zip/)
3. Upload image & video
4. Go offline
5. Right click on the file
6. Click Delete comment
7. Verify an overlay with trash icon is shown for deleted video & image and the filename is crossed for the other file. (format: .txt/.html/.zip/)
8. Stay offline and repeat step 2 to 7

[OfstadC]

https://github.com/Expensify/Expensify/issues/441632
Will issue payment tomorrow 😃

[mananjadhav]

Thanks for the update @OfstadC. I'll need a payment summary for this one as I'll request this on NewDot.

[OfstadC]

Payment Summary

• @mananjadhav due $250 via manual NewDot request
• @Krishna2323 paid $250 via Upwork

[melvin-bot]

@OfstadC @neil-marcellini @dubielzyk-expensify Be sure to fill out the Contact List!

[garrettmknight]

$250 approved for @mananjadhav