[PAID] [Search v2.1] - Sorting on Drafts and Finished does not work at all

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Account has lots of expenses in Drafts and Finished section (Search)

1. Go to staging.new.expensify.com
2. Go to Search
3. Go to Drafts
4. Apply Date, Merchant and Amount sorting
5. Repeat Step 3 and 4 with Finished section

Expected Result:

The expenses will be sorted accordingly

Actual Result:

The sorting on Drafts and Finished does not work at all

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6559944_1722577006437.20240802_133409.mp4

Bug6559944_1722594720567.bandicam_2024-08-02_18-30-56-057.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[dangrous]

Seems to happen on production build on local, so maybe backend or a previous regression that wasn't caught. Asking the folks working on search to have a look

[rayane-d]

I believe this issue is related to a backend bug. @luacmartins recently worked on a backend change (#46481 (comment)) to address this bug, which could be causing the current problem. However, @luacmartins is currently out of the office. Can we find someone internally to handle this?

[dangrous]

I'm continuing to look into it but haven't found a fix yet. @iwiznia it looks like you worked on some of the syntax - any ideas? I've confirmed that the asc/desc exists correctly as ORDER BY in the query that's run here (e.g. ORDER BY toUser asc LIMIT 51) but the data returned, at least by this point is no different, no matter the sort order that was sent. So, need to figure out why that's not changing anything...

The search already gets wacky results on prod, so although clicking the columns does CHANGE the sort, it's still wrong, so I'm not sure this is enough of an issue to block deploy... but open to other opinions

[dangrous]

Running SQL queries directly via command line DOES result in differently ordered results... so the issue has to be in Search::buildTransactionResponse()

[dangrous]

Removing blocker label since prod is already weird, and this is no worse.

[luacmartins]

The only filter that supports sorting is Expenses. The issue here is that we're allowing the column header to be clicked ofr the other filters. We should disable that.

[Kicu]

@luacmartins I can fix this, since I broke this, by removing the mechanism of disabling sorting for other filters than Expense.
Sorry about that, when I was migrating us to new search syntax using AST I assumed that "everything works with everything" and sorting is no longer an issue.

Expect a PR with fix soon.

[luacmartins]

No worries! Thank you for working on this.

[Kicu]

@luacmartins actually I need to confirm one thing. In the past it was not that we only allowed Expenses as type, but that we only allowed ALL status to be sorted.

Is that still true? Because what we call on the LHN Expenses is in reality type:expense status:all. So is this the only thing that is sortable now?

[luacmartins]

Correct! Type expenses and status all is the only sortable one for now

[Kicu]

I think in general sorting on backend is usually always required while sorting on frontend is a nice addition. Since we can't drop sorting on backend then maybe this is a good idea?

I'm assuming that technically we'd still have a call to sort() in App, but it would be something as simple as

(a, b) => a.sortIndex <= b.sortIndex

right?

It would definitely allow us to simplify parts of SearchUtils that do sorting for different columns, since each col has a slightly different logic.

[luacmartins]

Yea, that makes sense to me. I don't think this is a priority now though given that the functionality works. I'll add this to the list of follow ups here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Search] Fix sorting not working on Search #46804

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @ikevin127 requires payment (Needs manual offer from BZ)

[ikevin127]

@luacmartins When you get a chance, mind adding the Bug label to assign a BZ team member for payment ? Appreciate it!

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sonialiap]

Payment summary:

• @ikevin127 $250 - offer sent in upwork

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sonialiap]

@strepanier03 I'm OOO Aug 19-30, adding leave buddy.
Status: if no regressions popup, please complete payment on the 19th. Payment summary

[strepanier03]

Paid. closing.