[$250] Chat - Room - Rooms mention list does not appear in message edit mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4826336
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Open App or go to staging.new.expensify.com
2. Login with any account
3. Go to any room or create new one
4. Send a message with a room mention
5. Edit this message by adding or editing room mentions selecting it from suggestion list

Expected Result:

User can select room mention from suggestion list in edit mode

Actual Result:

Rooms mention list does not appear in message edit mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563226_1722939019799.Desktop-No-Room-Mention-List-in-Edit-Mode.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dedb57180f356839
• Upwork Job ID: 1822051289639048019
• Last Price Increase: 2024-08-16
• Automatic offers:
• FitseTLT | Contributor | 103627253

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-08-06 14:29:58 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Rooms mention list does not appear in message edit mode

What is the root cause of that problem?

Because we passed isGroupPolicyReport as false here

App/src/pages/home/report/ReportActionItemMessageEdit.tsx

Lines 535 to 536 in 0e46257

	isGroupPolicyReport={false}
	value={draft}

We also didn't pass the policyID to Suggestions

What changes do you think we should make in order to solve the problem?

We need to pass isGroupPolicyReport and policyID in here

App/src/pages/home/report/ReportActionItemMessageEdit.tsx

Line 535 in 0e46257

isGroupPolicyReport={false}

by getting the value as we did here

 const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID ?? '-1'}`);

isGroupPolicyReport={isGroupPolicyReport}
                        policyID={report?.policyID}

What alternative solutions did you explore? (Optional)

[melvin-bot]

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dedb57180f356839

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

@eVoloshchak, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@eVoloshchak, @kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@eVoloshchak, @kevinksullivan Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@eVoloshchak @kevinksullivan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[kevinksullivan]

@eVoloshchak can you review the proposal please?

[AlfredoAlc]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Rooms mention list does not appear in message edit mode

What is the root cause of that problem?

The SuggestionMention component requires to have isGroupPolicyReport and policyID to render room mention list.
We are passing isGroupPolicyReport as false and we are not passing policyID

What changes do you think we should make in order to solve the problem?

The ReportActionItemMessageEdit component is already receiving isGroupPolicyReport we just need to propagate the prop.
And from that same component we already have access to the report policyID, so it'll only need to pass that prop to ReportActionItemMessageEdit and propagate the prop.

App/src/pages/home/report/ReportActionItem.tsx

Lines 718 to 729 in 72a7593

	<ReportActionItemMessageEdit
	action={action}
	draftMessage={draftMessage}
	reportID={report.reportID}
	index={index}
	ref={textInputRef}
	shouldDisableEmojiPicker={
	(ReportUtils.chatIncludesConcierge(report) && User.isBlockedFromConcierge(blockedFromConcierge)) ||
	ReportUtils.isArchivedRoom(report, reportNameValuePairs)
	}
	isGroupPolicyReport={!!report?.policyID && report.policyID !== CONST.POLICY.ID_FAKE}
	/>

[eVoloshchak]

@FitseTLT's proposal looks good to me

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[kevinksullivan]

Looping in a BZ member to handle payment as I'm going OOO

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[puneetlath]

@eVoloshchak when will this need paying?

[eVoloshchak]

@puneetlath, not clear yet, as this wasn't deployed to staging/prod yet
Latest update:

This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[melvin-bot]

@puneetlath, @eVoloshchak, @kevinksullivan, @jasperhuangg, @FitseTLT Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@puneetlath, @eVoloshchak, @kevinksullivan, @jasperhuangg, @FitseTLT 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[jasperhuangg]

I think our automation was broken for a bit, seems like the PR was deployed to production in this checklist: #48791

I think we can issue payment now

[FitseTLT]

@puneetlath can you issue the payment here??

[melvin-bot]

@puneetlath, @eVoloshchak, @jasperhuangg, @FitseTLT Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[puneetlath]

Sorry for the delay!

Payment summary:

• C - $250 - @FitseTLT - paid via Upwork
• C+ - 250 - @eVoloshchak - to be paid via NewDot

Thanks everyone!

[FitseTLT]

@puneetlath I see that the contract has ended but the payment hasn't been made.

[puneetlath]

That is very weird! I added the payment as a bonus, so it should be there now.

[FitseTLT]

Yep, I received it now. Thx!

[JmillsExpensify]

$250 approved for @eVoloshchak