[HOLD for payment 2024-12-20] [$250] Expense shared with accountant shows incorrect rate

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @paultsimura
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722892285723489

Action Performed:

1. Open the chat with yourself
2. Submit a Distance request
3. In the Concierge prompt, click "Share it with my accountant"
4. Select a workspace and a different rate
5. Submit the request
6. Navigate to the request details page

Expected Result:

• The Rate field shows the value selected while sharing the expense.
• There should be a proper descriptive "shared the expense" report action in the thread or no action at all

Actual Result:

• The Rate field shows a default p2p rate ($0.89)
• There is a "changed the expense" report action in the thread

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

354815793-ed56f179-938c-4d0c-9569-4416a6093059.mp4

Recording.415.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019b051306a76e7ed6
• Upwork Job ID: 1821591099314477155
• Last Price Increase: 2024-10-24
• Automatic offers:
• paultsimura | Contributor | 104594407

Issue Owner

Current Issue Owner: @sonialiap / @mallenexpensify

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019b051306a76e7ed6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

@Pujan92, @sonialiap Huh... This is 4 days overdue. Who can take care of this?

[wildan-m]

How can we enable the rate option for personal track expense? I think distance rate feature only available in workspace

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@Pujan92, @sonialiap Still overdue 6 days?! Let's take care of this!

[sonialiap]

@wildan-m I believe you're correct that you can't change the rate on a personal expense, but you don't need to do that. For this issue you want to have a workspace with multiple rates. Then, once you share the expense with someone on that workspace you will have the option to select one of the workspace rates

[sonialiap]

I'm OOO Aug 19-30, adding leave buddy

Status: Status: waiting for/ c+ reviewing proposals

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[paultsimura]

I would suggest holding this issue for #47136 - I’m planning to address a couple of Rate-related issues in it holistically. Currently we are discussing potential BE changes that will help eliminate multiple existing bugs easier.

[melvin-bot]

@Pujan92, @sonialiap, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@Pujan92 @sonialiap @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[neil-marcellini]

@NickTooker may we please have a copy check based on this comment?

[NickTooker]

@neil-marcellini and I discussed the copy in Slack. We've agreed on the final version of the below:

Rate not valid for this workspace. Please select an available rate from the workspace.

moved expense from self DM to chat with [name]

[NickTooker]

Add me back to this issue if/when I am needed please.

[mallenexpensify]

moved expense from self DM to chat with [name]

Does the 'm' in moved above need to be capitalized?

[paultsimura]

moved expense from self DM to chat with [name]

Does the 'm' in moved above need to be capitalized?

We don't usually capitalize the MODIFIEDEXPENSE messages:

[melvin-bot]

@paultsimura, @Pujan92, @sonialiap, @mallenexpensify, @neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!

[paultsimura]

Not overdue, adding to the PR today.

[melvin-bot]

@paultsimura, @Pujan92, @sonialiap, @mallenexpensify, @neil-marcellini Eep! 4 days overdue now. Issues have feelings too...

[paultsimura]

The PR is ready for review.

cc: @Pujan92

[melvin-bot]

@paultsimura, @Pujan92, @sonialiap, @mallenexpensify, @neil-marcellini Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@paultsimura, @Pujan92, @sonialiap, @mallenexpensify, @neil-marcellini 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: distance - share with accountant #51517

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Contributor)
• @Pujan92 requires payment through NewDot Manual Requests
• @paultsimura requires payment automatic offer (Contributor)

[melvin-bot]

@paultsimura / @Pujan92 @sonialiap / @mallenexpensify @paultsimura / @Pujan92 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mallenexpensify]

hmm... wonder why @paultsimura is mentioned twice above. Going to :donothing: since I've yet to see this before