[HOLD for payment 2025-02-05] [$250] Expense shared with accountant shows incorrect rate

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @paultsimura
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722892285723489

Action Performed:

1. Open the chat with yourself
2. Submit a Distance request
3. In the Concierge prompt, click "Share it with my accountant"
4. Select a workspace and a different rate
5. Submit the request
6. Navigate to the request details page

Expected Result:

• The Rate field shows the value selected while sharing the expense.
• There should be a proper descriptive "shared the expense" report action in the thread or no action at all

Actual Result:

• The Rate field shows a default p2p rate ($0.89)
• There is a "changed the expense" report action in the thread

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

354815793-ed56f179-938c-4d0c-9569-4416a6093059.mp4

Recording.415.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019b051306a76e7ed6
• Upwork Job ID: 1821591099314477155
• Last Price Increase: 2024-10-24
• Automatic offers:
• paultsimura | Contributor | 104594407

Issue Owner

Current Issue Owner: @Pujan92

Issue Owner

Current Issue Owner: @sonialiap / @mallenexpensify

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019b051306a76e7ed6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

@Pujan92, @sonialiap Huh... This is 4 days overdue. Who can take care of this?

[wildan-m]

How can we enable the rate option for personal track expense? I think distance rate feature only available in workspace

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@Pujan92, @sonialiap Still overdue 6 days?! Let's take care of this!

[sonialiap]

@wildan-m I believe you're correct that you can't change the rate on a personal expense, but you don't need to do that. For this issue you want to have a workspace with multiple rates. Then, once you share the expense with someone on that workspace you will have the option to select one of the workspace rates

[sonialiap]

I'm OOO Aug 19-30, adding leave buddy

Status: Status: waiting for/ c+ reviewing proposals

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[paultsimura]

I would suggest holding this issue for #47136 - I’m planning to address a couple of Rate-related issues in it holistically. Currently we are discussing potential BE changes that will help eliminate multiple existing bugs easier.

[melvin-bot]

@Pujan92, @sonialiap, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@Pujan92 @sonialiap @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[sonialiap]

Neil is OOO through the end of this week. Looks like he should be back on Monday the 13th

[melvin-bot]

@paultsimura, @Pujan92, @sonialiap, @mallenexpensify, @neil-marcellini Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@paultsimura, @Pujan92, @sonialiap, @mallenexpensify, @neil-marcellini Still overdue 6 days?! Let's take care of this!

[neil-marcellini]

I'm back and looks like I need to research the root cause of the problem reported here. I'll work on it at a weekly pace since it's not very high priority

[neil-marcellini]

I couldn't reproduce said problem so it's back in the hands of the contributor.

[paultsimura]

PR is ready for review: #54669
cc: @Pujan92

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: distance request sharing #54669

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Contributor)
• @Pujan92 requires payment through NewDot Manual Requests
• @paultsimura requires payment automatic offer (Contributor)

[melvin-bot]

@paultsimura / @Pujan92 @sonialiap / @mallenexpensify @paultsimura / @Pujan92 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[sonialiap]

Payment summary

• @paultsimura $250 - paid in upwork
• @Pujan92 $250 NewDot - please complete the checklist

[Pujan92]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• [] 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/38543/files#r1944124101

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/468104

Regression Test Proposal

Prerequisite: You are owner or a part of a workspace where custom distance rates are available.

1. Track the distance request
2. Select the option "Share it with my accountant" for that request
3. Select a workspace and choose a different distance rate
4. Submit the request and navigate to the request details page
5. Verify the Rate value shows the correct distance rate and not the default rate

Do we agree 👍 or 👎