[$250] [HOLD for payment 2024-08-14] Sage - "It's not here" error when clicking on the "Reconciliation account" link

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: #46400
Issue reported by: Applause Internal Team

Action Performed:

1. Open the app
2. Log in with a new expensifail account
3. Click on FAB - New workspace
4. Enable "Accounting" and "Expensify Card" in the "More features" page.
5. Navigate to "Accounting"
6. Connect to Sage Intacct and upgrade the workspace to Control when asked
7. Wait for the sync to finish
8. Click on "Card reconciliation"
9. Enable "Continuous Reconciliation"
10. Click on the "Expensify Card settlement account" link
11. Click on the "Reconciliation account" link

Expected Result:

I should be redirected to the page.

Actual Result:

"It's not here" error when clicking on the "Reconciliation account" link.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6564308_1723033850286.bandicam_2024-08-07_14-27-43-601.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0131ac7035a283d784
• Upwork Job ID: 1822986584397052060
• Last Price Increase: 2024-08-12

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[trjExpensify]

@mountiny @MariaHCD this is still in development, right?

[mountiny]

@trjExpensify yeah this is still in development, although I dont think the page behind beta as far as I can see

The problem seems to be that the last link leads to quickbooks integration instead of sage.

[koko57]

looks like dupe of #46108

as you can see we have a proper URL in the browser bar - we are navigated to the correct page but as the reconciliation is not enabled AccessOrNotFoundWrapper renders NotFound page. The link that navigates to this page should not be visible though, it was made visible for testing purposes. It will all work when we have reconciliation setting connected to BE

[mountiny]

as you can see we have a proper URL in the browser bar - we are navigated to the correct page but as the reconciliation is not enabled AccessOrNotFoundWrapper renders NotFound page

@koko57 I think it navigated to quickbooks/account page which is not correct, is it?

Either way, lets fix the deploy blocker by hiding the Card reconciliation button with the workspace feeds beta as we need to test this first

[trjExpensify]

Yeah, I don't think the Card reconciliation button shouldn't be visible unless you've enabled the Expensify Card feature right? 🤔

Doc Ref: https://docs.google.com/document/d/1sTg-e11jdOmregOFBhdO8ALlykKl8PqTeTEAgEMS6mU/edit#bookmark=id.7jdf90bmlm1j

When an Expensify Card is provisioned on the relevant workspace, or enabled on the domain and set to report transactions on the relevant workspace, we’ll show an additional option row within our integrations, called Card reconciliation. As discussed here, this is a clearer framing than using “Continuous reconciliation”.

[koko57]

@trjExpensify but in the video and test steps Expensify Card is enabled - so I guess the betas were enabled here, but I will check ofc if the button is visible when Expensify Card is enabled

[trjExpensify]

Yeah, I tested it on a random gmail account not on the workspaceFeeds beta. We still show the Card reconciliation tab in the accounting integration settings..

2024-08-07_14-57-01.mp4

[mountiny]

We still show the Card reconciliation tab in the accounting integration settings..

Yep there is no beta check for the button right now, we need to add that to resolve this blocker

[joekaufmanexpensify]

Seems like we're well on our way to fixing this, but LMK if there is anything I can help with!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix/46963 hide card reconciliation button #46978

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[allgandalf]

Why melvin, this has payment due on 14th, payment summery here

[joekaufmanexpensify]

All good, corrected

[joekaufmanexpensify]

@allgandalf please complete BZ so we can prep for payment

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0131ac7035a283d784

[melvin-bot]

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

[joekaufmanexpensify]

Only payment here is $250 to @allgandalf for C+ review via upwork

[allgandalf]

@allgandalf please complete BZ so we can prep for payment

This doesn't need a checklist, this issue was part of a project and regression tests are added at the end of the projects right? LMK if we still need one, happy to provide 😄

[joekaufmanexpensify]

Ah, yeah fair point. This one is still in active development, so agree we prob don't need to add an ad-hoc test.

[joekaufmanexpensify]

@allgandalf offer sent for $250!

[joekaufmanexpensify]

All set to issue payment!

[joekaufmanexpensify]

@allgandalf $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set here, thanks everyone!