Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - New Message badge always displays 1 new message even when multiple are received #4712

Closed
kavimuru opened this issue Aug 17, 2021 · 5 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #4603

Action Performed:

  1. Open app and login
  2. Open a chat with several messages
  3. Scroll 6-8 messages back
  4. On the other side, send some messages on this same chat

Expected Result:

User is able to see New Message badge and it correctly indicates how many new messages are there

Actual Result:

New Message marker will always show 1 message regardless of how many

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web ✔️
  • iOS ✔️
  • Android ✔️
  • Desktop App ✔️
  • Mobile Web ✔️

Version Number: 1.0.86-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5197731_New_Expensify_-_Google_Chrome_8_17_2021_7_16_34_PM

Expensify/Expensify Issue URL:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Aug 17, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

Duplicate of #4669

@isagoico
Copy link

isagoico commented Aug 18, 2021

@parasharrajat We raised this because it's failing QA for #4603. Should we close this since it's already addressed in #4669 ?

@parasharrajat
Copy link
Member

Yes. Please close it other one is already triaged. If you think that this is different than the other one then let me know the difference and keep it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants