Show new marker indicator while user is scrolled up! #4723

Santhosh-Sellavel · 2021-08-18T06:46:42Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

From conclusions based on this discussion! https://expensify.slack.com/archives/C01GTK53T8Q/p1628782470250300

Action Performed:

Open any user chat window.
Scroll up through the history
When a new message arrives, a new messages badge is shown.
Click the badge will scroll down, but there is no new marker indication above the new message received

Expected Result:

On scroll back below should show a new marker indicator like this, above a new message.

Actual Result:

No indicator after scroll down.

Simulator.Screen.Recording.-.iPhone.12.-.2021-08-18.at.13.10.49.mp4

Workaround:

Can the user still use Expensify without this being fixed? Yes
It's an improvement.

Platform:

Where is this issue occurring? All

Web
iOS
Android
Desktop App
Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on GitHub

The text was updated successfully, but these errors were encountered:

MelvinBot · 2021-08-18T06:46:44Z

Triggered auto assignment to @cdraeger11 (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Santhosh-Sellavel · 2021-08-22T20:08:00Z

Updated Proposal

A part of the solution is already discussed here #4357 (comment)

From these lines

App/src/pages/home/report/ReportActionsView.js

Lines 130 to 137 in bdcafa3

    
           // Since we want the New marker to remain in place even if newer messages come in, we set it once on mount. 
        
           // We determine the last read action by deducting the number of unread actions from the total number. 
        
           // Then, we add 1 because we want the New marker displayed over the oldest unread sequence. 
        
           const oldestUnreadSequenceNumber = this.props.report.unreadActionCount === 0 
        
               ? 0 
        
               : (this.props.report.maxSequenceNumber - this.props.report.unreadActionCount) + 1; 
        
           setNewMarkerPosition(this.props.reportID, oldestUnreadSequenceNumber);

A method updateUnreadIndicatorPosition will be created.

Waiting for PR #4773 to merge, will update the complete proposal again. Because the PR is related to markerBadge.
Based on the confirmation from here need to reuse logic from @parasharrajat work!

Changes been merged:

Invoking the updateUnreadIndicatorPosition from the below lines,

App/src/pages/home/report/ReportActionsView.js

Lines 394 to 396 in 170ec90

    
           updateLocalUnreadActionCount() { 
        
               this.setState(prevState => ({localUnreadActionCount: prevState.localUnreadActionCount + this.props.report.unreadActionCount})); 
        
           }

Like shown below,

MelvinBot · 2021-08-23T19:00:33Z

@cdraeger11 Huh... This is 4 days overdue. Who can take care of this?

MelvinBot · 2021-08-25T19:00:25Z

@cdraeger11 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

MelvinBot · 2021-08-27T19:04:11Z

@cdraeger11 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

botify · 2021-08-30T15:45:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

botify · 2021-08-30T17:32:46Z

🚀 Deployed to staging by @Beamanator in version: 1.0.88-3 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

botify · 2021-08-30T17:36:39Z

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

botify · 2021-08-30T17:37:07Z

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

botify · 2021-08-30T17:37:19Z

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

botify · 2021-09-13T18:30:48Z

🚀 Deployed to production by @francoisl in version: 1.0.97-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-13T19:26:21Z

🚀 Deployed to staging by @marcaaron in version: 1.0.97-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-13T19:26:23Z

🚀 Deployed to staging by @johnmlee101 in version: 1.0.97-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-13T19:26:33Z

🚀 Deployed to staging by @Beamanator in version: 1.0.97-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-13T19:26:38Z

🚀 Deployed to staging by @Jag96 in version: 1.0.97-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-13T19:26:42Z

🚀 Deployed to staging by @stitesExpensify in version: 1.0.97-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-13T19:51:15Z

🚀 Deployed to staging by @marcaaron in version: 1.0.97-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-13T20:19:52Z

🚀 Deployed to staging by @marcaaron in version: 1.0.97-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-14T17:27:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

botify · 2021-09-14T19:08:14Z

@pROFESOR11, Great job getting your first Expensify/App pull request over the finish line! 🎉

I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:

Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time.
Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression.
Once your PR is deployed to production, we start a 7-day timer ⏰. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. 💰

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊

botify · 2021-09-14T19:08:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

botify · 2021-09-14T21:36:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

botify · 2021-09-15T08:45:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

botify · 2021-09-15T14:31:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

botify · 2021-09-15T20:25:11Z