Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for Payment 2024-09-10][$250] [Search v2.2] Create chat filter - Has #47497

Closed
luacmartins opened this issue Aug 15, 2024 · 9 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Aug 15, 2024

Implement this section of the design doc for the Has filter only! It should accept two values: attachment, link.

This is a type=chat specific filter, so the UI should only render it if the user is currently viewing the chat type.

cc @289Adam289 @Kicu @Guccio163

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011f1f3a0aaab90767
  • Upwork Job ID: 1826635907294867133
  • Last Price Increase: 2024-08-22
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @289Adam289
Copy link

melvin-bot bot commented Aug 20, 2024

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

@luacmartins
Copy link
Contributor Author

cc @289Adam289 @Kicu @Guccio163 if you have availability to work on this one.

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2024
@289Adam289
Copy link
Contributor

Hi @luacmartins! I can work on this filter

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Aug 22, 2024
@melvin-bot melvin-bot bot changed the title [Search v2.2] Create chat filter - Has [$250] [Search v2.2] Create chat filter - Has Aug 22, 2024
Copy link

melvin-bot bot commented Aug 22, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011f1f3a0aaab90767

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 22, 2024
Copy link

melvin-bot bot commented Aug 22, 2024

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

@luacmartins luacmartins added NewFeature Something to build that is a new item. and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Aug 22, 2024
Copy link

melvin-bot bot commented Aug 22, 2024

Triggered auto assignment to @abekkala (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 22, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Aug 22, 2024
@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Aug 26, 2024
@rayane-d
Copy link
Contributor

rayane-d commented Sep 9, 2024

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-09-10] according to #48438 production deploy checklist, confirmed in #47918 (comment)

cc @abekkala

@luacmartins luacmartins changed the title [$250] [Search v2.2] Create chat filter - Has [HOLD for Payment 2024-09-10][$250] [Search v2.2] Create chat filter - Has Sep 9, 2024
@luacmartins luacmartins added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Sep 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 Overdue labels Sep 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@abekkala
Copy link
Contributor

PAYMENT SUMMARY:

@abekkala
Copy link
Contributor

@rayane-djouah payment sent and contract ended - thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

4 participants