[$250] Web - Scan-GBR instead of RBR displayed in LHN for Admin

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.20-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4693685
Issue reported by: Applause Internal Team

Action Performed:

Precondition: There is a WS created, with an admin and an employee.

1. Log in as the employee and submit a scan receipt to the WS
2. While the receipt is scanning, edit the merchant field and leave the amount field empty( to trigger the error message and the RBR)
3. Submit the expense and log out
4. Log in as the admin
5. Navigate to the WS chat in LHN

Expected Result:

The RBR is displayed in the LHN, in the request preview and the request details.

Actual Result:

For the Admin, there is a Green Dot displayed in the LHN, while in the request preview and details the dot is Red.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6532962_1720088723127.RBR-GBR.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01114847a6aa18235d
• Upwork Job ID: 1824130592527843469
• Last Price Increase: 2024-10-10

Issue Owner

Current Issue Owner: @mollfpr

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01114847a6aa18235d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

For the Admin, there is a Green Dot displayed in the LHN, while in the request preview and details the dot is Red.

What is the root cause of that problem?

• We only display the RBR in LHN if the action is taken by current user:
  

  App/src/libs/OptionsListUtils.ts

  Line 536 in 9769bff

  if (ReportActionUtils.wasActionTakenByCurrentUser(parentReportAction) && ReportActionUtils.isTransactionThread(parentReportAction)) {

  
  

  App/src/libs/ReportUtils.ts

  Line 3178 in 9769bff

  if (!ReportActionsUtils.wasActionTakenByCurrentUser(action)) {

What changes do you think we should make in order to solve the problem?

• We should display RBR if the current user is admin.
• So it:
  

  App/src/libs/OptionsListUtils.ts

  Line 536 in 9769bff

  if (ReportActionUtils.wasActionTakenByCurrentUser(parentReportAction) && ReportActionUtils.isTransactionThread(parentReportAction)) {

  
  should be:

    const policyID = report?.policyID;
    const isAdmin = PolicyUtils.getPolicy(policyID)?.role === 'admin';
    if ((ReportActionUtils.wasActionTakenByCurrentUser(parentReportAction) || isAdmin) && ReportActionUtils.isTransactionThread(parentReportAction)) {

and

App/src/libs/ReportUtils.ts

Line 3178 in 9769bff

if (!ReportActionsUtils.wasActionTakenByCurrentUser(action)) {

should be:

        const report = getReport(action.reportID);
        const isAdmin = getPolicy(report?.reportID).role === 'admin';
        if (!ReportActionsUtils.wasActionTakenByCurrentUser(action) && !isAdmin) {

What alternative solutions did you explore? (Optional)

• We can remove ReportActionsUtils.wasActionTakenByCurrentUser check in:
  

  App/src/libs/OptionsListUtils.ts

  Line 536 in 9769bff

  if (ReportActionUtils.wasActionTakenByCurrentUser(parentReportAction) && ReportActionUtils.isTransactionThread(parentReportAction)) {

  
  and
  

  App/src/libs/ReportUtils.ts

  Line 3178 in 9769bff

  if (!ReportActionsUtils.wasActionTakenByCurrentUser(action)) {

[mollfpr]

We've discussed this extensively, and decided that we would treat the RBR on the LHN different than the money request view.

The RBR on the LHN should only show for the user that made the request. The RBRs on the report preview, money request preview, and the ones in the money request view, should show to every user that has access to them.

The reasoning we're using here is that the user that made the request is the one that should be guided towards taking actions to fix the RBR, and that guidance starts with the chat on the LHN.

Moreover, we don't want to hide RBRs in report previews, money request previews, or the money request view, to anyone that has access to the money requests. And if they have RBRs, we should show them because there's no value in hiding information from people that have access to it.

Quoting from #37044 (comment), it's expected that the RBR is only shown for the requestor. @adelekennedy Could you help confirm? Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[adelekennedy]

You're correct @mollfpr! I think we can close this one

[melvin-bot]

@mollfpr, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@mollfpr, @adelekennedy 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@mollfpr @adelekennedy this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@mollfpr, @adelekennedy Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[trjExpensify]

What are we doing here? Isn't there still a bug insofar as the green dot on the workspace chat for the admin for an expense report that is $0 containing only the failed receipt scan? CC: @JmillsExpensify if I'm missing something, but seems like that shouldn't be there:

[melvin-bot]

@mollfpr, @adelekennedy 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

This issue has not been updated in over 14 days. @mollfpr, @adelekennedy eroding to Weekly issue.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@mollfpr @adelekennedy this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

This issue has not been updated in over 15 days. @mollfpr, @adelekennedy eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mollfpr]

@adelekennedy @trjExpensify What's the next step here?

I'm checking the latest main and here's the result.

Admin

Employee

The RBR in LHN is not showing for the admin.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[trjExpensify]

Isn't there still a bug insofar as the green dot on the workspace chat for the admin for an expense report that is $0 containing only the failed receipt scan?

Great, looks like that's resolved then. Let's close it!