[HOLD for payment 2024-09-26] [$250] Update UpdatePolicyConnectionConfiguration to be 1:1:1 - Part 5

[dangrous]

Problem

Our UpdatePolicyConnectionConfiguration API command is not 1:1:1 - it is the same API call for all related user actions, when it should be split up for each connection (QBO, Xero, etc.) and configuration setting (autoSyncVendor, enableNewCategories, etc.). At the end of this we should not call that function anywhere.

This is polish for the Collect QBO project.

Solution

When we created the NetSuite commands, we followed the correct pattern, and so need to do so here too.

This requires backend and frontend work in tandem (to create the commands and then to use them), so we're looking for a contributor(s) to handle the frontend. You can see an example PR here - there is some extra prep work there that you can ignore, but adjusting all calls like this is what we're going for:

- Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_ACCOUNT, row.value);
+ QuickbooksOnline.updateQuickbooksOnlineReimbursableExpensesAccount(policyID, row.value);

Here is a list of the commands handled in this issue:

• UpdateQuickbooksOnlineReceivableAccount
• UpdateQuickbooksOnlineExportDate
• UpdateQuickbooksOnlineNonReimbursableExpensesAccount
• UpdateQuickbooksOnlineCollectionAccountID

If there are others that follow the same pattern as UpdateQuickbooksOnlineExport (same object, different keys) we will need to split those as well.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f77142563137f66e
• Upwork Job ID: 1825578111419953725
• Last Price Increase: 2024-08-19
• Automatic offers:
• hoangzinh | Contributor | 103590171

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @hoangzinh

[hoangzinh]

Hi @dangrous, I can help to work on this issue.

[dangrous]

@rushatgabhane can you comment here so I can assign you as C+ before assigning @hoangzinh?

[rushatgabhane]

hello

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f77142563137f66e

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@dangrous, @hoangzinh, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hoangzinh]

Not overdue. PR is still in progress

[dangrous]

fyi @hoangzinh backend pr is now deployed so you should be able to test!

[hoangzinh]

Thanks for the heads up @dangrous.

[hoangzinh]

Hi @dangrous I tried to test but it's retuning 404 error. Is it because staging has not been deployed successfully yet?

[dangrous]

Noted in Slack but for the GitHub record - QBO backend PR not yet on staging, should be there today!

[dangrous]

on staging! should be ready to test.

[melvin-bot]

@dangrous, @hoangzinh, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hoangzinh]

Not overdue. PR is still in progress. I'm doing recordings for the PR. Can complete the PR in this week

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dangrous]

@greg-schroeder just grabbing you for eventual payment; this hasn't hit prod yet but should shortly!

[greg-schroeder]

Consider me grabbed

[greg-schroeder]

Deployed 9/19, regression period should go to 9/26 I believe

[greg-schroeder]

@dangrous @hoangzinh Is this comment accurate?

[dangrous]

Nope, no blocker! It was a sync issue but not specific to this PR. (Correct me if I'm wrong @hoangzinh @rushatgabhane )

[greg-schroeder]

Sounds good! All set for tomorrow:

Payment summary:

Contributor: @hoangzinh - $250 - To be paid via Upwork 9/26
C+: @rushatgabhane - $250 - You can make a manual request via ND

[garrettmknight]

$250 approved for @rushatgabhane