Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert conditional in auth/command/TakePolicyOwnership.cpp #47528

Closed
blimpich opened this issue Aug 15, 2024 · 10 comments
Closed

revert conditional in auth/command/TakePolicyOwnership.cpp #47528

blimpich opened this issue Aug 15, 2024 · 10 comments
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@blimpich
Copy link
Contributor

blimpich commented Aug 15, 2024

See this comment for context: #46994 (comment)

We have to wait till both of these PRs are merged:

And then we need to quickly do what is outlined here: https://github.com/Expensify/Auth/pull/11946/files#diff-5187b8b526029197fbf1394c069d4a11f7a14dc2cbd436115206dd744aa70befR69

@blimpich
Copy link
Contributor Author

Not overdue, held on https://github.com/Expensify/Auth/pull/11946

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 19, 2024
Copy link

melvin-bot bot commented Aug 22, 2024

@blimpich Whoops! This issue is 2 days overdue. Let's get this updated quick!

@blimpich
Copy link
Contributor Author

still waiting on auth PR to get merged and then the web pr

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 22, 2024
@blimpich
Copy link
Contributor Author

Not overdue, status unchanged, still held

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 26, 2024
@blimpich
Copy link
Contributor Author

Not overdue, PR is out, waiting for https://github.com/Expensify/Web-Expensify/pull/43074 to deploy to production, which is when we'll be able to get a green build on the PR for this issue.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 28, 2024
Copy link

melvin-bot bot commented Sep 3, 2024

@blimpich Huh... This is 4 days overdue. Who can take care of this?

@blimpich
Copy link
Contributor Author

blimpich commented Sep 3, 2024

Calm down melvin, waiting

@melvin-bot melvin-bot bot removed the Overdue label Sep 3, 2024
@blimpich
Copy link
Contributor Author

blimpich commented Sep 3, 2024

Out for review

@blimpich blimpich added the Reviewing Has a PR in review label Sep 3, 2024
Copy link

melvin-bot bot commented Sep 11, 2024

@blimpich Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@blimpich
Copy link
Contributor Author

Finished and deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

1 participant