[$250] [Navigation Bug]: The Back button in the confirm page close RHP

[dylanexpensify]

Coming from this project, we have this follow-up polish issue we need to complete where the back button in the confirm page closes the RHP. More details here.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0134a56cd991934297
• Upwork Job ID: 1825862477363321355
• Last Price Increase: 2024-08-20

Issue Owner

Current Issue Owner: @

[dylanexpensify]

cc @blazejkustra

[blazejkustra]

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0134a56cd991934297

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[dylanexpensify]

Hi @blazejkustra! It's all yours!

[blazejkustra]

Before:

Bug: The Back button in the confirm page should navigate back to approver selection page (link)

356328274-2b92fcaa-8970-4b16-a10f-42e20d417689.mov

After:
Going back on create approval screen navigates back to the first approver screen as shown on the video.

Screen.Recording.2024-08-20.at.15.46.46.mov

Before I proceed with implementation I'd like to ask about your input @JmillsExpensify @tgolen @Expensify/design - do you prefer this updated approach?

[Lalarukh-khan]

I have also applied on Upwork. Can I get an opportunity to get it done?

[melvin-bot]

📣 @Lalarukh-khan! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Lalarukh-khan]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01152db88584b3187c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[belawalumer]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01f81b79aedaff801c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[kanha55]

hello
Where I can submit the proposals on GitHub?

[melvin-bot]

📣 @kanha55! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[kanha55]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0125c7c7adee611508

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[kanha55]

I am submitting my proposal
Step 1: Understand the Issue

The back button on the confirm page should navigate to the previous page but instead closes the Right-Hand Panel (RHP).

Step 2: Check the Code

Identify the specific component responsible for the back button functionality within the confirm page.
Analyze the navigation logic, focusing on the current behavior of the back button.

Step 3: Review Approvers Page

Investigate how the navigation works on the Approvers page (RHP) since it's working correctly.
Apply the same logic or implementation to the confirm page (RHP).

Step 4: Fix the Navigation on confirm page

Modify the back button's action on the confirm page to ensure it correctly navigates to the approver selection page rather than closing the RHP.

Step 5: Test the Fix

Test the functionality by navigating through the pages to confirm that the issue is resolved and the back button behaves as expected.

Step 6: Write Test Cases

Write the necessary test cases to cover the changes made to the back button functionality.

Step 7: Create a Pull Request

Once the fix is confirmed, submit a pull request with a detailed explanation of the changes, including the logic behind the fix and the tests you've written.

[blazejkustra]

@dylanexpensify Could you remove Help wanted tag? 😅

[JmillsExpensify]

@blazejkustra yes, we prefer the updated approach!

[blazejkustra]

@DylanDylann PR is up!

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @tylerkaraszewski, @blazejkustra, @DylanDylann eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[DylanDylann]

@tylerkaraszewski Please help process the payment for me. Thanks

[tylerkaraszewski]

Not sure why @dylanexpensify was unassigned, he should be able to do that.

[dylanexpensify]

Payment summary:

Contributor+: @DylanDylann $250 via Upwork

Please apply/request!

[DylanDylann]

@dylanexpensify The Upwork job is no longer available, could you create a new job and send the offer to my profile here? https://www.upwork.com/freelancers/~010c6310ab55f3d17d

Thanks

[dylanexpensify]

@DylanDylann yes!

[dylanexpensify]

@DylanDylann sent invite!

[DylanDylann]

@dylanexpensify thanks, I applied to the job

[dylanexpensify]

@DylanDylann sent!

[DylanDylann]

@dylanexpensify accepted!

[dylanexpensify]

Done!