Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact methods - User is nor navigated to contact methods details page #47814

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 21, 2024 · 5 comments
Closed
1 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 21, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.23-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
**Email or phone of affected tester (no customers):**[email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #44635

Action Performed:

  1. Sign up with a new account > click on Settings > Security > Two-factor authentication.
  2. Click on 'Verify your account here' link
  3. On contact methods details page.

Expected Result:

User is redirected to contact method page

Actual Result:

User is redirected to 2FA page

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2415.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlocker Indicates it should block deploying the API label Aug 21, 2024
@daledah
Copy link
Contributor

daledah commented Aug 21, 2024

Edited by proposal-police: This proposal was edited at 2023-10-17T12:34:56Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is redirected to 2FA page

What is the root cause of that problem?

We are not navigating user to contact methods page when clicking on "Verify your account here" in here.

What changes do you think we should make in order to solve the problem?

Should navigate to ROUTES.SETTINGS_CONTACT_METHODS.route instead.

We need to add the backTo param to this route as we did in the original logic, it is very simple and can implement in the PR stage.

What alternative solutions did you explore? (Optional)

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 21, 2024
@mvtglobally mvtglobally added the DeployBlockerCash This issue or pull request should block deployment label Aug 21, 2024
Copy link

melvin-bot bot commented Aug 21, 2024

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 21, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@cead22 cead22 removed the DeployBlocker Indicates it should block deploying the API label Aug 21, 2024
@etCoderDysto
Copy link
Contributor

etCoderDysto commented Aug 21, 2024

Test steps from the PR:

  1. Sign up with a new account > click on Settings > Security > Two-factor authentication.
  2. Click on 'Verify your account here' link
    Verify that you are navigated to contact methods details page
  3. Validate your account
    Verify that you are redirected to 2FA page

This is expected. This behaviour was intentionally introduced by this PR

cc: @mollfpr

@bondydaa
Copy link
Contributor

sounds like we can close this out then, thanks @etCoderDysto 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants