[$250] Categories - Employee has the option to edit categories when all the categories are disabled #48097

lanitochka17 · 2024-08-27T14:42:17Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.25-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4895538
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

Admin and employee are in the same workspace

Go to staging.new.expensify.com
[Employee] Go to workspace chat
[Employee] Click + > Submit expense > Manual
{Employee] Enter amount > Next
[Employee] Click Category on the confirmation page
[Admin] Disable all the categories

Expected Result:

Category page will turn to not here page for employee after admin disables all the categories

Actual Result:

Category page turns to empty state page with Edit categories button for employee which leads to not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6584008_1724750744231.20240827_172136.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01775966fb678bc1d8
Upwork Job ID: 1828566383512584614
Last Price Increase: 2024-08-27
Automatic offers:

DylanDylann | Reviewer | 103734142
nkdengineer | Contributor | 103734143

Issue Owner

Current Issue Owner: @DylanDylann

melvin-bot · 2024-08-27T14:42:29Z

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 · 2024-08-27T14:42:59Z

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 · 2024-08-27T14:43:18Z

We think that this bug might be related to #wave-collect - Release 1

melvin-bot · 2024-08-27T14:53:06Z

📣 @akshsekhr2702! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

FitseTLT · 2024-08-27T14:53:19Z

Edited by proposal-police: This proposal was edited at 2024-08-27 14:56:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories - Employee has the option to edit categories when all the categories are disabled

What is the root cause of that problem?

We are not checking if the user can update category when we display empty state section here

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Lines 170 to 173 in 0fd1de0

    
           {shouldShowEmptyState && ( 
        
               <View style={[styles.flex1]}> 
        
                   <WorkspaceEmptyStateSection 
        
                       shouldStyleAsCard={false}

What changes do you think we should make in order to solve the problem?

We can check if the user is admin before displaying the empty section

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Line 114 in 0fd1de0

const shouldShowEmptyState = !isLoading && !shouldShowCategory;

    const shouldShowEmptyState = !isLoading && !shouldShowCategory && isPolicyAdmin(policy);

and display not found page when it is not policy admin and no categories in the list

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Line 103 in 0fd1de0

    
           const shouldShowNotFoundPage = isEditing && (isSplitBill ? !canEditSplitBill : !ReportActionsUtils.isMoneyRequestAction(reportAction) || !ReportUtils.canEditMoneyRequest(reportAction));

const shouldShowNotFoundPage =
        (isEditing && (isSplitBill ? !canEditSplitBill : !ReportActionsUtils.isMoneyRequestAction(reportAction) || !ReportUtils.canEditMoneyRequest(reportAction))) ||
        (!isLoading && !shouldShowCategory && !isPolicyAdmin(policy));

What alternative solutions did you explore? (Optional)

nkdengineer · 2024-08-27T14:57:19Z

Edited by proposal-police: This proposal was edited at 2024-08-27 15:01:22 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Category page turns to empty state page with Edit categories button for employee which leads to not here page

What is the root cause of that problem?

We always show the edit category button even the user is not an admin of the workspace

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Line 179 in 6ca91cd

What changes do you think we should make in order to solve the problem?

We can use isPolicyAdmin function to check whether the user is an admin or not then use it to show the edit category button or we can add disabled prop for this button with isPolicyAdmin check.

PolicyUtils.isPolicyAdmin(policy) && (
    // Edit category button
)

OPTIONAL: We can display another message like Ask the admin to edit the category
We should still show the empty state component

What alternative solutions did you explore? (Optional)

If we want to display not found page in this case, we can add the condition to show not found page if shouldShowEmptyState is true and the user isn't the admin of the WS

const shouldShowNotFoundPage = (isEditing && (isSplitBill ? !canEditSplitBill : !ReportActionsUtils.isMoneyRequestAction(reportAction) || !ReportUtils.canEditMoneyRequest(reportAction))) || (shouldShowEmptyState && !PolicyUtils.isPolicyAdmin(policy));

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Line 103 in 6ca91cd

    
           const shouldShowNotFoundPage = isEditing && (isSplitBill ? !canEditSplitBill : !ReportActionsUtils.isMoneyRequestAction(reportAction) || !ReportUtils.canEditMoneyRequest(reportAction));

Krishna2323 · 2024-08-27T15:01:12Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories - Employee has the option to edit categories when all the categories are disabled

What is the root cause of that problem?

The shouldShowNotFoundPage variable isn't checking if the user is a admin or not.

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Line 103 in 6ca91cd

    
           const shouldShowNotFoundPage = isEditing && (isSplitBill ? !canEditSplitBill : !ReportActionsUtils.isMoneyRequestAction(reportAction) || !ReportUtils.canEditMoneyRequest(reportAction));

What changes do you think we should make in order to solve the problem?

We can update the condition:

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Line 103 in 6ca91cd

    
           const shouldShowNotFoundPage = isEditing && (isSplitBill ? !canEditSplitBill : !ReportActionsUtils.isMoneyRequestAction(reportAction) || !ReportUtils.canEditMoneyRequest(reportAction));

TO:

    const shouldShowNotFoundPage =
        (isEditing && (isSplitBill ? !canEditSplitBill : !ReportActionsUtils.isMoneyRequestAction(reportAction) || !ReportUtils.canEditMoneyRequest(reportAction))) ||
        (PolicyUtils.isPolicyAdmin(policy) && !OptionsListUtils.hasEnabledOptions(Object.values(policyCategories ?? {})));

What alternative solutions did you explore? (Optional)  

Result

nkdengineer · 2024-08-27T15:01:29Z

Updated proposal

Add alternative solution

melvin-bot · 2024-08-27T22:52:55Z

Job added to Upwork: https://www.upwork.com/jobs/~01775966fb678bc1d8

melvin-bot · 2024-08-27T22:52:59Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

stephanieelliott · 2024-08-27T22:55:06Z

Yea I agree this is not working as expected, there is a delay in hiding the categories once they are disabled.

DylanDylann · 2024-08-29T09:59:47Z

Thanks everyone, @FitseTLT and @Krishna2323 have the same idea of displaying the not found page. But I prefer to display an empty view as suggested by @nkdengineer. I think we can hide the "Edit category" or update the button text to something like "Got it",... (maybe this will need to be confirmed in the PR phase)

Let's go with @nkdengineer's proposal

🎀 👀 🎀 C+ reviewed

melvin-bot · 2024-08-29T09:59:57Z

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2024-08-29T12:44:28Z

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-08-29T12:44:32Z

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

DylanDylann · 2024-08-30T17:44:07Z

@carlosmiceli I see the behavior on other pages is different. With the same step

On Tag page: we display not found page
On Report field page: we display nothing
On Category page (this issue): We are going to display empty view

Should we adjust all these pages to make it consistent

carlosmiceli · 2024-08-30T23:23:05Z

@DylanDylann that's a good point, we should (I think). Let me get back on this. I think for now we should proceed fixing the issue as originally proposed, and we'll create another issue for standardizing those pages if we want.

carlosmiceli · 2024-09-01T16:20:40Z

@DylanDylann I'm not being able to reproduce this for Tags for example, it continues to display the Tags until the user reloads the app. Could you show me a video of how you get to each empty screen for Tags and Reports? Thank you!

DylanDylann · 2024-09-04T09:54:27Z

@carlosmiceli Sorry for my delay. I test in the same admin account and using two chrome tab

Screen.Recording.2024-09-04.at.16.51.44.mov

cc @nkdengineer Could you help to verify the output when login in the 2 account as in the OP with Tag and report field

stephanieelliott · 2024-09-11T02:41:07Z

This PR should be merged with today's deploy 🎉

DylanDylann · 2024-09-24T04:20:49Z

@stephanieelliott Please help process payment, thanks

stephanieelliott · 2024-09-24T21:44:17Z

Oops, yes looks like the automation didn't work -- PR was deployed to prod with #48791 and should've been paid on 9/19. Setting up for payment now.

stephanieelliott · 2024-09-24T21:47:17Z

Summarizing payment on this issue:

Contributor: @nkdengineer $250 via Upwork -- PAID
Contributor+: @DylanDylann $250 via Upwork -- PAID

Upwork job is here: https://www.upwork.com/jobs/~01775966fb678bc1d8

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 27, 2024

melvin-bot bot assigned stephanieelliott Aug 27, 2024

stephanieelliott added the External Added to denote the issue can be worked on by a contributor label Aug 27, 2024

melvin-bot bot changed the title ~~Categories - Employee has the option to edit categories when all the categories are disabled~~ [$250] Categories - Employee has the option to edit categories when all the categories are disabled Aug 27, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 27, 2024

melvin-bot bot assigned DylanDylann Aug 27, 2024

stephanieelliott added this to [#whatsnext] #wave-collect Aug 27, 2024

trjExpensify moved this to Polish in [#whatsnext] #wave-collect Aug 28, 2024

melvin-bot bot assigned carlosmiceli Aug 29, 2024

carlosmiceli assigned nkdengineer Aug 29, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 29, 2024

nkdengineer mentioned this issue Aug 30, 2024

fix: Employee has the option to edit categories #48309

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review and removed Daily KSv2 labels Aug 30, 2024

melvin-bot bot added the Weekly KSv2 label Aug 30, 2024

stephanieelliott closed this as completed Sep 24, 2024

github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect Sep 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$250] Categories - Employee has the option to edit categories when all the categories are disabled #48097

[$250] Categories - Employee has the option to edit categories when all the categories are disabled #48097

lanitochka17 commented Aug 27, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Aug 27, 2024

lanitochka17 commented Aug 27, 2024

lanitochka17 commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

FitseTLT commented Aug 27, 2024 •

edited

Loading

nkdengineer commented Aug 27, 2024 •

edited by github-actions bot

Loading

Krishna2323 commented Aug 27, 2024 •

edited

Loading

nkdengineer commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

stephanieelliott commented Aug 27, 2024

DylanDylann commented Aug 29, 2024

melvin-bot bot commented Aug 29, 2024

melvin-bot bot commented Aug 29, 2024

melvin-bot bot commented Aug 29, 2024

DylanDylann commented Aug 30, 2024

carlosmiceli commented Aug 30, 2024

carlosmiceli commented Sep 1, 2024

DylanDylann commented Sep 4, 2024

stephanieelliott commented Sep 11, 2024

DylanDylann commented Sep 24, 2024 •

edited

Loading

stephanieelliott commented Sep 24, 2024 •

edited

Loading

stephanieelliott commented Sep 24, 2024

[$250] Categories - Employee has the option to edit categories when all the categories are disabled #48097

[$250] Categories - Employee has the option to edit categories when all the categories are disabled #48097

Comments

lanitochka17 commented Aug 27, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Aug 27, 2024

lanitochka17 commented Aug 27, 2024

lanitochka17 commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

FitseTLT commented Aug 27, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

nkdengineer commented Aug 27, 2024 • edited by github-actions bot Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Krishna2323 commented Aug 27, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

nkdengineer commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

melvin-bot bot commented Aug 27, 2024

stephanieelliott commented Aug 27, 2024

DylanDylann commented Aug 29, 2024

melvin-bot bot commented Aug 29, 2024

melvin-bot bot commented Aug 29, 2024

melvin-bot bot commented Aug 29, 2024

DylanDylann commented Aug 30, 2024

carlosmiceli commented Aug 30, 2024

carlosmiceli commented Sep 1, 2024

DylanDylann commented Sep 4, 2024

stephanieelliott commented Sep 11, 2024

DylanDylann commented Sep 24, 2024 • edited Loading

stephanieelliott commented Sep 24, 2024 • edited Loading

stephanieelliott commented Sep 24, 2024

lanitochka17 commented Aug 27, 2024 •

edited by melvin-bot bot

Loading

FitseTLT commented Aug 27, 2024 •

edited

Loading

nkdengineer commented Aug 27, 2024 •

edited by github-actions bot

Loading

Krishna2323 commented Aug 27, 2024 •

edited

Loading

What alternative solutions did you explore? (Optional)  

DylanDylann commented Sep 24, 2024 •

edited

Loading

stephanieelliott commented Sep 24, 2024 •

edited

Loading