[HOLD for Payment 2024-09-10] No clear button on the Filters page on web (non-mobile platforms.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.25-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724793973914559

Action Performed:

1. Go to search
2. Go to filters
3. Apply some filters

Expected Result:

There should be clear filter option

Actual Result:

No clear button

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No clear button

What is the root cause of that problem?

This is a feature request

What changes do you think we should make in order to solve the problem?

In AdvancedSearchFilters component, we need to implement clear button which would call SearchActions.clearAdvancedFilters on press:

{!isEmptyObject(searchAdvancedFilters) && (
    <Button
        large
        onPress={() => {
            SearchActions.clearAdvancedFilters();
        }}
        text={'Clear'}
    />
)}

Of course we'll need to apply appropriate style for it.

[JmillsExpensify]

Going to take over managing this one, as it's an internal project. @Kicu do you want to comment so that we can get you assigned for now?

[cdOut]

Hi, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency. I'm going to work on this issue to help @Kicu out with the search tasks.

[Kicu]

btw @m-natarajan @JmillsExpensify we are unsure why there is a "on web" mention in the name of this Issue.

To my knowledge we are missing the button to clear filters on every platform, as no specific button for this was created. Is that correct?

[rayane-djouah]

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-09-10] according to #48360 prod deploy checklist, confirmed in #48094 (comment).

cc @JmillsExpensify

[melvin-bot]

@JmillsExpensify, @luacmartins, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

Payment summary: $250 to @rayane-djouah for PR testing and approval.

[JmillsExpensify]

Offer sent.

[rayane-djouah]

@JmillsExpensify Offer accepted. Thanks!

[JmillsExpensify]

Awesome, offer paid via Upwork!