fix: The continue button has some extra bottom padding #48179

BhuvaneshPatil · 2024-08-28T14:04:33Z

Details

Continue button on the page where we add personal details while on-boarding has extra bottom padding

Fixed Issues

$ #47087
PROPOSAL: #47087 (comment)

Tests

Create a new account
In on boarding modal select, Manage my team's expenses
Check bottom padding for continue button. Both in online and offline mode
Fill details and go to next page
Check bottom padding bottom for continue button. Both in online and offline mode
Create a new account
Select track my expenses option
Check bottom padding for continue button. Both in online and offline mode

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-08-28T14:04:39Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-08-28T21:18:19Z

c.c. @shawnborton , can you check the screenshot from the contributor once, I see them just fine, want to get 🟢 from you

shawnborton · 2024-08-29T11:56:03Z

This feels like there is too much space above the offline indicator:

Can you check what's going on there?

The other screenshots seem good though.

allgandalf · 2024-08-29T18:21:23Z

@BhuvaneshPatil can you address the comments ^

…ntinue-btn-bottom-padding

BhuvaneshPatil · 2024-08-30T12:54:36Z

Looking into it

…ntinue-btn-bottom-padding

BhuvaneshPatil · 2024-09-01T03:29:18Z

The problem is on ios native. I am trying to build using npm run ios, but it's stuck in ⠼ Building the app... stage for long time

allgandalf · 2024-09-02T05:03:51Z

were you able to build @BhuvaneshPatil ?

allgandalf · 2024-09-04T06:02:32Z

any update here @BhuvaneshPatil ?

…ntinue-btn-bottom-padding

BhuvaneshPatil · 2024-09-06T12:14:34Z

we are applying safe area bottom padding to button

I am trying different ways how we can use that padding

BhuvaneshPatil · 2024-09-06T13:00:18Z

@allgandalf @shawnborton Does this look good -

offline -

View 1	View 2

online -

View 1	View 2

shawnborton · 2024-09-06T13:09:18Z

This one doesn't quite look right:

There should be the same gap between the button and offline indicator as there is in this screenshot:

Is that possible?

BhuvaneshPatil · 2024-09-06T13:21:28Z

Sure. Let me check if that can be done.
Thanks

BhuvaneshPatil · 2024-09-06T15:09:05Z

This is a solution I came up with, but it has slight delay

Screen.Recording.2024-09-06.at.8.38.09.PM.mov

shawnborton · 2024-09-06T15:10:17Z

Hmm the delay feels a bit odd, anything we can do about that?

…ntinue-btn-bottom-padding

allgandalf · 2024-09-09T06:04:29Z

@BhuvaneshPatil can you address ^ comments and also resolve conflicts, lets act quick here, this is pending for a long time now

BhuvaneshPatil · 2024-09-09T06:42:33Z

I checked on other pages as well on IOS.

Example Description page for Track Expense option we have that extra padding there as well. It is also due to safe are padding.

What do you think shall we continue having that padding here as well?

allgandalf · 2024-09-10T08:26:51Z

bump @shawnborton on the ^ question

shawnborton · 2024-09-10T09:22:34Z

That works for me if this already exists elsewhere.

…ntinue-btn-bottom-padding

allgandalf · 2024-09-11T08:53:05Z

@BhuvaneshPatil is this ready for final review ?

BhuvaneshPatil · 2024-09-11T08:56:59Z

Yes

allgandalf · 2024-09-11T10:06:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-30.at.2.26.31.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-09-30.at.2.29.58.PM.mov

iOS: Native

Screen.Recording.2024-09-30.at.2.13.46.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-09-30.at.2.13.46.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-30.at.2.03.35.PM.mov

MacOS: Desktop

Screen.Recording.2024-09-30.at.2.07.50.PM.mov

allgandalf · 2024-09-15T08:49:53Z

@BhuvaneshPatil why is there so much padding in offline mode?

BhuvaneshPatil · 2024-09-15T10:31:28Z

#48179 (comment)

I checked on other pages as well on IOS. Example Description page for Track Expense option we have that extra padding there as well. It is also due to safe are padding. What do you think shall we continue having that padding here as well?

We add padding bottom to button on IOS

…ntinue-btn-bottom-padding

allgandalf · 2024-09-19T04:46:10Z

@BhuvaneshPatil this has conflicts

BhuvaneshPatil · 2024-09-19T05:32:49Z

yes, resolving.

…ntinue-btn-bottom-padding

allgandalf · 2024-09-20T12:26:21Z

@BhuvaneshPatil is this ready for review again?

BhuvaneshPatil · 2024-09-20T12:32:49Z

Yes

allgandalf · 2024-09-23T06:50:57Z

src/pages/OnboardingWork/index.native.tsx

@@ -2,12 +2,12 @@ import React from 'react';
 import BaseOnboardingWork from './BaseOnboardingWork';
 import type {OnboardingWorkProps} from './types';

-function OnboardingWork({...rest}: Omit<OnboardingWorkProps, 'shouldUseNativeStyles'>) {


I don't understand why are these changes required ?

I was getting lint failure because of withOnyx so I migrated that. After that it started giving lint error for this line. So I solved it. Let me know if I should undo the changes for withOnyx hook

allgandalf · 2024-09-23T06:51:05Z

src/pages/OnboardingWork/index.tsx

@@ -5,15 +5,15 @@ import useThemeStyles from '@hooks/useThemeStyles';
 import BaseOnboardingWork from './BaseOnboardingWork';
 import type {OnboardingWorkProps} from './types';

-function OnboardingWork({...rest}: Omit<OnboardingWorkProps, 'shouldUseNativeStyles'>) {


allgandalf · 2024-09-23T06:51:15Z

src/pages/OnboardingWork/index.tsx

    const styles = useThemeStyles();
    return (
        <FocusTrapForScreens>
            <View style={styles.h100}>
                <BaseOnboardingWork
                    shouldUseNativeStyles={false}
                    // eslint-disable-next-line react/jsx-props-no-spreading
-                    {...rest}


allgandalf · 2024-09-24T08:18:39Z

I was getting lint failure because of withOnyx so I migrated that. After that it started giving lint error for this line. So I solved it. Let me know if I should undo the changes for withOnyx hook

oh is it then i guess its fine, but we need to make sure we have the latest videos attached, can you update videos on all platforms as this PR has changed a lot from the initial PR, we need to make sure there are no regressions here

BhuvaneshPatil · 2024-09-24T18:57:45Z

I have updated latest screenshots on all platforms

BhuvaneshPatil · 2024-09-27T17:33:04Z

@allgandalf ^^

allgandalf · 2024-09-27T18:23:53Z

sorry, I was super occupied in the co-pilot, workspace feed, and Onboarding refactor work this week, I will surely complete the checklist over the weekend. thanks for understanding @BhuvaneshPatil .

allgandalf

LGTM and tests well !

OSBotify · 2024-10-01T17:54:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-02T00:31:21Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.43-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-02T01:10:01Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.43-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-03T03:34:12Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.43-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: The continue button has some extra bottom padding

8c123cb

BhuvaneshPatil requested a review from a team as a code owner August 28, 2024 14:04

melvin-bot bot requested review from allgandalf and removed request for a team August 28, 2024 14:04

Merge branch 'main' of https://github.com/Expensify/App into 47087-co…

26751ba

…ntinue-btn-bottom-padding

Merge branch 'main' of https://github.com/Expensify/App into 47087-co…

1e8a8da

…ntinue-btn-bottom-padding

allgandalf mentioned this pull request Sep 6, 2024

[HOLD for payment 2024-10-10] [$125] The continue button has some extra bottom padding on the page we enter name after selecting the onboarding option. #47087

Closed

6 tasks

Merge branch 'main' of https://github.com/Expensify/App into 47087-co…

2daf189

…ntinue-btn-bottom-padding

Merge branch 'main' of https://github.com/Expensify/App into 47087-co…

06be7f6

…ntinue-btn-bottom-padding

BhuvaneshPatil added 3 commits September 10, 2024 17:23

Merge branch 'main' of https://github.com/Expensify/App into 47087-co…

37f67d8

…ntinue-btn-bottom-padding

resolve conflicts

a0d2b11

resolve type error

2bebc7d

Merge branch 'main' of https://github.com/Expensify/App into 47087-co…

78408b9

…ntinue-btn-bottom-padding

BhuvaneshPatil added 5 commits September 19, 2024 20:45

Merge branch 'main' of https://github.com/Expensify/App into 47087-co…

012a1f4

…ntinue-btn-bottom-padding

resolve conflicts

15e61bb

change withOnyx to useOnyx

93a7e2f

fix lint error cause of onyx

95bdd86

fix lint error

cd8d090

allgandalf reviewed Sep 23, 2024

View reviewed changes

BhuvaneshPatil requested a review from allgandalf September 25, 2024 15:04

allgandalf approved these changes Sep 30, 2024

View reviewed changes

melvin-bot bot requested a review from aldo-expensify September 30, 2024 09:01

aldo-expensify approved these changes Oct 1, 2024

View reviewed changes

aldo-expensify merged commit 61e1cdb into Expensify:main Oct 1, 2024
18 of 20 checks passed

github-actions bot mentioned this pull request Oct 2, 2024

Deploy Checklist: New Expensify 2024-10-02 #50030

Closed

56 tasks

fix: The continue button has some extra bottom padding #48179

fix: The continue button has some extra bottom padding #48179

Conversation

BhuvaneshPatil commented Aug 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 28, 2024

allgandalf commented Aug 28, 2024

shawnborton commented Aug 29, 2024

allgandalf commented Aug 29, 2024

BhuvaneshPatil commented Aug 30, 2024

BhuvaneshPatil commented Sep 1, 2024

allgandalf commented Sep 2, 2024

allgandalf commented Sep 4, 2024

BhuvaneshPatil commented Sep 6, 2024

BhuvaneshPatil commented Sep 6, 2024

shawnborton commented Sep 6, 2024

BhuvaneshPatil commented Sep 6, 2024

BhuvaneshPatil commented Sep 6, 2024

shawnborton commented Sep 6, 2024

allgandalf commented Sep 9, 2024

BhuvaneshPatil commented Sep 9, 2024

allgandalf commented Sep 10, 2024

shawnborton commented Sep 10, 2024

allgandalf commented Sep 11, 2024

BhuvaneshPatil commented Sep 11, 2024

allgandalf commented Sep 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf commented Sep 15, 2024

BhuvaneshPatil commented Sep 15, 2024

allgandalf commented Sep 19, 2024

BhuvaneshPatil commented Sep 19, 2024

allgandalf commented Sep 20, 2024

BhuvaneshPatil commented Sep 20, 2024

allgandalf Sep 23, 2024

Choose a reason for hiding this comment

BhuvaneshPatil Sep 23, 2024

Choose a reason for hiding this comment

allgandalf Sep 23, 2024

Choose a reason for hiding this comment

allgandalf Sep 23, 2024

Choose a reason for hiding this comment

allgandalf commented Sep 24, 2024

BhuvaneshPatil commented Sep 24, 2024

BhuvaneshPatil commented Sep 27, 2024

allgandalf commented Sep 27, 2024

allgandalf left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 1, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 3, 2024

BhuvaneshPatil commented Aug 28, 2024 •

edited

Loading

allgandalf commented Sep 11, 2024 •

edited

Loading