[$250] Accounting - Wrong integration name in modal message when there is existing connection

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace is connected to QBO

1. Go to staging.new.expensify.com
2. Go to workspace settings > Accounting
3. Click Other integrations
4. Click Connect button next to Xero

Expected Result:

The integration in the pop-up message should be correct
Connect
Are you sure you want to connect ? This will remove any existing acounting connections

Actual Result:

The integration in the pop-up message is wrong. It shows QBO when it is already connected to QBO
Connect
Are you sure you want to connect ? This will remove any existing acounting connections

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6585989_1724892428474.20240829_083943.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01183260f3b2c951d3
• Upwork Job ID: 1831032217491230963
• Last Price Increase: 2024-09-03
• Automatic offers:
• DylanDylann | Reviewer | 103814360
• Nodebrute | Contributor | 103814362

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong integration name in modal message when there is existing connection

What is the root cause of that problem?

We are passing wrong integration here

App/src/pages/workspace/accounting/AccountingContext.tsx

Line 122 in e77f204

integrationToConnect={activeIntegration?.integrationToDisconnect}

What changes do you think we should make in order to solve the problem?

Pass activeIntegration?.name

App/src/pages/workspace/accounting/AccountingContext.tsx

Line 122 in e77f204

integrationToConnect={activeIntegration?.integrationToDisconnect}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01183260f3b2c951d3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[melvin-bot]

@muttmuure Huh... This is 4 days overdue. Who can take care of this?

[DylanDylann]

@Nodebrute's proposal looks good to me

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Nodebrute]

@muttmuure Hey, it was deployed to production on September 9, tThe payment is now two days overdue.

[muttmuure]

Paid