[HOLD for payment 2024-09-09] [$250] Android & iOS Expense - Main chat becomes blank after returning from transaction thread

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.27-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to workspace chat.
3. Submit two expenses.
4. Tap on the expense preview to go to expense report.
5. Tap on the expense preview again to go to transaction thread.
6. Tap back button twice to return to main chat.

Expected Result:

The main chat will not be blank after returning from transaction thread.

Actual Result:

The main chat becomes blank after returning from transaction thread.
The same issue also happens for 1:1 DM expense and when leaving thread.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6588134_1725047314877.ScreenRecording_08-31-2024_03-46-23_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0173629ca2a87d3e9d
• Upwork Job ID: 1829627147990471781
• Last Price Increase: 2024-08-30
• Automatic offers:
• ishpaul777 | Contributor | 103785367

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0173629ca2a87d3e9d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[luacmartins]

I'm having issue building the iOS app at the moment. Adding external label to get contributors help

[struc]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace chat content is hidden after navigating away two or more levels deep then going back to the chat page, like viewing expenses report and clicking one of the expenses.
It also happens when adding a banking account, then immediately going back to the chat page.

What is the root cause of that problem?

The chat view has fade-in animation, and is initially hidden because of

App/src/pages/home/report/ReportActionsList.tsx

Line 167 in fc849dd

const opacity = useSharedValue(0);

However the animation will not run the second time since it does not have isFocused as a dependency.

App/src/pages/home/report/ReportActionsList.tsx

Lines 303 to 310 in fc849dd

	const animatedStyles = useAnimatedStyle(() => ({
	opacity: opacity.value,
	}));
	useEffect(() => {
	// eslint-disable-next-line react-compiler/react-compiler
	opacity.value = withTiming(1, {duration: 100});
	}, [opacity]);

What changes do you think we should make in order to solve the problem?

Add isFocused as a dependency to force a re-render when the page is focused again, and reset the opacity to 0 before running the animation.

    useEffect(() => {
      opacity.value = 0;
      // eslint-disable-next-line react-compiler/react-compiler
      opacity.value = withTiming(1, {duration: 100});
    }, [opacity, isFocused]);

What alternative solutions did you explore? (Optional)

Remove the animation, I think 100ms is hardly noticeable to the user.

App/src/pages/home/report/ReportActionsList.tsx

Lines 303 to 305 in fc849dd

	const animatedStyles = useAnimatedStyle(() => ({
	opacity: opacity.value,
	}));

ios.mp4

[luacmartins]

@hungvu193 could you please take a look at the proposal above?

[hungvu193]

@hungvu193 could you please take a look at the proposal above?

I'm still trying to run native code, I tried to clean everything, upgrade xcode, mac version, but still no luck :(. If this is urgent please re-assign.

[struc]

@hungvu193 if it helps this is my current setup
It worked out of the box, though I did not have much luck with Xcode 14 and/or MacOS older than 14.

[hungvu193]

@hungvu193 if it helps this is my current setup It worked out of the box, though I did not have much luck with Xcode 14 and/or MacOS older than 14.

Thanks. I'll give that a try.

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @struc You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[roryabraham]

@struc this is a pretty urgent issue because it's the last one we need to fix before I can deploy. Let's try to get a PR up ASAP

[struc]

@roryabraham Please give 5 minutes or so, I am creating the PR now.

[roryabraham]

Verified that this is fixed on staging ✅

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: iOS chat view to be hidden if the user clicks away/navigate to two screens or more. #48428

If no regressions arise, payment will be issued on 2024-09-09. 🎊

For reference, here are some details about the assignees on this issue:

• @struc requires payment (Needs manual offer from BZ)
• @ishpaul777 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ishpaul777]

not a deployblocker anymore, i guess fix was deployed yesterday

[OfstadC]

@ishpaul777 Could you please complete the BZ checklist? Thank you!

[ishpaul777]

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: [NoQA] feat: bump reanimated to newest version and remove unnecessary patches #48318
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [NoQA] feat: bump reanimated to newest version and remove unnecessary patches #48318 (comment)
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
• [@ishpaul777] Determine if we should create a regression test for this bug.- No, this was caught in normal QA process we already have common test cases to cover this.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[OfstadC]

https://www.upwork.com/ab/applicants/1833130608126333165/job-details

@struc Could you you please link me your Upwork profile as I wasn't able to find it? Thank you!

[struc]

@OfstadC Here is the link https://www.upwork.com/freelancers/~01b7e0705471825edf

[OfstadC]

Thanks @struc! Could you accept this offer ? Then I can issue payment😃

[OfstadC]

Payment Summary

• @struc paid $250 via Upwork
• @ishpaul777 paid $250 via Upwork