[HOLD for Payment 2024-09-17][CVP] [$125] Remove the conciergePlaceholderOptions from the Concierge DM

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C07HPDRELLD/p1725028722645499 (Internal)

Action Performed:

1. Go to the Concierge DM
2. Observe the placeholder text in the composer

Actual Result:

Today we use this set of placeholder text options in the Concierge DM. That said, it creates a confusing situation where a user's intent doesn't match the prompt:

Expected Result:

This is working as expected, but we want to remove conciergePlaceholderOptions and use the standard writeSomething placeholder text found in other chats instead.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

See above in-line.

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[melvin-bot]

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-02 14:50:00 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove the conciergePlaceholderOptions from the Concierge DM

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

We can remove this line

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Line 230 in e60b821

return translate('reportActionCompose.conciergePlaceholderOptions')[conciergePlaceholderRandomIndex];

We might need to do some cleanup (removing conciergePlaceholderOptions from en.ts and es.ts files) we can also remove

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Lines 216 to 221 in e60b821

	// If we are on a small width device then don't show last 3 items from conciergePlaceholderOptions
	const conciergePlaceholderRandomIndex = useMemo(
	() => Math.floor(Math.random() * (translate('reportActionCompose.conciergePlaceholderOptions').length - (shouldUseNarrowLayout ? 4 : 1) + 1)),
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
	[],
	);

What alternative solutions did you explore? (Optional)

If we decide not to display the 'concierge blocked' message in Composer, we can remove this entire code block.

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Lines 225 to 231 in e60b821

	if (includesConcierge) {
	if (userBlockedFromConcierge) {
	return translate('reportActionCompose.blockedFromConcierge');
	}
	return translate('reportActionCompose.conciergePlaceholderOptions')[conciergePlaceholderRandomIndex];
	}

[shubham1206agra]

@trjExpensify I can remove this functionality in #45892 if you want since I was changing the conciergePlaceholderOptions anyway.

[trjExpensify]

Hm, seems like that PR is more far reaching. Might be worth still keeping it separate, just in case we have to roll that one back. CC: @iwiznia in case you disagree.

[rayane-djouah]

@Nodebrute's proposal looks good to me.

---

If we decide not to display the 'concierge blocked' message in Composer, we can remove this entire code block.

I believe we need to keep the 'Communication is barred' message for when the user is blocked from Concierge.

---

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rayane-djouah]

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-09-17] according to #48791 production deploy checklist, confirmed in #48791 (comment)

[rayane-djouah]

@sonialiap - This is due payment

[sonialiap]

Agreed, due for payment. Thanks Rayane!

Payment summary:

• @rayane-djouah $125 - offer sent in upwork
• @Nodebrute $125 - offer sent in upwork

[rayane-djouah]

@sonialiap Offer accepted thanks

[sonialiap]

Both payments completed ✔️