[HOLD for payment 2024-10-24] [$250] Forward delete moves cursor location after deleting a character

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.31-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tgolen
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1725900088874679

Action Performed:

1. Initiate a DM with any user
2. Compose a message
3. Place the cursor in the middle of the composed message
4. Press the Delete button on the keyboard

Expected Result:

Pressing the delete key should delete characters after the cursor, then the cursor should remain in its current opsition.

Actual Result:

Pressing the delete key is deleting characters before the cursor After deleting the character after the cursor (expected), the cursor advances one character to the left (unexpected).

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.528.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834326245043110651
• Upwork Job ID: 1834326245043110651
• Last Price Increase: 2024-09-12
• Automatic offers:
• ishpaul777 | Reviewer | 103988646
• QichenZhu | Contributor | 103988649

Issue Owner

Current Issue Owner: @mallenexpensify / @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (AutoAssignerNewDotQuality)

[BreakTos]

Can this issue be assigned to me ? Looks like something i can contribute to

[melvin-bot]

📣 @BreakTos! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[BreakTos]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0158b590a3a6ca253f

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Shahidullah-Muffakir]

In the video shared, the Delete key is erasing characters to the right of the cursor, which I also tested and found to be true. I believe this is the expected behavior.
As the Backspace key is meant to delete characters to the left of the cursor, while the Delete key should erase characters to the right. Given this, it seems like the Delete key is working as it should.

[tylerkaraszewski]

The video is recorded on Windows, not MacOS.

[muttmuure]

I'm not sure we've established that this is unexpected behavior here

[rafecolton]

The bug description is incorrect. It is not deleting the character before the cursor, which would be unexpected for forward delete. It is deleting the character after (expected), but then advancing the cursor one position to the left (unexpected). The expected behavior is that the cursor remains where it is after the character to the right is deleted. Reported here for macOS too.

[rafecolton]

Happy to take over this issue @youssef-lr, I will be joining the NewDot Quality and ECM chores very soon.

[melvin-bot]

@tgolen, @youssef-lr, @jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rafecolton]

Sounds good, thanks Matt

[melvin-bot]

@rafecolton, @jliexpensify, @QichenZhu, @ishpaul777 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[rafecolton]

Not overdue. PR was recently merged, waiting for this change to be deployed.

[jliexpensify]

Hi @rafecolton - just a heads up I'm OOO from 3rd to 14th, so I will prep a Payment Summary. If needed, feel free to reassign to another BZ for payment.

• C: @QichenZhu owed $250 via Upwork
• C+: @ishpaul777 owed $250 via Upwork

Upwork job

[mallenexpensify]

@jliexpensify you can assign to me for payment, if needed.

When you post payment summaries, can you use the below format? For auditing purposes we need to know where someone is being paid (Upwork vs NewDot) and also if they're due/owed funds are 'paid'. Thx

[jliexpensify]

Will do in the future, thanks @mallenexpensify!

[ishpaul777]

unfortunately, E/react-native-live-markdown version bump was reverted because of unrelated changes to our issue, we have new PR #50047 for second try 🤞

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add inline images preview to the Live Markdown Input on the web #50047

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

• @QichenZhu requires payment automatic offer (Contributor)
• @ishpaul777 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify / @jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

whoohooo... it's fixed!! Thx

[jliexpensify]

Hi @ishpaul777 - do we need a checklist here?

[ishpaul777]

i could not find PR that introduce this bug, But i think we need regression tests for this.

Regression Test Proposal:

1. Initiate a DM with any user
2. Compose a message
3. Place the cursor in the middle of the composed message
4. Press the fn key and press Delete button on the keyboard
5. Verify Expected Result: Pressing the delete key should delete characters after the cursor, then the cursor should remain in its current opsition.

Do we agree 👍 or 👎

[rafecolton]

Sounds great, thank you! Definitely agree we need one - while we were waiting for the fix to get merged, the issue actually got worse somehow

[jliexpensify]

Payment Summary

• C: @QichenZhu owed $250 via Upwork
• C+: @ishpaul777 owed $250 via Upwork

New Upworks Job - the other one closed automatically so please accept my offers here, thanks!

[jliexpensify]

Paid and job closed!

[melvin-bot]

@rafecolton @mallenexpensify @jliexpensify Be sure to fill out the Contact List!