Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-09-18] [$250] Android & iOS - App crashes when viewing member profile when Expensify Card feature is enabled #48866

Closed
2 of 6 tasks
IuliiaHerets opened this issue Sep 10, 2024 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Sep 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.31-8
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch New Expensify app.
  2. Go to workspace settings > More features.
  3. Enable Expensify Card.
  4. Go to Members.
  5. Click on any member profile.

Expected Result:

App will not crash.

Actual Result:

App crashes when viewing member profile when Expensify Card feature is enabled.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1009_1.txt

Bug6598254_1725939704887.w_fff3b451b61587a883196c2b7587e7b3e2270f47-2024-09-10_03_41_18.517.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021833619091468337774
  • Upwork Job ID: 1833619091468337774
  • Last Price Increase: 2024-09-10
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @slafortune
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 10, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Sep 10, 2024

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 10, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@VickyStash
Copy link
Contributor

The PR is ready for the review.

Copy link

melvin-bot bot commented Sep 10, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins luacmartins self-assigned this Sep 10, 2024
@luacmartins
Copy link
Contributor

Fixed on staging.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Sep 10, 2024
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Sep 10, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021833619091468337774

@melvin-bot melvin-bot bot changed the title Android & iOS - App crashes when viewing member profile when Expensify Card feature is enabled [$250] Android & iOS - App crashes when viewing member profile when Expensify Card feature is enabled Sep 10, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 10, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

Current assignee @getusha is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 10, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 10, 2024
@mountiny mountiny added Weekly KSv2 and removed Reviewing Has a PR in review Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 10, 2024
@mountiny
Copy link
Contributor

@slafortune once the time comes, we will have to pay $250 to @getusha

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Sep 11, 2024
@melvin-bot melvin-bot bot changed the title [$250] Android & iOS - App crashes when viewing member profile when Expensify Card feature is enabled [HOLD for payment 2024-09-18] [$250] Android & iOS - App crashes when viewing member profile when Expensify Card feature is enabled Sep 11, 2024
Copy link

melvin-bot bot commented Sep 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.31-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-09-18. 🎊

For reference, here are some details about the assignees on this issue:

  • @VickyStash does not require payment (Contractor)
  • @getusha requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Sep 11, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@getusha] The PR that introduced the bug has been identified. Link to the PR:
  • [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@getusha] Determine if we should create a regression test for this bug.
  • [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@slafortune
Copy link
Contributor

@getusha can you please complete the checklist?

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 18, 2024
Copy link

melvin-bot bot commented Sep 18, 2024

Payment Summary

Upwork Job

  • Contributor: @VickyStash is from an agency-contributor and not due payment
  • Reviewer: @getusha owed $250 via NewDot

BugZero Checklist (@slafortune)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1833619091468337774/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@slafortune
Copy link
Contributor

@getusha bump

@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2024
Copy link

melvin-bot bot commented Sep 23, 2024

@madmax330, @slafortune, @luacmartins, @VickyStash, @mountiny, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny
Copy link
Contributor

@slafortune This is a new feature that was behind beta, I think we can skip the checklist now as the reasons for the crash been discussed and also the test cases will be added altogether for this project in a bit so no need to add a special one here

@slafortune
Copy link
Contributor

Contributor: @VickyStash is from an agency-contributor and not due payment
Reviewer: @getusha owed $250 via NewDot

@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2024
@garrettmknight
Copy link
Contributor

$250 approved for @getusha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

8 participants