Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] QA - Add Travel test to TestRail #48921

Closed
4 tasks done
kevinksullivan opened this issue Sep 10, 2024 · 19 comments
Closed
4 tasks done

[CRITICAL] QA - Add Travel test to TestRail #48921

kevinksullivan opened this issue Sep 10, 2024 · 19 comments
Assignees
Labels

Comments

@kevinksullivan
Copy link
Contributor

kevinksullivan commented Sep 10, 2024

Problem

We have a sandbox environment we can point accounts to in order to test travel booking (SO), but we've had issues getting all of the data from these transactions. That is a pretty broad statement though, and if we don't use the sandbox environment we pay a $15 fee every test booking we make in production.

Solution

  • Figure out what exactly is going wrong with sandbox and what data we are missing. Is this a Spotnana issue or is it on us?
  • Depending on the above, let's fix the issue ourselves or come up with clear asks for spotnana
  • Add a test script to testrail for applause, so we're QAing travel booking consistently and confirming it is working well end to end.
  • Create a SO for internal testing of travel

Tests:

In OldDot Expensify: Provisioning a company, account, and company

  1. Create a new account
  2. Create a control workspace
  3. Open the console: Command + option + j
  4. Paste NVP.set('travelSettings', {'testAccount': true});
  5. Go to Settings -> Account
  6. Set a first and last name
  7. Go to Travel in the LHN
  8. Click the button
  9. Check the checkbox
  10. Enter an address
  11. Click confirm and wait
  12. Ensure you are brought to Spotnana

Inside of Spotnana:

  1. Search for a new flight
  2. One way from SEA to SFO
  3. Alaska airlines
  4. At least 1 month in the future
  5. Select the flight
  6. Make sure that your name was properly imported from Expensify in the "Traveler Details"
  7. Add the other required information and click save at the top of the panel
  8. Click "next" on the right side
  9. Click "select a trip" and create a new trip
  10. Add the stripe test card ending in 4444
  11. Book the trip
  12. Wait until you receive an email confirming your trip
  13. Back inside of Expensify:

Check in the Expenses tab and make sure there are 2 expenses

  1. One for $15
  2. One for the price of your flight
  3. Ensure there is a receipt attached to both expenses

Testing changing your default workspace:

  1. Create a new account on the beta
  2. Create a control workspace1
  3. Enable the workspace for travel and make sure you are logged into Spotnana
  4. Create a second control workspace2 (a different name is required)
  5. Enable the workspace for travel and make sure you are logged into Spotnana
  6. Switch your default workspace to workspace1
  7. Click the travel button and make sure you are logged into Spotnana
@kevinksullivan kevinksullivan added the Daily KSv2 label Sep 10, 2024
@kevinksullivan kevinksullivan moved this from Low - Everything else to Critical - SuiteWorld September 9 in [#whatsnext] #travel 2025-02-01 - External Commit Sep 10, 2024
@kevinksullivan kevinksullivan changed the title Get sandbox transactions working so we can get QA testing travel daily [CRITICAL] Get sandbox transactions working so we can get QA testing travel daily Sep 10, 2024
@stitesExpensify
Copy link
Contributor

Added some logs today to see if my hunch is correct. Based on these logs it looks like we were sent the event, but when trying to get the user's info we got user_not_found. This to me indicates that we are trying to find the user on the production spotnana server instead of the sandbox

@stitesExpensify
Copy link
Contributor

I ended up finding the problem before the logs were deployed! I CP'd it and we are not getting fares via the sandbox again. We are still not getting fees for some reason. My guess is because the amount is $0 on the sandbox?

@stitesExpensify
Copy link
Contributor

Posted here to find out why we aren't getting fees https://expensify.slack.com/archives/C066REXJ9D3/p1726171051522029

@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
Copy link

melvin-bot bot commented Sep 16, 2024

@kevinksullivan, @stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@stitesExpensify
Copy link
Contributor

Waiting for Spotnana to respond here https://expensify.slack.com/archives/C066REXJ9D3/p1726171051522029

@melvin-bot melvin-bot bot removed the Overdue label Sep 16, 2024
@stitesExpensify
Copy link
Contributor

Waiting on a response, will bring it up in our meeting today

@stitesExpensify
Copy link
Contributor

We're good! We can start testing the non-credit card case in staging now!

@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2024
Copy link

melvin-bot bot commented Sep 23, 2024

@kevinksullivan, @stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

@stitesExpensify
Copy link
Contributor

Writing a SO / testrail tomorrow morning

@stitesExpensify
Copy link
Contributor

stitesExpensify commented Sep 27, 2024

In OldDot Expensify: Provisioning a company, account, and company

  1. Create a new account
  2. Create a control workspace
  3. Open the console: Command + option + j
  4. Paste NVP.set('travelSettings', {'testAccount': true});
  5. Go to Settings -> Account
  6. Set a first and last name
  7. Go to Travel in the LHN
  8. Click the button
  9. Check the checkbox
  10. Enter an address
  11. Click confirm and wait
  12. Ensure you are brought to Spotnana

Inside of Spotnana:

  1. Search for a new flight
    • One way from SEA to SFO
    • Alaska airlines
    • At least 1 month in the future
  2. Select the flight
  3. Make sure that your name was properly imported from Expensify in the "Traveler Details"
  4. Add the other required information and click save at the top of the panel
  5. Click "next" on the right side
  6. Click "select a trip" and create a new trip
  7. Add the stripe test card ending in 4444
  8. Book the trip
  9. Wait until you receive an email confirming your trip

Back inside of Expensify:

  1. Check in the Expenses tab and make sure there are 2 expenses
    • One for $15
    • One for the price of your flight
    • Ensure there is a receipt attached to both expenses

@melvin-bot melvin-bot bot added the Overdue label Sep 30, 2024
Copy link

melvin-bot bot commented Oct 1, 2024

@stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@stitesExpensify
Copy link
Contributor

Another test case:

Testing changing your default workspace:

  1. Create a new account on the beta
  2. Create a control workspace1
  3. Enable the workspace for travel and make sure you are logged into Spotnana
  4. Create a second control workspace2
  5. Enable the workspace for travel and make sure you are logged into Spotnana
  6. Switch your default workspace to workspace1
  7. Click the travel button and make sure you are logged into Spotnana

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2024
@stitesExpensify
Copy link
Contributor

@stitesExpensify stitesExpensify changed the title [CRITICAL] Get sandbox transactions working so we can get QA testing travel daily [CRITICAL] QA - Add Travel test to TestRail Oct 4, 2024
@stitesExpensify stitesExpensify added the Weekly KSv2 label Oct 4, 2024
@stitesExpensify stitesExpensify removed the Daily KSv2 label Oct 4, 2024
@stitesExpensify
Copy link
Contributor

@kavimuru @isagoico can we get these added to testrail please? :)

@isagoico isagoico self-assigned this Oct 5, 2024
@isagoico
Copy link

isagoico commented Oct 7, 2024

Will get these added this week (will aim for tomorrow so it's tested in the next regression run.

@stitesExpensify
Copy link
Contributor

Awesome, thanks!

@isagoico
Copy link

isagoico commented Oct 9, 2024

@stitesExpensify The following Test Cases have been created in the OldDot regression suite:

All travel test cases for OD can be found on this folder.
image

Will leave this issue open for a review of the TCs to have a 👍 that everything is good.

@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2024
@stitesExpensify
Copy link
Contributor

LGTM!

@github-project-automation github-project-automation bot moved this from Critical - Intuit Connect (Oct 28) to Done in [#whatsnext] #travel 2025-02-01 - External Commit Oct 18, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

@stitesExpensify Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants