[HOLD for payment 2024-10-25] [$250] Android & iOS - Spend category - Unable to select category when keyboard is up

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.31-12
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to workspace chat.
3. Start a manual expense flow.
4. On confirmation page, tap Category.
5. With keyboard up, tap on any category.
6. Note that the category can be selected when keyboard is up.
7. Go to workspace settings > Categories.
8. Click Settings.
9. Click on any spend.
10. With keyboard up, tap on any category.

Expected Result:

User should be able to select any category when keyboard is up (also this is mweb behavior).

Actual Result:

The keyboard is dismissed and the category is not selected when keyboard is up.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6598321_1725945441300.ScreenRecording_09-10-2024_13-09-39_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836880412171065631
• Upwork Job ID: 1836880412171065631
• Last Price Increase: 2024-10-08
• Automatic offers:
• rayane-djouah | Reviewer | 104357393
• dominictb | Contributor | 104357395

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[dominictb]

Edited by proposal-police: This proposal was edited at 2024-09-11 06:25:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The keyboard is dismissed and the category is not selected when keyboard is up.

What is the root cause of that problem?

• An issue has been reported here, which highlights that using a ScrollView inside another ScrollView breaks the keyboardShouldPersistTaps="always" functionality.

• In our app, specifically in the PolicyDistanceRatesSettingsPage, we have a similar setup. The ScrollView used in CategoryPicker:
  

  App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

  Line 124 in 46f3d2c

  <CategorySelector

  
  is nested inside another ScrollView:
  

  App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

  Line 100 in 46f3d2c

  <ScrollView contentContainerStyle={styles.flexGrow1}>

• This is also how we can find a similar bug in our app.

What changes do you think we should make in order to solve the problem?

• We can update:
  

  App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

  Line 100 in 46f3d2c

  <ScrollView contentContainerStyle={styles.flexGrow1}>

  
  to:

                            <ScrollView contentContainerStyle={styles.flexGrow1} keyboardShouldPersistTaps="always">

What alternative solutions did you explore? (Optional)

[mallenexpensify]

OOO til Tues, will revisit/review once back. If anyone thinks this can't wait til then, post in #expensify-open-source to get 👀 and another BZ assigned.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mallenexpensify]

Not reproducible on iOS, Safari, production.

@dominictb , if you're able to repro, can you please provide details? Thx

RPReplay_Final1726599745.MP4

[dominictb]

@mallenexpensify I can reproduce it in latest main on IOS Native:

1. Go to workspace settings > Categories.
2. Click Settings.
3. Click on any spend.
4. With keyboard up, tap on any category.
5. The keyboard is dismissed and the category is not selected when keyboard is up.

Screen.Recording.2024-09-18.at.02.16.24.mov

[mallenexpensify]

What version are you on @dominictb ? I was unable to repro on staging, v9.0.36-1

RPReplay_Final1726609619.MP4

[dominictb]

What version are you on @dominictb ? I was unable to repro on staging, v9.0.36-1

I can't reproduce this issue on staging/production because my account doesn't have access to that feature. I need to use the dev version to mock and access all the beta features.

[dominictb]

@mallenexpensify Please note, the "step 4. With keyboard up, tap on any category." in my reproduce steps is very important.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021836880412171065631

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[mallenexpensify]

I'm guessing this can likely be External then. @rayane-djouah , can you attempt reproduction? Thx

[rayane-djouah]

Will review this in my morning 👍

[rayane-djouah]

@mallenexpensify I can't reproduce this. The bug has been fixed in #49030

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: tap gesture does not work when keyboard is visible in distance rates settings page #50632

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment automatic offer (Reviewer)
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah / @dominictb] The PR that introduced the bug has been identified. Link to the PR:
• [@rayane-djouah / @dominictb] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rayane-djouah / @dominictb] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rayane-djouah / @dominictb] Determine if we should create a regression test for this bug.
• [@rayane-djouah / @dominictb] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[rayane-djouah]

BugZero Checklist

• The PR that introduced the bug has been identified. Link to the PR: Feature: Add the ability to configure tax rates on distance rates #42141
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42141/files#r1807437848
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

- Test on mobile devices only:
1. Create a workspace
2. Go to "Settings" > "Workspaces" > Select a workspace > "More Features" > Enable "Distance Rates".
3. Open the "Distance Rates" page.
4. Tap the "Settings" button.
5. Tap the "Default Category" menu item.
6. With the keyboard open, tap on any category.
7. Verify that the category is selected, rather than just dismissing the keyboard.

Do we agree 👍 or 👎

[melvin-bot]

@robertjchen, @mallenexpensify, @rayane-djouah, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[mallenexpensify]

Contributor: @dominictb paid $250 via Upwork
Contributor+: @rayane-djouah paid $250 via Upwork

Test case

• https://github.com/Expensify/Expensify/issues/440172

Thanks!

[melvin-bot]

@robertjchen @mallenexpensify Be sure to fill out the Contact List!