-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for Payment 2024-08-20] [$75] Room-"Set the custom decription for the room" is shown with incorrect description spelling. #49001
Comments
Triggered auto assignment to @jliexpensify ( |
ProposalPlease re-state the problem that we are trying to solve in this issue."Set the custom decription for the room" is shown with incorrect description spelling What is the root cause of that problem?There is type error here Line 1515 in e9642dc
What changes do you think we should make in order to solve the problem?Update the copy to explainerText: 'Set a custom description for the room.', Note: we have to check spanish translation too What alternative solutions did you explore? (Optional) |
Sorry, this one will be an internal fix! |
Reviewed the PR #49033 |
Heya @rayane-djouah thanks for reviewing! This seems like it was a real quick and easy review, correct? We'd like to pay $75 for this one. |
|
Works for me! |
Please assign me to this issue |
Note The production deploy automation failed: This should be on [HOLD for Payment 2024-08-20] according to #49139 prod deploy checklist, confirmed in #49033 (comment). |
Assigned and updated. No checklist right @rayane-djouah? |
Job added to Upwork: https://www.upwork.com/jobs/~021838055645417295211 |
Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new. |
Sorry, hired you here @rayane-djouah |
@jliexpensify - Accepted, thanks! |
Paid and job closed! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
"Set the custom description for the room" must be shown with correct spelling.
Actual Result:
"Set the custom decription for the room" is shown with incorrect description spelling.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @The text was updated successfully, but these errors were encountered: