Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for Payment 2024-08-20] [$75] Room-"Set the custom decription for the room" is shown with incorrect description spelling. #49001

Closed
4 of 6 tasks
izarutskaya opened this issue Sep 11, 2024 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@izarutskaya
Copy link

izarutskaya commented Sep 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Launch app
  2. Tap on a room chat
  3. Tap header -- room description
  4. Note the title

Expected Result:

"Set the custom description for the room" must be shown with correct spelling.

Actual Result:

"Set the custom decription for the room" is shown with incorrect description spelling.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6599806_1726054424498!screenshot_2024-09-11-14-10-56-413_com expensify chat-edit

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021838055645417295211
  • Upwork Job ID: 1838055645417295211
  • Last Price Increase: 2024-09-23
Issue OwnerCurrent Issue Owner: @
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 11, 2024
Copy link

melvin-bot bot commented Sep 11, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@etCoderDysto
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Set the custom decription for the room" is shown with incorrect description spelling

What is the root cause of that problem?

There is type error here

explainerText: 'Set a custom decription for the room.',

What changes do you think we should make in order to solve the problem?

Update the copy to Set a custom description for the room.

 explainerText: 'Set a custom description for the room.',

Note: we have to check spanish translation too

What alternative solutions did you explore? (Optional)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 12, 2024
@dubielzyk-expensify dubielzyk-expensify self-assigned this Sep 12, 2024
@jliexpensify jliexpensify added the Internal Requires API changes or must be handled by Expensify staff label Sep 12, 2024
@jliexpensify
Copy link
Contributor

Sorry, this one will be an internal fix!

@rayane-djouah
Copy link
Contributor

Reviewed the PR #49033

@jliexpensify
Copy link
Contributor

Heya @rayane-djouah thanks for reviewing! This seems like it was a real quick and easy review, correct? We'd like to pay $75 for this one.

@jliexpensify jliexpensify changed the title Room-"Set the custom decription for the room" is shown with incorrect description spelling. [$75] Room-"Set the custom decription for the room" is shown with incorrect description spelling. Sep 12, 2024
Copy link

melvin-bot bot commented Sep 12, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@rayane-djouah
Copy link
Contributor

Works for me!

@rayane-djouah
Copy link
Contributor

Please assign me to this issue

@rayane-djouah
Copy link
Contributor

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-08-20] according to #49139 prod deploy checklist, confirmed in #49033 (comment).

@jliexpensify jliexpensify changed the title [$75] Room-"Set the custom decription for the room" is shown with incorrect description spelling. [HOLD for Payment 2024-08-20] [$75] Room-"Set the custom decription for the room" is shown with incorrect description spelling. Sep 17, 2024
@jliexpensify
Copy link
Contributor

Assigned and updated. No checklist right @rayane-djouah?

@jliexpensify jliexpensify added the External Added to denote the issue can be worked on by a contributor label Sep 23, 2024
Copy link

melvin-bot bot commented Sep 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021838055645417295211

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 23, 2024
Copy link

melvin-bot bot commented Sep 23, 2024

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 23, 2024
@jliexpensify
Copy link
Contributor

Sorry, hired you here @rayane-djouah

@rayane-djouah
Copy link
Contributor

@jliexpensify - Accepted, thanks!

@jliexpensify
Copy link
Contributor

Paid and job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants