[HOLD for payment 2024-12-30] [HOLD] [Dev] Console Warning: TRenderEngineProvider: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @c3024
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726072125690969

Action Performed:

1. Visit the login page on Android App

Expected Result:

No console warning

Actual Result:

Console Warning

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console Warning: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

What is the root cause of that problem?

This problem happens after RN 0.74 when you use the old component's defaultProps:

What changes do you think we should make in order to solve the problem?

I see in the latest code base, they attempted removing defaultProps in this PR meliorence/react-native-render-html#658 but it has not been released yet.

In the meantime, we can apply a patch as suggested in this thread to solve the issue, not only in TRenderEngineProvider but also in other components.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[melvin-bot]

@muttmuure Eep! 4 days overdue now. Issues have feelings too...

[paultsimura]

The proposal by @mkzie2 looks OK, but it means adding a new patch, which we aim to avoid if possible.

Seems like the react-native-render-html is looking for new maintainers, so we have 2 options here:

1. Use the suggested patch
2. Make the upstream fix and wait for it to be merged after a new maintainer is assigned
3. Wait for the upstream fix to be done without our participation

I'll let the assigned Engineer decide.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@paultsimura, @lakchote, @muttmuure Huh... This is 4 days overdue. Who can take care of this?

[paultsimura]

@lakchote bump on #49035 (comment), please

[blazejkustra]

@lakchote @paultsimura They found a new maintainer, potentially we can wait for it to be fixed upstream

[lakchote]

@lakchote @paultsimura They found a new maintainer, potentially we can wait for it to be fixed upstream

Alright, let's wait for it to be fixed directly from the upstream.

[muttmuure]

Not overdue

[melvin-bot]

@paultsimura @lakchote @muttmuure this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[paultsimura]

Not overdue. Holding for meliorence/react-native-render-html#661

[muttmuure]

Is this done?

[paultsimura]

No, we're holding for an upstream fix. However, it had no movement in a month already. Maybe we should go back to considering a patch?

[lakchote]

No, we're holding for an upstream fix. However, it had no movement in a month already. Maybe we should go back to considering a patch?

Yes, there are no movements whatsoever. Let's go the patch route. I'm reopening #52917

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[paultsimura]

@lakchote could you please share the issues you mentioned here?
I have no access to those Slack threads, and we should count for them while doing the second attempt here.

[JKobrynski]

Update: I started investigating the issue that caused the revert today.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Console error cleanup: patch react-native-render-html  #52917

If no regressions arise, payment will be issued on 2024-12-30. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment (Needs manual offer from BZ)
• @c3024 requires payment through NewDot Manual Requests

[melvin-bot]

@paultsimura @muttmuure @paultsimura The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @paultsimura paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@muttmuure)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[paultsimura]

No payment here yet – the original PR was reverted.

[JKobrynski]

Update:

I spend a lot of time debugging this today, and I concluded that TRenderEngineProvider.tsx patch is the exact part of it that breaks the parts of the app. I found out that this bug is probably happening because along with the .defaultProps and propTypes that were removed from TRenderEngineProvider.tsx in that patch, we also removed the actual default props that were applied to the component. While I haven’t fully resolved it yet, I’m confident we’re on the right track.

[melvin-bot]

@paultsimura, @lakchote, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JKobrynski]

Update:

I managed to find a solution to at least one of the issues that my previous PR introduced. It's most likely going to fix the other issues too, I just didn't have the time to test it. The problem was that the patch prevented us from being able to apply custom styles. I am going to post a PR tomorrow after making sure the other tests are successful.

[JKobrynski]

Update:

I posted a PR and it's ready for review!