[HOLD for Payment 2024-10-04] [$250] [Search v2.4] [App] Introduce <SearchRouter> component

[luacmartins]

Implement this section of the doc

cc @Kicu @289Adam289 @Guccio163 @SzymczakJ

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834650090913251873
• Upwork Job ID: 1834650090913251873
• Last Price Increase: 2024-09-13

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[Kicu]

hey, since i was preparing a draft POC while writing the doc, I have some code for this, please assign me.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834650090913251873

[melvin-bot]

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

@Kicu, @twisterdotcom, @luacmartins, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

PR is going through deployment: #48785

[melvin-bot]

@Kicu, @twisterdotcom, @luacmartins, @ikevin127 Eep! 4 days overdue now. Issues have feelings too...

[Kicu]

also I might need to add a few more followups after my PR was merged, because we were trying to merge it ASAP so more tasks gets unblocked.
Now more than 1 person can work on search 2.4 at the same time, but I might have another PR related to this task. There are small bugs and tweaks

[luacmartins]

Sounds good. Let's work on the follow ups

[luacmartins]

@Kicu I think this issue is done, right? I believe we addressed all the follow up we needed to? Am I missing something?

[Kicu]

@luacmartins yes I believe so.
There will be some followups added to this, but they are done (by @adamgrzybowski) as part of this issue #49462

(because the input component to type in query is shared between the Router and SearchResults page).

This one we can consider done.

[luacmartins]

Cool, I think only thing left is payment then, once this PR gets deployed to prod

[ikevin127]

⚠️ Automation failed here -> this should be on [HOLD for Payment 2024-10-04] according to yesterday’s production deploy from #49379 (comment).

@luacmartins If payment will happen here, #49122 can be closed as it was addressed in the same PR.

Also, I reviewed 2 PRs which tagged this issue in the Fixed Issues section:

• Add new SearchButton to all pages and tweak SearchRouter #49379 (mentioned above)
• Add SearchRouter component and context to display it #48785 (Payment was due on 2024-09-26)

[twisterdotcom]

Okay, I see @ikevin127 reviewed both #49379 and #48785 and hasn't been paid yet for either, so $500 makes sense here.

#48785 was authored by @Kicu and #49379 was authored by @luacmartins, so @Kicu should only get $250 and @luacmartins should only get a pat on the pack and my heartfelt thanks.

[twisterdotcom]

Neither of these jobs I think have hires on in Upwork, so I'll send some contracts now ahead of time. I also see @Kicu is from SWM, so you also get heartfelt thanks instead too.

@ikevin127 - $500 here
@Kicu - my heartfelt thanks here
@luacmartins - my heartfelt thanks here

[ikevin127]

That's correct, offer accepted and a heartfelt thank you!

[luacmartins]

Thanks. Sending heartfelt thanks to all of you.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.