[PAID] [$250] Workspace switcher - Missing tab index for New Workspace button

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Open the app
2. Click on the Down arrow at Expensify logo
3. Press tab few times to select items in popup

Expected Result:

When pressing the tab in turn, the items will be selected and ready to be activated. And 'New workspace' button too.

Actual Result:

When pressing the tab a few times, the items in the popup will be selected, but the "New Workspace" button will not be selected.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6601259_1726159236269.Screen_Recording_2024-09-12_at_23.38.51.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836189432662301934
• Upwork Job ID: 1836189432662301934
• Last Price Increase: 2024-09-17
• Automatic offers:
• Nodebrute | Contributor | 104071431

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-12 19:16:58 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing tab index for New Workspace button

What is the root cause of that problem?

We are using accessible false here

App/src/pages/WorkspaceSwitcherPage/WorkspacesSectionHeader.tsx

Line 33 in 7748eff

accessible={false}

What changes do you think we should make in order to solve the problem?

We can remove this prop

App/src/pages/WorkspaceSwitcherPage/WorkspacesSectionHeader.tsx

Line 33 in 7748eff

accessible={false}

Optional: we can also add accessibilityLabel={translate('workspace.new.newWorkspace')}

Some cleanup might be required

Solution 2
We can pass true here

App/src/pages/WorkspaceSwitcherPage/WorkspacesSectionHeader.tsx

Line 33 in 7748eff

accessible={false}

What alternative solutions did you explore? (Optional)

We should add accessibilityLabel={translate('workspace.new.newWorkspace')} here

[melvin-bot]

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021836189432662301934

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[strepanier03]

Easy to repro on Mac/Chrome so applying external labels.

[Ollyws]

@Nodebrute's proposal LGTM.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Nodebrute]

I'll raise the PR in few hours.

[Nodebrute]

The production deploy automation failed: This should be on [HOLD for Payment 2024-10-07] according to #49855 production deploy checklist, confirmed in #49623 (comment)

cc: @strepanier03

[Nodebrute]

@strepanier03 the automation failed, The payment is due today. TIA.

[strepanier03]

Thanks @Nodebrute looking at this now.

[strepanier03]

Paid and contract closed, thanks again!

[Ollyws]

@strepanier03 could we get a payment summary on this one so I can request in newdot? Thanks!

[Ollyws]

Friendly bump on this one @strepanier03

[strepanier03]

Payment Summary

• @Nodebrute - $250 via Upwork (paid)
• @Ollyws - $250 via Manual Request in New Expensify

[strepanier03]

Sorry about that @Ollyws I missed it entirely.

[Ollyws]

Requested in ND.

[garrettmknight]

$250 approved for @Ollyws