Fix: Unique `key` warning #49222

gijoe0295 · 2024-09-15T06:26:34Z

Details

Fixed Issues

$ #49063
PROPOSAL: #49063 (comment)

Tests

Press FAB > Submit expense
Choose a workspace with Billable enabled
Proceed to confirmation page
Verify Warning: Each child in a list should have a unique “key” prop does not show

Press FAB > Submit expense > Distance > Start
Verify Warning: Invalid prop inbetweenCompo of type boolean supplied ... does not show
Verify Warning: Invalid prop listEmptyComponent of type function supplied ... does not show
Verify Warning: Invalid prop listLoaderComponent of type function supplied ... does not show

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

NA

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-15.at.13.52.51.mov

Android: mWeb Chrome

Screen.Recording.2024-09-15.at.13.43.06.mov

iOS: Native

Screen.Recording.2024-09-15.at.13.34.18.mov

iOS: mWeb Safari

screen-recording-2024-09-15-at-133815_oOoBPRcn.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-09-15.at.13.31.13.mov

MacOS: Desktop

Screen.Recording.2024-09-15.at.13.31.13.mov

melvin-bot · 2024-09-15T06:44:29Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2024-09-15T08:30:20Z

There are a couple of more warnings on this page. Let's get those solved as well.

15.09.2024_13.52.18_REC.mp4

gijoe0295 · 2024-09-16T18:57:40Z

2 of those are being resolved in #49064 and #49062. Would try to investigate and fix the rest unless they were too complicated and prone to regressions.

parasharrajat · 2024-09-16T19:27:11Z

@gijoe0295 Let me know when it's done.

…function

gijoe0295 · 2024-09-17T18:25:55Z

src/components/AddressSearch/index.tsx

                                <View style={[StyleUtils.getGoogleListViewStyle(true), styles.overflowAuto, styles.borderLeft, styles.borderRight]}>
                                    <CurrentLocationButton
                                        onPress={getCurrentLocation}
                                        isDisabled={isOffline}
                                    />
                                </View>
-                            )
+                            ) : undefined


predefinedPlaces?.length === 0 && shouldShowCurrentLocationButton can be false while inbetweenCompo expects a ReactNode.

gijoe0295 · 2024-09-17T18:27:25Z

src/components/AddressSearch/index.tsx

@@ -329,12 +329,12 @@ function AddressSearch(
        return predefinedPlaces?.filter((predefinedPlace) => isPlaceMatchForSearch(searchValue, predefinedPlace)) ?? [];
    }, [predefinedPlaces, searchValue]);

-    const listEmptyComponent = useCallback(
-        () => (!isTyping ? null : <Text style={[styles.textLabel, styles.colorMuted, styles.pv4, styles.ph3, styles.overflowAuto]}>{translate('common.noResultsFound')}</Text>),
+    const listEmptyComponent = useMemo(


useCallback returns a function while useMemo returns the ReactElement itself.

Same with listLoaderComponent.

gijoe0295 · 2024-09-17T18:33:26Z

@parasharrajat I fixed several warnings and commented above. Besides 2 other warnings that are being handled separately #49222 (comment), we only have this one left:

It's quite a complicated issue react-navigation/react-navigation#7839 so let's report it on Slack (I don't have access to the bug report channel).

parasharrajat · 2024-09-17T18:34:46Z

Sure. Thanks. I think it is good enough. Could you see why checks are failing?

melvin-bot · 2024-09-17T18:35:28Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

parasharrajat · 2024-09-17T18:37:16Z

@gijoe0295 Could you please fix the failed checks? Then I will wrap this one

gijoe0295 · 2024-09-17T18:48:23Z

Lint fixed.

parasharrajat · 2024-09-17T19:12:31Z

Screenshots

🔲 iOS / native

18.09.2024_14.43.13_REC.mp4

🔲 iOS / Safari

18.09.2024_15.00.58_REC.mp4

🔲 MacOS / Desktop

18.09.2024_14.32.49_REC.mp4

🔲 MacOS / Chrome

18.09.2024_14.28.44_REC.mp4

🔲 Android / Chrome

18.09.2024_14.59.18_REC.mp4

🔲 Android / native

18.09.2024_14.46.01_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat

@gijoe0295 I noticed that on the confirmation page when we click description to edit it, it shows another key warning. can you please fix that?

gijoe0295 · 2024-09-18T11:46:02Z

@parasharrajat It's not the unique “key” prop warning and will be resolved in #49064.

gijoe0295 · 2024-09-18T18:40:49Z

@parasharrajat Just found another one. Could you please reapprove?

OSBotify · 2024-09-18T23:15:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-19T23:54:49Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.39-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-24T19:04:18Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.39-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: unique key warning

205f47a

gijoe0295 changed the title ~~fix: unique key warning~~ Fix: Unique key warning Sep 15, 2024

gijoe0295 marked this pull request as ready for review September 15, 2024 06:44

gijoe0295 requested a review from a team as a code owner September 15, 2024 06:44

melvin-bot bot requested a review from parasharrajat September 15, 2024 06:44

melvin-bot bot removed the request for review from a team September 15, 2024 06:44

jayeshmangwani mentioned this pull request Sep 17, 2024

[$250] [Dev] Console Warning: ERROR Warning: A props object containing a “key” prop is being spread into JSX: #49064

Closed

6 tasks

gijoe0295 added 4 commits September 18, 2024 01:06

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/49063

e17c3ce

fix: invalid prop inbetweenCompo of type boolean

3fcea03

fix: invalid prop listEmptyComponent and listLoaderComponent of type …

0eee5fa

…function

remove redundant changes

5caf0b9

gijoe0295 commented Sep 17, 2024

View reviewed changes

fix lint: jsx deprecation

e9ef0dc

parasharrajat approved these changes Sep 18, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins September 18, 2024 09:31

parasharrajat suggested changes Sep 18, 2024

View reviewed changes

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/49063

cf48092

parasharrajat approved these changes Sep 18, 2024

View reviewed changes

fix: unique key warning in MenuItemList

f2f205b

parasharrajat approved these changes Sep 18, 2024

View reviewed changes

luacmartins approved these changes Sep 18, 2024

View reviewed changes

luacmartins merged commit 9d57f84 into Expensify:main Sep 18, 2024
18 checks passed

github-actions bot mentioned this pull request Sep 19, 2024

Deploy Checklist: New Expensify 2024-09-19 #49505

Closed

31 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Unique `key` warning #49222

Fix: Unique `key` warning #49222

gijoe0295 commented Sep 15, 2024 •

edited

Loading

melvin-bot bot commented Sep 15, 2024

parasharrajat commented Sep 15, 2024

gijoe0295 commented Sep 16, 2024

parasharrajat commented Sep 16, 2024

gijoe0295 Sep 17, 2024

gijoe0295 Sep 17, 2024

gijoe0295 commented Sep 17, 2024

parasharrajat commented Sep 17, 2024

melvin-bot bot commented Sep 17, 2024

parasharrajat commented Sep 17, 2024 •

edited

Loading

gijoe0295 commented Sep 17, 2024

parasharrajat commented Sep 17, 2024 •

edited

Loading

parasharrajat left a comment

parasharrajat left a comment

gijoe0295 commented Sep 18, 2024 •

edited

Loading

gijoe0295 commented Sep 18, 2024

OSBotify commented Sep 18, 2024

OSBotify commented Sep 19, 2024

OSBotify commented Sep 24, 2024

Fix: Unique key warning #49222

Fix: Unique key warning #49222

Conversation

gijoe0295 commented Sep 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 15, 2024

parasharrajat commented Sep 15, 2024

gijoe0295 commented Sep 16, 2024

parasharrajat commented Sep 16, 2024

gijoe0295 Sep 17, 2024

Choose a reason for hiding this comment

gijoe0295 Sep 17, 2024

Choose a reason for hiding this comment

gijoe0295 commented Sep 17, 2024

parasharrajat commented Sep 17, 2024

melvin-bot bot commented Sep 17, 2024

parasharrajat commented Sep 17, 2024 • edited Loading

gijoe0295 commented Sep 17, 2024

parasharrajat commented Sep 17, 2024 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

parasharrajat left a comment

Choose a reason for hiding this comment

gijoe0295 commented Sep 18, 2024 • edited Loading

gijoe0295 commented Sep 18, 2024

OSBotify commented Sep 18, 2024

OSBotify commented Sep 19, 2024

OSBotify commented Sep 24, 2024

Fix: Unique `key` warning #49222

Fix: Unique `key` warning #49222

gijoe0295 commented Sep 15, 2024 •

edited

Loading

parasharrajat commented Sep 17, 2024 •

edited

Loading

parasharrajat commented Sep 17, 2024 •

edited

Loading

gijoe0295 commented Sep 18, 2024 •

edited

Loading