[HOLD for payment 2024-10-24] [$250] Show the next step for Closed or Approved reports as “No action required” if payments are disabled.

[garrettmknight]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: N/A
Reproducible in staging?: Y
Reproducible in production?: Y
Expensify/Expensify Issue URL: N/A
Issue reported by: @srikarparsi
Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1726537212622119?thread_ts=1725892977.799399&cid=C06ML6X0W9L

Action Performed:

1. Create a workspace
2. Enable workflows
3. Disable payments
4. Submit an expense on the workspace chat
5. Click into the expense

Expected Result:

The next step for this report should be “No action required” if payments are disabled.

Actual Result:

The next step does not render.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

All

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021835986044043862116
• Upwork Job ID: 1835986044043862116
• Last Price Increase: 2024-09-17
• Automatic offers:
• ikevin127 | Reviewer | 104000212

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021835986044043862116

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[koko57]

Hey, I'm Agata from Callstack - an expert contributor group - I can take a look at this issue

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[trjExpensify]

Also assigning @koko57 here to look into this. 👍

[koko57]

either I'm doing it wrong, or I really cannot recreate the bug

Screen.Recording.2024-09-17.at.20.46.53.mp4

@garrettmknight could you check if I'm not missing something?

[trjExpensify]

For closed reports:

• Workflows = enabled
• Delayed submission = disabled
• Approvals = disabled
• Payments = disabled

^^ I validated the above config by going to OldDot and checking for

• Reports > Scheduled Submit > Instantly
• Members > Approval Mode > Submit & close
• Reimbursement > None

2024-09-17_15-18-14.mp4

Then all I did was:

1. Submit an expense on the workspace as the admin
2. I don't see a pay button
3. I do see the incorrect next steps:

[trjExpensify]

Then for the approved reports case:

Workflows = enabled
Delayed submission = disabled
Approvals = enabled
Payments = disabled

^^ I validated the above config by going to OldDot and checking for

Reports > Scheduled Submit > Instantly
Members > Approval Mode > Submit & approve
Reimbursement > None

Steps:

1. Submit an expense on the workspace as the admin
2. I see an Approve button
3. I approve the report and see incorrect next steps about waiting to adding a bank account (notice how it flashes as well).

2024-09-17_15-21-43.mp4

[koko57]

ok, so it's for an expense submitted by admin? So the tests steps are a bit misleading 😅

[trjExpensify]

That's what I did to produce the above, yeah. @srikarparsi can confirm on his steps from the OP when he's on.

[koko57]

ok, I reproduced it now too - so I'm starting digging

[koko57]

@trjExpensify EDIT: I've noticed that right after submitting an expense we get

later we get this one

the latter we get from the OpenReport request

so it's a backend issue

Should the first one stay as it is? Or should it also say “No action required”

[srikarparsi]

Sorry this should be on hold for this Auth PR. This will only be reproducible once the Auth PR hits production

[ikevin127]

Not overdue, the issue is being actively worked on.

[srikarparsi]

ok, I will apply this, but won't it be replaced by the response from OpenReport? We get an empty array for that

Ah thanks for the looking into this. Do you think you could help with the offline (optimistic) behavior here and I can work on a backend PR that returns the right next steps for this case?

[koko57]

@srikarparsi ok, I will take care of it 🙂

[koko57]

@srikarparsi Just to make sure: we shouldn't display this text for disabled payments, we should display “No action required” instead?

[srikarparsi]

Yup exactly, thanks! Since there won't be a pay or approve button in this case, we should display “No action required”

[ikevin127]

Not overdue, the issue is being actively worked on.

[koko57]

PR ready for review #49837

[ikevin127]

♻️ Status update: I reviewed and approved the PR previously but there was a misunderstanding in terms of functionality which means that the PR was being worked on up until yesterday, today I asked the author if the PR is ready to be retested.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: change message when reimbursementChoice is reimburseNo #49837

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @ikevin127 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Summarizing payment on this issue:

Contributor: @koko57 no payment required, Contractor
Contributor+: @ikevin127 $250, paid via Upwork

@ikevin127 could you please complete the BZ checklist we we can close out the issue? Thanks 🙏

[ikevin127]

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR: Not caused by a previous PR as this was more like a feature request since we added something that did not exist before.
• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A.
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to Workspace -> enable Workflows.
2. Disable payments.
3. Submit an expense on the workspace chat.
4. Go offline, click into the expense.
5. Verify that you see "No further action required" text in the header.

Do we agree 👍 or 👎.

[sakluger]

Thanks!