[HOLD for payment 2024-10-14] [$250] Search - Room mention in the message is not highlighted or linked when opened from Search

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to a room.
3. Send a message containing #room mention.
4. Go to Search.
5. Go to Chat.
6. Click on the message sent in Step 3.

Expected Result:

The room mention in the message will be highlighted and linked when opened from Search.

Actual Result:

The room mention in the message is not highlighted or linked when opened from Search.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6608683_1726739485892.bandicam_2024-09-19_17-47-50-037.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021838252249332966020
• Upwork Job ID: 1838252249332966020
• Last Price Increase: 2024-09-23
• Automatic offers:
• situchan | Reviewer | 104118455
• nkdengineer | Contributor | 104118456

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The room mention in the message is not highlighted or linked when opened from Search.

What is the root cause of that problem?

Currently, here the values of currentReportIDContext and currentReportID?.currentReportID are both -1 because we are not adding enough Provider and passing the correct reportID in the Search Page, which is why the value of isGroupPolicyReport is false, and we will not show the highlight for that message.

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx

Line 63 in b0ce206

const currentReportIDValue = currentReportIDContext || currentReportID?.currentReportID;

What changes do you think we should make in order to solve the problem?

We should add MentionReportContext.Provider for items and pass in the value mentionReportContextValue like we did here with

    const mentionReportContextValue = useMemo(() => ({currentReportID: report.reportID}), [report.reportID]);

1. We can add this provider to ChatListItem here to highlight text in list all chats

App/src/components/SelectionList/ChatListItem.tsx

Line 82 in b0ce206

<MultipleAvatars

2. Also add this provider to ReportActionItem here

App/src/pages/home/report/ReportActionItem.tsx

Line 905 in b0ce206

<PressableWithSecondaryInteraction

What alternative solutions did you explore? (Optional)

NA

result.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021838252249332966020

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[situchan]

@nkdengineer's proposal looks good to me.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @mjasikowski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mjasikowski]

@nkdengineer's proposal looks good, green light to go forward with the PR

[nkdengineer]

@mjasikowski please assign me to this issue so i can open the PR

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Room mention in the message is not highlighted #49769

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

@situchan Can you please complete this checklist?

[situchan]

This was not a regression but missing case while implementing Search v2.2 - chat type in search.
I think we'll add comprehensive regression tests after search project is done so no action required here.

[slafortune]

@situchan Role - C+ - Paid $250 Via Upworks
@nkdengineer Role - Contributor - Paid $250 Via Upworks