Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] [$250] Tags-Deselecting state tag shows state no longer valid error #49504

Open
3 of 6 tasks
IuliiaHerets opened this issue Sep 19, 2024 · 45 comments
Open
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Sep 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4988212
Issue reported by: Applause Internal Team

Action Performed:

Pre-conditions:

  • In Android app, login as admin &create a workspace
  • Invite a employee and as employee keep logged in mweb
  • Enable tags for admin in app
  1. Login old dot as admin of workspace
  2. Tap settings --workspace-- tags
  3. Enable "use multiple level of tags", verify " People must tag expense also enabled (if not enable it)
  4. Tap import from spread sheet and select a depedent tag file attached below
  5. Tap upload tags
  6. In new dot, open workspace settings- tags
  7. Disable region-- North+test
  8. Open in mweb as employee, workspace chat
  9. Submit a expense entering merchant
  10. Open the expense created
  11. Deselect the state tag

Expected Result:

Deselecting state tag must show state tag missing error.

Actual Result:

Deselecting state tag shows state no longer valid error.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6608867_1726749697606.screenrecorder-2024-09-19-13-04-15-98_compress_1.1.mp4

Dependent - Multi Level tags NEW (2).csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021838256634008984824
  • Upwork Job ID: 1838256634008984824
  • Last Price Increase: 2024-09-23
  • Automatic offers:
    • rayane-djouah | Reviewer | 104196844
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@sakluger
Copy link
Contributor

@IuliiaHerets I think you attached the wrong video, it doesn't match the reproduction steps. Could you please check?

@IuliiaHerets
Copy link
Author

@sakluger Fixed it, sorry

@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2024
@sakluger
Copy link
Contributor

Thanks! Adding the external label now.

@melvin-bot melvin-bot bot removed the Overdue label Sep 23, 2024
@sakluger sakluger added the External Added to denote the issue can be worked on by a contributor label Sep 23, 2024
@melvin-bot melvin-bot bot changed the title Tags-Deselecting state tag shows state no longer valid error [$250] Tags-Deselecting state tag shows state no longer valid error Sep 23, 2024
Copy link

melvin-bot bot commented Sep 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021838256634008984824

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 23, 2024
Copy link

melvin-bot bot commented Sep 23, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

@rayane-d
Copy link
Contributor

The steps for multi-tags setup are here: #44995 (comment) in Tag violations on workspace with Independent Tags (multi-level tags) section

@rayane-d
Copy link
Contributor

Looking for proposals!

Copy link

melvin-bot bot commented Sep 27, 2024

@sakluger, @rayane-djouah, @IuliiaHerets Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 27, 2024
@rayane-d
Copy link
Contributor

Waiting on proposals

@melvin-bot melvin-bot bot removed the Overdue label Sep 27, 2024
@rezkiy37
Copy link
Contributor

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

@melvin-bot melvin-bot bot added the Overdue label Sep 30, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 30, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot melvin-bot bot removed the Overdue label Sep 30, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

@sakluger, @rezkiy37, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 11, 2024
@rayane-d
Copy link
Contributor

@JmillsExpensify bump on #49504 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Oct 12, 2024
@JmillsExpensify
Copy link

Yes, I agree with Carlos. Let's put this on hold for @yuwenmemon's dependent tag project.

@sakluger
Copy link
Contributor

@yuwenmemon is there a particular GH issue that I can put this on hold for? Or could we close it because you will naturally build this as part of your dependent tag project?

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2024
@sakluger sakluger removed the External Added to denote the issue can be worked on by a contributor label Oct 16, 2024
@sakluger sakluger changed the title [$250] Tags-Deselecting state tag shows state no longer valid error [HOLD] [$250] Tags-Deselecting state tag shows state no longer valid error Oct 16, 2024
@sakluger sakluger added Monthly KSv2 and removed Daily KSv2 labels Oct 16, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2024
@yuwenmemon
Copy link
Contributor

Let's put this on HOLD waiting on https://github.com/Expensify/Expensify/issues/418655

And then we can include it as part of the polish issues for that project (there's a chance we just fix it as part of implementation)

@rayane-d
Copy link
Contributor

@yuwenmemon I assume this will be purely backend, right? Will anything be needed from me?

@rayane-d rayane-d removed their assignment Oct 30, 2024
@rayane-d
Copy link
Contributor

I'm unassigning myself from this issue, assuming it will be handled internally. Please reassign me if any frontend changes are needed. Thanks!

@sakluger
Copy link
Contributor

Sounds good! I'm adding this to the #expense project to line up with the issue it's on hold for: https://github.com/Expensify/Expensify/issues/418655

@garrettmknight garrettmknight moved this to Future Cohort Project in [#whatsnext] #expense Nov 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
@sakluger
Copy link
Contributor

sakluger commented Dec 2, 2024

The hold issue is also still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 3, 2025
@sakluger
Copy link
Contributor

sakluger commented Jan 8, 2025

The hold issue (https://github.com/Expensify/Expensify/issues/418655) is still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2025
@rezkiy37
Copy link
Contributor

rezkiy37 commented Feb 3, 2025

@sakluger, any updates?

More context - #49504 (comment).

@rezkiy37
Copy link
Contributor

I’m planning a short vacation next week from Monday to Wednesday, from the 17th to the 19th. I am working on the issue later.

@rezkiy37
Copy link
Contributor

I am back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2
Projects
Status: Future Cohort Project
Development

No branches or pull requests

7 participants