[$250] Room-A "workspace" visibility room is created via whisper from a "public" visibility room

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap fab -- start chat
3. Create a public visibility room
4. Create 2 room via whisper by sending message - eg : #35 #799
5. From the whisper message, tap yes
6. Note room created is highlighted
7. Now tap on room header -- settings -- visibility
8. Note room is a "public" visibility room
9. Now tap on any room highlighted ( created via whisper)
10. Now tap on room header -- settings -- visibility
11. Note room created is a workspace visibility room

Expected Result:

A "public" visibility room must be created via whisper from a "public" visibility room.

Actual Result:

A "workspace" visibility room is created via whisper from a "public" visibility room.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6609907_1726835399664.screenrecorder-2024-09-20-16-47-00-591_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021837194850505873695
• Upwork Job ID: 1837194850505873695
• Last Price Increase: 2024-09-20
• Automatic offers:
• DylanDylann | Reviewer | 104139929
• nkdengineer | Contributor | 104139931

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Christinadobrzyn]

I can reproduce this with the steps in the OP. I think this can be external - let's start there and see what we think!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021837194850505873695

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A "workspace" visibility room is created via whisper from a "public" visibility room.

What is the root cause of that problem?

When we click on Yes, BE will create a room with visibility as restricted

What changes do you think we should make in order to solve the problem?

In this function, if resolution is created, we should create an optimistic room with visibility as the visibility of the current report and a created action for this room in optimistic data (Also reset it in failure data).

App/src/libs/actions/Report.ts

Lines 3883 to 3887 in 513e6b3

	function resolveActionableReportMentionWhisper(
	reportId: string,
	reportAction: OnyxEntry<ReportAction>,
	resolution: ValueOf<typeof CONST.REPORT.ACTIONABLE_REPORT_MENTION_WHISPER_RESOLUTION>,
	) {

Then we can pass the reportID and visibility of the new room as a param of ResolveActionableReportMentionWhisper API. BE will use this reportID and visibility to create a new room.

What alternative solutions did you explore? (Optional)

If we don't want to create an optimistic room, we can pass visibility param to ResolveActionableReportMentionWhisper API then BE can use this to create the room with the correct visibility.

[melvin-bot]

@Christinadobrzyn, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

@DylanDylann, can you check out the proposal? Thanks!

[DylanDylann]

I like @nkdengineer's idea to create the optimistic room data. With this approach, we have the ability to create a new room offline but still need to modify the visibility field on the BE side.

On the other hand, If we don't want to support this action offline, we can handle this issue on the BE totally by modifying the visibility field

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @justinpersaud, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Christinadobrzyn]

Heads up - I'm going to be ooo till 9/30. I'm not going to assign a BZ buddy to this since we're reviewing proposals. If you need someone in the meantime, feel free to reach out to the Bug team for a volunteer. thanks!

[justinpersaud]

I think it's fine to support offline, proposal sounds good to me

[DylanDylann]

@justinpersaud Could you give the final assignment to @nkdengineer ? Then we can start on PR

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[justinpersaud]

Assigned

[nkdengineer]

@justinpersaud We need to introduce a new param to send the list ID of new rooms when we create this via whisper action then BE can use this list ID to create new rooms on the backend side.

[justinpersaud]

@nkdengineer do you have a suggested name for this new param you're proposing?

[nkdengineer]

@justinpersaud I think it can be reportIDList

[nkdengineer]

@justinpersaud friendly bump

[justinpersaud]

Sorry I was out sick. I'll look into what we need to do for the backend changes to get this out.

[justinpersaud]

Sorry, now that I am looking into this a bit more, what are we expecting the outcome will be in the event that there is a collision on the room name if we try to create a room offline and it was already created?

[Christinadobrzyn]

@nkdengineer can you take a peek at these questions when you have a moment? TY! #49544 (comment)

[nkdengineer]

@justinpersaud If the report was created, please send the preexistingReportID as the existing reportID for the report data of the reportID according to the room name in the API param. And then frontend already have the logic the clear the optimistic report.

[DylanDylann]

@justinpersaud Could you help to check the above comment? Thanks

[justinpersaud]

Yeah, just trying to prioritize when we'll get the backend change done. I haven't had a chance to do it just yet with other priorities.

[justinpersaud]

I'm wrapping up some other tasks right now internally, but hoping to look at the backend changes required later this week

[DylanDylann]

@justinpersaud Kindly bump

[justinpersaud]

Looked at the backend change just now and see we are defaulting to workspace visibility as we reported here, but I am asking if there is a specific reason why in our product channel

[justinpersaud]

@DylanDylann @nkdengineer I am newer to working on these proposals so you'll have to bear with me here, but why are we passing in reportIDList, implying we would pass a number of reportIDs to the backend, right?

Won't we ever only be sending a single reportID to the backend to be created? Or are we going to queue up a backend call to ResolveActionableReportMentionWhisper with multiple reportIDs?

[Christinadobrzyn]

@DylanDylann and @nkdengineer can you follow up on this - #49544 (comment)

[nkdengineer]

Won't we ever only be sending a single reportID to the backend to be created? Or are we going to queue up a backend call to ResolveActionableReportMentionWhisper with multiple reportIDs?

@justinpersaud I will send an array of reportIDs because ResolveActionableReportMentionWhisper can have multiple new rooms.

[justinpersaud]

Hey all,

I circled back internally and discovered this feature is actually working as designed. We want the visibility of rooms to always be set to workspace, regardless of where it is created by default.

Thanks for the initial work and investigation. I'll leave it with @Christinadobrzyn for any outstanding payment for work that was already done.

[Christinadobrzyn]

Ah thanks @justinpersaud!
It looks like a PR was created but not merged to production so our standard reasoning for payment isn't applicable.

@DylanDylann @nkdengineer let me know if there's anything compensation you feel should be considered for the work you spent. Thanks!

[DylanDylann]

@Christinadobrzyn From https://expensify.slack.com/archives/C02NK2DQWUX/p1723055151068559?thread_ts=1723015261.405329&cid=C02NK2DQWUX, I think we should get full compensation

[Christinadobrzyn]

Okay sounds reasonable since the proposals were reviewed and the PR was created.

Payouts due:

• Contributor: $250 @nkdengineer (paid in Upwork - https://www.upwork.com/nx/wm/offer/104139931)
• Reviewer: $250 @DylanDylann (paid in Upwork - https://www.upwork.com/nx/wm/workroom/38546784/details)

No regression test needed. Closing this out!