-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Approver - Next step message for the approver is not displayed #49552
Comments
Triggered auto assignment to @lschurr ( |
@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
I'm heading OOO from 9/23-10/4 so I need to reassign this one. |
Triggered auto assignment to @CortneyOfstad ( |
Will need a bit of time to test this! |
I was not able to recreate this consistently, so going to see if we can have this retested! |
Job added to Upwork: https://www.upwork.com/jobs/~021839076781356799211 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
@CortneyOfstad, @rushatgabhane Huh... This is 4 days overdue. Who can take care of this? |
Not overdue as we're still waiting for this to be retested! |
Hey! I'm Eto Olei from Callstack. I will like to look into this issue. Please assign it to me. Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Sounds great @teneeto! Thanks! |
Still investigating this one. |
@CortneyOfstad @teneeto @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Hi @CortneyOfstad I'm still looking into this. Although i can see a similar behaviour, but I have not yet reproduced the exact issue as seen in description. Still some more time to dig in. |
I'm not sure if I'm missing any steps, but I still can't reproduce this. Can we retest it? |
Thanks @teneeto! I also am not able to consistently reproduce this — going to close! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4991111
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
OD configuration
NewDot - Admin Approver
Expected Result:
There is a hour glass with a comment: "Oops! Looks like you're submitting to yourself. Approving your own reports is forbidden by your policy. Please submit this report to someone else or contact your admin to change the person you submit to." and label is "Next Steps"."
Actual Result:
A message is not display to the approver that they're not allowed to submit reports to themselves if the Enable self Approval is enabled in the workspace.
Issue doesn't happen with the US tester.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6610193_1726856944474.2024-09-20_21.26.48.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @rushatgabhaneThe text was updated successfully, but these errors were encountered: