Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Approver - Next step message for the approver is not displayed #49552

Closed
2 of 6 tasks
IuliiaHerets opened this issue Sep 20, 2024 · 18 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Sep 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4991111
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Create a workspace with an approver.
  2. Make the approver the approver of the workspace

OD configuration

  1. As the admin in OldDot - Navigate to members
  2. Under "Workflow enforcement" enable "Prevent Self Approval"

NewDot - Admin Approver

  1. Login as the Approver
  2. Navigate to the workspace chat
  3. Submit expense from the workspace
  4. Click on the report that was created

Expected Result:

There is a hour glass with a comment: "Oops! Looks like you're submitting to yourself. Approving your own reports is forbidden by your policy. Please submit this report to someone else or contact your admin to change the person you submit to." and label is "Next Steps"."

Actual Result:

A message is not display to the approver that they're not allowed to submit reports to themselves if the Enable self Approval is enabled in the workspace.
Issue doesn't happen with the US tester.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6610193_1726856944474.2024-09-20_21.26.48.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021839076781356799211
  • Upwork Job ID: 1839076781356799211
  • Last Price Increase: 2024-10-02
Issue OwnerCurrent Issue Owner: @rushatgabhane
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 20, 2024
Copy link

melvin-bot bot commented Sep 20, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lschurr lschurr removed the Bug Something is broken. Auto assigns a BugZero manager. label Sep 20, 2024
@lschurr lschurr removed their assignment Sep 20, 2024
@lschurr lschurr added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 20, 2024
@lschurr
Copy link
Contributor

lschurr commented Sep 20, 2024

I'm heading OOO from 9/23-10/4 so I need to reassign this one.

Copy link

melvin-bot bot commented Sep 20, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2024
@CortneyOfstad
Copy link
Contributor

Will need a bit of time to test this!

@melvin-bot melvin-bot bot removed the Overdue label Sep 23, 2024
@CortneyOfstad
Copy link
Contributor

I was not able to recreate this consistently, so going to see if we can have this retested!

@CortneyOfstad CortneyOfstad added retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause External Added to denote the issue can be worked on by a contributor labels Sep 25, 2024
@melvin-bot melvin-bot bot changed the title Approver - Next step message for the approver is not displayed [$250] Approver - Next step message for the approver is not displayed Sep 25, 2024
Copy link

melvin-bot bot commented Sep 25, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021839076781356799211

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 25, 2024
Copy link

melvin-bot bot commented Sep 25, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

Copy link

melvin-bot bot commented Oct 1, 2024

@CortneyOfstad, @rushatgabhane Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Oct 1, 2024
@CortneyOfstad
Copy link
Contributor

Not overdue as we're still waiting for this to be retested!

@teneeto
Copy link
Contributor

teneeto commented Oct 2, 2024

Hey! I'm Eto Olei from Callstack. I will like to look into this issue. Please assign it to me. Thanks!

Copy link

melvin-bot bot commented Oct 2, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@CortneyOfstad
Copy link
Contributor

Sounds great @teneeto! Thanks!

@melvin-bot melvin-bot bot removed Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels Oct 2, 2024
@teneeto
Copy link
Contributor

teneeto commented Oct 4, 2024

Still investigating this one.

Copy link

melvin-bot bot commented Oct 4, 2024

@CortneyOfstad @teneeto @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@teneeto
Copy link
Contributor

teneeto commented Oct 8, 2024

Hi @CortneyOfstad I'm still looking into this. Although i can see a similar behaviour, but I have not yet reproduced the exact issue as seen in description. Still some more time to dig in.

@melvin-bot melvin-bot bot added the Overdue label Oct 8, 2024
@teneeto
Copy link
Contributor

teneeto commented Oct 8, 2024

I'm not sure if I'm missing any steps, but I still can't reproduce this. Can we retest it?

@CortneyOfstad
Copy link
Contributor

Thanks @teneeto! I also am not able to consistently reproduce this — going to close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
Archived in project
Development

No branches or pull requests

5 participants