Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simple AA in NewDot] On report harvest, make sure all updates get sent to correct people in NewDot #49612

Closed
Beamanator opened this issue Sep 23, 2024 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@Beamanator
Copy link
Contributor

Bug report here: https://expensify.slack.com/archives/C06ML6X0W9L/p1726447005514619

AFAIK the steps to reproduce are:

  1. Control policy w/ isPolicyExpenseChatEnabled & Delayed Submission set (ex: Daily) & Workflows Enabled / Advanced Approvals Enabled
  2. Submitter create Expense report w/ at least 1 expense - DON'T SUBMIT
  3. Open report as non-admin Approver (not sure if non-admin is necessary)
  4. Wait for report to get harvested

Expected:

  • Approver should see updates in their device that the report was submitted & it's now their turn to approve

Actual:

  • From the bug report, it SEEMS like GBR does show up for approver, but the report preview doesn't - so the approver didn't know it's time to approve, they just saw GBR for "something"
@Beamanator Beamanator added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 23, 2024
@Beamanator Beamanator self-assigned this Sep 23, 2024
Copy link

melvin-bot bot commented Sep 23, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 25, 2024
@CortneyOfstad
Copy link
Contributor

I am having trouble recreating this, so going to see if QA is willing to test!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 25, 2024
@Beamanator
Copy link
Contributor Author

I think we can add retest-weekly to get QA to test/

@melvin-bot melvin-bot bot removed the Overdue label Sep 30, 2024
@Beamanator Beamanator added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Oct 3, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2024
Copy link

melvin-bot bot commented Oct 4, 2024

@Beamanator, @CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!

@CortneyOfstad
Copy link
Contributor

Not overdue as we're waiting on QA!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 4, 2024
Copy link

melvin-bot bot commented Oct 7, 2024

@Beamanator @CortneyOfstad this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@CortneyOfstad
Copy link
Contributor

Not overdue as we're waiting for QA to test!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 8, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

@Beamanator, @CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!

@CortneyOfstad
Copy link
Contributor

Bumped QA as this has been 3 weeks — https://expensify.slack.com/archives/C9YU7BX5M/p1728930308712659

@melvin-bot melvin-bot bot removed the Overdue label Oct 14, 2024
@CortneyOfstad CortneyOfstad removed their assignment Oct 15, 2024
@CortneyOfstad CortneyOfstad added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 15, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@CortneyOfstad
Copy link
Contributor

Hey @adelekennedy! I am heading OoO (10/15 to 10/23) so wanted to reassign this to keep it moving. I pinged QA to see if they could bump up the testing since it has been 3 weeks. That conversation is linked here.

Thanks!

@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2024
@adelekennedy
Copy link

Bumped the thread!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 18, 2024
@kavimuru
Copy link

Unable to reproduce the bug

Recording.2058.mp4

@Beamanator
Copy link
Contributor Author

ooh that's nice, maybe we can close!

@melvin-bot melvin-bot bot removed the Overdue label Oct 21, 2024
@adelekennedy
Copy link

oooh I think so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
Status: Done
Development

No branches or pull requests

4 participants