[HOLD for Payment 2024-10-04][$250] [Search v2.3] - Default name in name field displays user/report ID instead of user/report name #49739

lanitochka17 · 2024-09-25T19:47:54Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.40-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to Search
Click Filters
Click To
Select a user and save it
Click Save search
Click 3-dot menu next to the saved search
Click Rename

Expected Result:

The default name in search name field will display user name instead of user ID

Actual Result:

The default name in search name field displays user ID instead of user name
The same goes for report ID when In filter is used for chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6615159_1727291077447.ID.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021839048305434680628
Upwork Job ID: 1839048305434680628
Last Price Increase: 2024-09-25
Automatic offers:

rayane-djouah | Reviewer | 104132486
Nodebrute | Contributor | 104132487

Issue Owner

Current Issue Owner: @rayane-djouah

melvin-bot · 2024-09-25T19:48:04Z

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions · 2024-09-25T19:48:09Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

lanitochka17 · 2024-09-25T19:48:24Z

We think that this bug might be related to #wave-control

Nodebrute · 2024-09-25T20:06:25Z

Edited by proposal-police: This proposal was edited at 2024-09-25 21:41:18 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Default name in name field displays user/report ID instead of user/report name

What is the root cause of that problem?

Here we are using title to convert reportID/userID to their names

App/src/pages/Search/SearchTypeMenu.tsx

Lines 103 to 108 in 55b1e32

    
           let title = item.name; 
        
           if (title === item.query) { 
        
               const jsonQuery = SearchUtils.buildSearchQueryJSON(item.query) ?? ({} as SearchQueryJSON); 
        
               title = SearchUtils.getSearchHeaderTitle(jsonQuery, personalDetails, cardList, reports, taxRates); 
        
           }

But here we are passing item.name without updating it

App/src/pages/Search/SearchTypeMenu.tsx

Line 120 in 55b1e32

    
           rightComponent: <SavedSearchItemThreeDotMenu menuItems={getOverflowMenu(item.name, Number(key), item.query)} />,

We then use this item.name here to navigate to rename page

App/src/libs/SearchUtils.ts

Line 787 in 6a9ba21

    
           Navigation.navigate(ROUTES.SEARCH_SAVED_SEARCH_RENAME.getRoute({name: itemName, jsonQuery: inputQuery}));

and Then, on the Rename page, we get this name from the route. Since we haven't passed the updated title, we’ll see userID/ReportID instead of their names.

App/src/pages/Search/SavedSearchRenamePage.tsx

Line 19 in 6a9ba21

    
           function SavedSearchRenamePage({route}: {route: {params: {q: string; name: string}}}) {

What changes do you think we should make in order to solve the problem?

We should pass title here instead of item.name

App/src/pages/Search/SearchTypeMenu.tsx

Line 120 in 55b1e32

    
           rightComponent: <SavedSearchItemThreeDotMenu menuItems={getOverflowMenu(item.name, Number(key), item.query)} />,

We should check for other places too where we have this issue

What alternative solutions did you explore? (Optional)

daledah · 2024-09-25T20:07:19Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The default name in search name field displays user ID instead of user name
The same goes for report ID when In filter is used for chat

What is the root cause of that problem?

Currently we are getting name directly from query when there is no name here

App/src/pages/Search/SavedSearchRenamePage.tsx

Lines 22 to 23 in 912c330

    
           const {q, name} = route.params; 
        
           const [newName, setNewName] = useState(name);

What changes do you think we should make in order to solve the problem?

We should convert from query to name like we did here

    useEffect(()=>{
        if(name === q){
            const jsonQuery = SearchUtils.buildSearchQueryJSON(q) ?? ({} as SearchQueryJSON);
            const title = SearchUtils.getSearchHeaderTitle(jsonQuery, personalDetails, cardList, reports, taxRates);
            setNewName(title)
        }
    },[name])

and need to update the default value to newName

  defaultValue={newName}

App/src/pages/Search/SavedSearchRenamePage.tsx

Line 68 in 912c330

defaultValue={name}

What alternative solutions did you explore? (Optional)

NA

Nodebrute · 2024-09-25T20:08:36Z

Proposal Updated
Fixed link previews

neonbhai · 2024-09-25T20:22:18Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Default name in name field displays user/report ID instead of user/report name

What is the root cause of that problem?

We don't pass the updated item title for getOverflowMenu here:

App/src/pages/Search/SearchTypeMenu.tsx

Line 120 in a4a344b

    
           rightComponent: <SavedSearchItemThreeDotMenu menuItems={getOverflowMenu(item.name, Number(key), item.query)} />,

What changes do you think we should make in order to solve the problem?

We should pass the updated title to :

rightComponent: <SavedSearchItemThreeDotMenu menuItems={getOverflowMenu(title, Number(key), item.query)} />,\

Note: This bug does not occur for small screen devices as we pass it correctly here.

Result

This works perfectly:

Screen.Recording.2024-09-26.at.1.50.57.AM.mov

melvin-bot · 2024-09-25T21:04:20Z

Job added to Upwork: https://www.upwork.com/jobs/~021839048305434680628

melvin-bot · 2024-09-25T21:04:25Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

melvin-bot · 2024-09-25T21:04:29Z

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

rayane-djouah · 2024-09-25T21:30:31Z

Reviewing 👀

Nodebrute · 2024-09-25T21:41:55Z

@rayane-djouah I have updated my proposal to add detailed RCA for more clear understanding

rayane-djouah · 2024-09-25T22:21:39Z

Offending PR: #49558
(The "name" field population is a new feature that doesn't yet exist in production. This case was missed in the original PR that implemented the feature.)

rayane-djouah · 2024-09-25T22:21:53Z

@Nodebrute's proposal looks good to me

🎀👀🎀 C+ reviewed

melvin-bot · 2024-09-25T22:22:03Z

Current assignee @stitesExpensify is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot · 2024-09-25T22:32:11Z

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Nodebrute · 2024-09-25T22:33:05Z

PR will be ready in 30 minutes

stitesExpensify · 2024-09-26T20:04:37Z

Tested 🟢

rayane-djouah · 2024-09-28T16:09:41Z

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-10-04] according to #49662 production deploy checklist, confirmed in #49757 (comment)

cc @kadiealexander

luacmartins · 2024-09-30T12:53:15Z

This is no longer a blocker since it was already fixed on the previous checklist

rayane-djouah · 2024-10-02T21:18:55Z

[HOLD for Payment 2024-10-04]

kadiealexander · 2024-10-07T00:39:54Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
[@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rayane-djouah] Determine if we should create a regression test for this bug.
[@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

kadiealexander · 2024-10-07T00:41:40Z

Payouts due:

Contributor: $250 @Nodebrute (Offer link)
Contributor+: $250 @rayane-djouah (Offer link)

Upwork job is here.

rayane-djouah · 2024-10-07T15:56:18Z

BugZero Checklist

The PR that introduced the bug has been identified. Link to the PR: The root cause of the bug was missed during feature implementation in [Search v2.3] [App] Implement Saved Search feature #48566 and [CP Staging] Fix saved search names #49235 and then the bug was introduced by fix autofocus #49558
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/48566/files#r1790483654, https://github.com/Expensify/App/pull/49235/files#r1790480251, fix autofocus #49558 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Go to Search
Click Filters
Click To
Select a user and save it
Click Save search
Click 3-dot menu next to the saved search
Click Rename
Verify that the default name in the search name field will display the user name instead of the user ID

Do we agree 👍 or 👎

cc @kadiealexander

luacmartins · 2024-10-09T17:21:36Z

We'll add tests as part of the project wrap up

rayane-djouah · 2024-10-09T23:38:10Z

@kadiealexander I've accepted the offer

lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Sep 25, 2024

melvin-bot bot assigned stitesExpensify Sep 25, 2024

github-actions bot added Engineering Hourly KSv2 labels Sep 25, 2024

github-actions bot mentioned this issue Sep 25, 2024

Deploy Checklist: New Expensify 2024-09-24 #49662

Closed

67 tasks

stitesExpensify added the External Added to denote the issue can be worked on by a contributor label Sep 25, 2024

melvin-bot bot changed the title ~~Save search - Default name in name field displays user/report ID instead of user/report name~~ [$250] Save search - Default name in name field displays user/report ID instead of user/report name Sep 25, 2024

stitesExpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 25, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 25, 2024

melvin-bot bot assigned rayane-djouah Sep 25, 2024

melvin-bot bot assigned kadiealexander Sep 25, 2024

melvin-bot bot mentioned this issue Sep 25, 2024

[$250] [Search v2.3] - Current name is not populated in the name field and it is not auto-focused #49207

Closed

6 tasks

stitesExpensify assigned Nodebrute Sep 25, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 25, 2024

Nodebrute mentioned this issue Sep 25, 2024

use title instead of item.name #49757

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Sep 25, 2024

github-actions bot mentioned this issue Sep 27, 2024

Deploy Checklist: New Expensify 2024-09-27 #49855

Closed

luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Sep 30, 2024

luacmartins changed the title ~~[$250] Save search - Default name in name field displays user/report ID instead of user/report name~~ [$250] [Search v2.3] - Default name in name field displays user/report ID instead of user/report name Sep 30, 2024

luacmartins added this to [#whatsnext] #expense Sep 30, 2024

luacmartins moved this to Polish in [#whatsnext] #expense Sep 30, 2024

luacmartins moved this from Polish to Done in [#whatsnext] #expense Sep 30, 2024

kadiealexander added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 7, 2024

kadiealexander changed the title ~~[$250] [Search v2.3] - Default name in name field displays user/report ID instead of user/report name~~ [HOLD for Payment 2024-10-04][$250] [Search v2.3] - Default name in name field displays user/report ID instead of user/report name Oct 7, 2024

This was referenced Oct 7, 2024

fix autofocus #49558

Merged

[CP Staging] Fix saved search names #49235

Merged

[Search v2.3] [App] Implement Saved Search feature #48566

Merged

melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels Oct 13, 2024

kadiealexander closed this as completed Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for Payment 2024-10-04][$250] [Search v2.3] - Default name in name field displays user/report ID instead of user/report name #49739

[HOLD for Payment 2024-10-04][$250] [Search v2.3] - Default name in name field displays user/report ID instead of user/report name #49739

lanitochka17 commented Sep 25, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

lanitochka17 commented Sep 25, 2024

Nodebrute commented Sep 25, 2024 •

edited by github-actions bot

Loading

daledah commented Sep 25, 2024 •

edited

Loading

Nodebrute commented Sep 25, 2024

neonbhai commented Sep 25, 2024 •

edited

Loading

melvin-bot bot commented Sep 25, 2024

melvin-bot bot commented Sep 25, 2024

melvin-bot bot commented Sep 25, 2024

rayane-djouah commented Sep 25, 2024

Nodebrute commented Sep 25, 2024

rayane-djouah commented Sep 25, 2024 •

edited

Loading

rayane-djouah commented Sep 25, 2024

melvin-bot bot commented Sep 25, 2024

melvin-bot bot commented Sep 25, 2024

Nodebrute commented Sep 25, 2024

stitesExpensify commented Sep 26, 2024

rayane-djouah commented Sep 28, 2024

luacmartins commented Sep 30, 2024

rayane-djouah commented Oct 2, 2024

kadiealexander commented Oct 7, 2024

kadiealexander commented Oct 7, 2024 •

edited

Loading

rayane-djouah commented Oct 7, 2024

luacmartins commented Oct 9, 2024 •

edited

Loading

rayane-djouah commented Oct 9, 2024

[HOLD for Payment 2024-10-04][$250] [Search v2.3] - Default name in name field displays user/report ID instead of user/report name #49739

[HOLD for Payment 2024-10-04][$250] [Search v2.3] - Default name in name field displays user/report ID instead of user/report name #49739

Comments

lanitochka17 commented Sep 25, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

lanitochka17 commented Sep 25, 2024

Nodebrute commented Sep 25, 2024 • edited by github-actions bot Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

daledah commented Sep 25, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Nodebrute commented Sep 25, 2024

neonbhai commented Sep 25, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

melvin-bot bot commented Sep 25, 2024

melvin-bot bot commented Sep 25, 2024

melvin-bot bot commented Sep 25, 2024

rayane-djouah commented Sep 25, 2024

Nodebrute commented Sep 25, 2024

rayane-djouah commented Sep 25, 2024 • edited Loading

rayane-djouah commented Sep 25, 2024

melvin-bot bot commented Sep 25, 2024

melvin-bot bot commented Sep 25, 2024

Nodebrute commented Sep 25, 2024

stitesExpensify commented Sep 26, 2024

rayane-djouah commented Sep 28, 2024

luacmartins commented Sep 30, 2024

rayane-djouah commented Oct 2, 2024

kadiealexander commented Oct 7, 2024

kadiealexander commented Oct 7, 2024 • edited Loading

rayane-djouah commented Oct 7, 2024

BugZero Checklist

luacmartins commented Oct 9, 2024 • edited Loading

rayane-djouah commented Oct 9, 2024

lanitochka17 commented Sep 25, 2024 •

edited by melvin-bot bot

Loading

Nodebrute commented Sep 25, 2024 •

edited by github-actions bot

Loading

daledah commented Sep 25, 2024 •

edited

Loading

neonbhai commented Sep 25, 2024 •

edited

Loading

rayane-djouah commented Sep 25, 2024 •

edited

Loading

kadiealexander commented Oct 7, 2024 •

edited

Loading

luacmartins commented Oct 9, 2024 •

edited

Loading