[$250] [HOLD for payment 2024-10-08] Don't apply failureData for "admin required" API responses

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1727300442697579

Action Performed:

1. User is a policy admin
2. User opens workspace settings
3. User goes offline
4. User changes a workspace setting
5. User is removed as a policy admin
6. User comes back online

Expected Result:

The API request to change the workspace setting is sent and returns a 460 status code, but we don't see a red dot.

Actual Result:

The API request to change the workspace setting is sent. It fails with a 4xx error code (requires admin). The user sees a 404 page (this part is expected), but the next time they open workspace settings they see a red dot next to the workspace that is not dismissible.

Workaround

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843762912418850228
• Upwork Job ID: 1843762912418850228
• Last Price Increase: 2024-10-08

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @greg-schroeder (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Current assignee @greg-schroeder is eligible for the Bug assigner, not assigning anyone new.

[roryabraham]

Marked internal because I have a PR already, just want a C+ reviewer

[greg-schroeder]

Internal label doesn't assign a C+: https://github.com/Expensify/Expensify/issues/405038

Asked for a volunteer in the C+ room: https://expensify.slack.com/archives/C02NK2DQWUX/p1727466386723609

[greg-schroeder]

Assigning @allgandalf as C+ reviewer for #49753 (comment)

[greg-schroeder]

NVM, it's @ishpaul777 ! Sike!

[greg-schroeder]

This is on staging. Awaiting deploy to prod

[greg-schroeder]

This was deployed 10/1 and automation failed. Regression period is 10/8 technically

[greg-schroeder]

@roryabraham what's the bounty for this one? Standard $250?

[roryabraham]

yep, thanks

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@greg-schroeder)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021843762912418850228

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[greg-schroeder]

Payment summary:

C+: @ishpaul777 - $250 - Paid via Upwork

[greg-schroeder]

Sent you an offer @ishpaul777 - I'll pay ya right away once you accept!

[ishpaul777]

thanks! accepted