[HOLD for payment 2024-11-29] [$250] Room - Create room whisper reappears when interacting with it after workspace is deleted #49940

lanitochka17 · 2024-09-30T15:00:01Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat
Send a mention of a non-existing room
Delete the workspace
Go to workspace chat
Click Yes on the whisper

Expected Result:

The whisper should be removed once the workspace is deleted

Actual Result:

The whisper is not removed after the workspace is deleted
When user selects Yes or No, the whisper disappears and reappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6619523_1727631494594.20240930_013404.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021840941316454719982
Upwork Job ID: 1840941316454719982
Last Price Increase: 2024-10-08
Automatic offers:

rayane-djouah | Reviewer | 104326547
Krishna2323 | Contributor | 104326549

Issue Owner

Current Issue Owner: @greg-schroeder

melvin-bot · 2024-09-30T15:00:13Z

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

nyomanjyotisa · 2024-09-30T15:17:26Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Create room whisper reappears when interacting with it after workspace is deleted

What is the root cause of that problem?

We still displaying the whisper action although the workspace is deleted or the report is archived

What changes do you think we should make in order to solve the problem?

Return false on shouldReportActionBeVisible if the report is archived and the report action is whisper action here

    if (isWhisperAction(reportAction) && ReportUtils.isArchivedRoom(report)) {
        return false;
    }

add report param to shouldReportActionBeVisible and make it nullable

Then pass the report here

App/src/pages/home/report/ReportActionsList.tsx

Line 197 in e84dab7

    
           ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID),

ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID, report),

What alternative solutions did you explore? (Optional)

Nomanahmeda789 · 2024-09-30T16:18:06Z

Proposal

Please re-state the problem that we are trying to solve in this issue.
Room - Create room whisper reappears when interacting with it after workspace is deleted

What is the root cause of that problem?
We still displaying the whisper action although the workspace is deleted or the report is archived

What changes do you think we should make in order to solve the problem?
Need to implement logic that can conditionally render the "Create room whisper" based on the workspace's existence. A simple check is need to added before rendering the whisper to check that the workspace is still valid like this:

if (!workspaceExists) return null;

Muhammad-Maraj-Khan · 2024-09-30T16:25:53Z

Somewhat agree with @Nomanahmeda789 solution.

huult · 2024-09-30T17:17:23Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Create room whisper reappears when interacting with it after workspace is deleted

What is the root cause of that problem?

Currently, we are still showing whispers even when the workspace is deleted.

App/src/pages/home/report/ReportActionsList.tsx

Lines 193 to 197 in 1d0fa64

    
           (isOffline || 
        
               ReportActionsUtils.isDeletedParentAction(reportAction) || 
        
               reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || 
        
               reportAction.errors) && 
        
           ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID),

What changes do you think we should make in order to solve the problem?

We should add logic to check if it's a whisper, and if the workspace is deleted, then it should not be shown. Some thing like that:

// .src/pages/home/report/ReportActionsList.tsx#L188
+    const isArchivedRoom = ReportUtils.isArchivedRoom(report, reportNameValuePairs);

// .src/pages/home/report/ReportActionsList.tsx#L197
reportAction.errors) && 
- ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID)
+ ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID) &&
+                    (reportAction.actionName !== 'ACTIONABLEREPORTMENTIONWHISPER' || !isArchivedRoom)

POC

Screen.Recording.2024-10-01.at.00.16.10.mp4

Krishna2323 · 2024-09-30T18:24:01Z

Edited by proposal-police: This proposal was edited at 2024-10-01 04:43:52 UTC.

Proposal 

Please re-state the problem that we are trying to solve in this issue.

Room - Create room whisper reappears when interacting with it after workspace is deleted

What is the root cause of that problem?

In shouldReportActionBeVisible, we are not checking whether the report is writeable, and we also don't check for this in ReportActionsList.

App/src/libs/ReportActionsUtils.ts

Lines 625 to 667 in a85cde8

    
           function shouldReportActionBeVisible(reportAction: OnyxEntry<ReportAction>, key: string | number): boolean { 
        
               if (!reportAction) { 
        
                   return false; 
        
               } 
        
               if (isReportActionDeprecated(reportAction, key)) { 
        
                   return false; 
        
               } 
        
               // Filter out any unsupported reportAction types 
        
               if (!supportedActionTypes.includes(reportAction.actionName)) { 
        
                   return false; 
        
               } 
        
               // Ignore closed action here since we're already displaying a footer that explains why the report was closed 
        
               if (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.CLOSED) { 
        
                   return false; 
        
               } 
        
               // Ignore markedAsReimbursed action here since we're already display message that explains the expense was paid 
        
               // elsewhere in the IOU reportAction 
        
               if (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.MARKED_REIMBURSED) { 
        
                   return false; 
        
               } 
        
               if (isWhisperActionTargetedToOthers(reportAction)) { 
        
                   return false; 
        
               } 
        
               if (isPendingRemove(reportAction) && !reportAction.childVisibleActionCount) { 
        
                   return false; 
        
               } 
        
               if (isTripPreview(reportAction)) { 
        
                   return true; 
        
               } 
        
               // All other actions are displayed except thread parents, deleted, or non-pending actions 
        
               const isDeleted = isDeletedAction(reportAction); 
        
               const isPending = !!reportAction.pendingAction; 
        
               return !isDeleted || isPending || isDeletedParentAction(reportAction) || isReversedTransaction(reportAction); 
        
           }

App/src/pages/home/report/ReportActionsList.tsx

Lines 189 to 200 in d589746

    
           const sortedVisibleReportActions = useMemo( 
        
               () => 
        
                   sortedReportActions.filter( 
        
                       (reportAction) => 
        
                           (isOffline || 
        
                               ReportActionsUtils.isDeletedParentAction(reportAction) || 
        
                               reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || 
        
                               reportAction.errors) && 
        
                           ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID), 
        
                   ), 
        
               [sortedReportActions, isOffline], 
        
           );

What changes do you think we should make in order to solve the problem? 

We have 2 solutions to solve this issue.

Add ReportUtils.canUserPerformWriteAction check in shouldReportActionBeVisible util function.
- For this we can pass the report to shouldReportActionBeVisible and then use canUserPerformWriteAction with the report and return false is !canUserPerformWriteAction is false. We also need to check if the action is a whisper or not and based on that we will return the boolean.

function shouldReportActionBeVisible(reportAction: OnyxEntry<ReportAction>, key: string | number,report): boolean {
    if ((isActionableMentionWhisper(reportAction) || isActionableTrackExpense(reportAction) || isActionableReportMentionWhisper(reportAction)) && !canUserPerformWriteAction(report)) {
        return false;
    }
    
    // We can also consider checking isActionableJoinRequest & isActionableJoinRequestPending

What alternative solutions did you explore? (Optional)

Alternatively we can move the hideComposer at the top level of the component and then use it here in the condition.

App/src/pages/home/report/ReportActionsList.tsx

Line 546 in d589746

const hideComposer = !ReportUtils.canUserPerformWriteAction(report);

Result

melvin-bot · 2024-10-01T02:26:29Z

Job added to Upwork: https://www.upwork.com/jobs/~021840941316454719982

melvin-bot · 2024-10-01T02:26:33Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

daledah · 2024-10-01T04:26:09Z

Edited by proposal-police: This proposal was edited at 2024-10-01 04:28:05 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The whisper is not removed after the workspace is deleted
When user selects Yes or No, the whisper disappears and reappears

What is the root cause of that problem?

When the report is deleted, we do not disable the actionable item button:

App/src/components/ReportActionItem/ActionableItemButtons.tsx

Line 28 in d589746

<Button

so user can click on it and BE returns an error to indicate that user doesn't have permission to perform the action.

What changes do you think we should make in order to solve the problem?

We should add isDisabled={item.isDisabled} to:

App/src/components/ReportActionItem/ActionableItemButtons.tsx

Line 28 in d589746

<Button

And for each element in:

App/src/pages/home/report/ReportActionItem.tsx

Line 469 in d589746

return [

return isDisabled: ReportUtils.isArchivedRoomWithID(report?.reportID) or can use isDisabled: !ReportUtils.canUserPerformWriteAction(report) instead

daledah · 2024-10-01T04:28:19Z

Proposal updated

daledah · 2024-10-01T04:33:36Z

@greg-schroeder Can you confirm the expected behavior here. When the report is archived, we should:

Hide the whisper message.
Still displays the whisper message but disables the "Yes/No" buttons.

Krishna2323 · 2024-10-01T04:49:09Z

Proposal Updated

Updated main solution

greg-schroeder · 2024-10-01T19:01:34Z

Discussing this with the team

greg-schroeder · 2024-10-02T00:37:04Z

@daledah I think in this case, it makes the most sense to just hide the whisper.

Reasoning: The whisper is there to help the user take action that we think they might want to take. Since the chat is no longer active, and no action can be taken, we probably don't need to show them a message that is trying to help them take an action that's no longer possible.

h/t @dannymcclain for articulating this reasoning better than I could ☝️

melvin-bot · 2024-10-04T18:16:20Z

@greg-schroeder, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

rayane-djouah · 2024-10-04T18:25:17Z

Thanks for clarifying the expected result!

melvin-bot · 2024-10-07T18:38:10Z

@greg-schroeder, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

rayane-djouah · 2024-10-07T21:51:07Z

@Krishna2323's proposal looks good to me.

I agree that the most appropriate check is ReportUtils.canUserPerformWriteAction, as we're doing in similar areas of the codebase (example: PR #46560). in addition to isActionableReportMentionWhisper(reportAction).

Note: I think it's better to pass a canUserPerformWriteAction boolean flag to shouldReportActionBeVisible instead of the report object.

Additionally, I appreciate that the proposal suggests addressing the bug with the actionable join request whisper action and other whispers, even though they are not within the scope of this issue

The check can be structured as follows:
(isActionableReportMentionWhisper(reportAction) || isActionableJoinRequestPending(reportAction)) && !canUserPerformWriteAction

Since self DMs cannot be archived, using isActionableTrackExpense(reportAction) is unnecessary (this can be confirmed by the assigned internal engineer).

Moreover, my testing confirms that we can still invite users from an actionable mention whisper to the report, so including isActionableMentionWhisper(reportAction) is not required. If this behavior isn't expected, we can reintroduce isActionableMentionWhisper(reportAction) and adjust the backend to prohibit the action (pending confirmation from the assigned internal engineer).

Based on my tests, the backend doesn't permit interactions with the actionable whisper for ActionableReportMentionWhisper (as reported in this issue) and ActionableJoinRequestPending. Screenshots:

ActionableJoinRequestPending:

ActionableReportMentionWhisper:

Here is a screen recording of the tests:

Screen.Recording.2024-10-07.at.10.06.39.PM.mov

🎀👀🎀 C+ reviewed

greg-schroeder · 2024-11-01T20:34:59Z

Same as above

melvin-bot · 2024-11-05T18:25:46Z

This issue has not been updated in over 15 days. @tgolen, @greg-schroeder, @rayane-djouah, @Krishna2323 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

rayane-djouah · 2024-11-05T19:42:04Z

Update: @Krishna2323 is addressing PR review comments #50692 (comment)

greg-schroeder · 2024-11-11T20:23:23Z

Work on PR continues

greg-schroeder · 2024-11-15T08:54:56Z

Changes requested on PR, still underway

greg-schroeder · 2024-11-20T21:48:51Z

Merged. Awaiting deploy to staging -> prod

melvin-bot · 2024-11-21T09:09:14Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot · 2024-11-21T14:23:50Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot · 2024-11-22T09:07:48Z

@tgolen, @greg-schroeder, @rayane-djouah, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

rayane-djouah · 2024-11-22T09:44:22Z

PR on staging. @Krishna2323 and I addressed the above bugs in a follow up PR

melvin-bot · 2024-11-22T19:53:28Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-11-22T19:53:33Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Room - Create room whisper reappears when interacting with it after workspace is deleted. #50692

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

@rayane-djouah requires payment automatic offer (Reviewer)
@Krishna2323 requires payment automatic offer (Contributor)

melvin-bot · 2024-11-22T19:53:34Z

@rayane-djouah @greg-schroeder @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-djouah · 2024-11-23T12:35:28Z

BugZero Checklist:

Regression Test Proposal

#### Precondition:

- A workspace has been created.

#### Test:

1. Navigate to the Workspace Chat.
2. Send a mention of a non-existing room.
3. Verify that an actionable whisper for the room mention is displayed.
4. Navigate to Settings > Workspaces.
5. Delete the workspace.
6. Return to the Workspace Chat.
7. Verify that the actionable whisper is no longer displayed.

Do we agree 👍 or 👎

greg-schroeder · 2024-12-01T20:38:09Z

Paid contracts via Upwork, filed regression issue

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 30, 2024

melvin-bot bot assigned greg-schroeder Sep 30, 2024

greg-schroeder added this to [#whatsnext] #wave-collect Oct 1, 2024

greg-schroeder added the External Added to denote the issue can be worked on by a contributor label Oct 1, 2024

melvin-bot bot changed the title ~~Room - Create room whisper reappears when interacting with it after workspace is deleted~~ [$250] Room - Create room whisper reappears when interacting with it after workspace is deleted Oct 1, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 1, 2024

melvin-bot bot assigned rayane-djouah Oct 1, 2024

melvin-bot bot added the Overdue label Oct 4, 2024

melvin-bot bot removed the Overdue label Oct 4, 2024

melvin-bot bot added the Overdue label Oct 7, 2024

melvin-bot bot removed the Overdue label Oct 7, 2024

melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Nov 5, 2024

greg-schroeder added Weekly KSv2 and removed Monthly KSv2 labels Nov 11, 2024

greg-schroeder added Daily KSv2 and removed Weekly KSv2 labels Nov 15, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Nov 22, 2024

melvin-bot bot changed the title ~~[$250] Room - Create room whisper reappears when interacting with it after workspace is deleted~~ [HOLD for payment 2024-11-29] [$250] Room - Create room whisper reappears when interacting with it after workspace is deleted Nov 22, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Nov 22, 2024

rayane-djouah mentioned this issue Nov 23, 2024

[Feat] Implement room mention actionable whisper #41406

Merged

50 tasks

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 29, 2024

greg-schroeder closed this as completed Dec 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-11-29] [$250] Room - Create room whisper reappears when interacting with it after workspace is deleted #49940

[HOLD for payment 2024-11-29] [$250] Room - Create room whisper reappears when interacting with it after workspace is deleted #49940

lanitochka17 commented Sep 30, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 30, 2024

nyomanjyotisa commented Sep 30, 2024

Nomanahmeda789 commented Sep 30, 2024

Muhammad-Maraj-Khan commented Sep 30, 2024

huult commented Sep 30, 2024

Krishna2323 commented Sep 30, 2024 •

edited

Loading

melvin-bot bot commented Oct 1, 2024

melvin-bot bot commented Oct 1, 2024

daledah commented Oct 1, 2024 •

edited by github-actions bot

Loading

daledah commented Oct 1, 2024

daledah commented Oct 1, 2024

Krishna2323 commented Oct 1, 2024

greg-schroeder commented Oct 1, 2024

greg-schroeder commented Oct 2, 2024 •

edited

Loading

melvin-bot bot commented Oct 4, 2024

rayane-djouah commented Oct 4, 2024

melvin-bot bot commented Oct 7, 2024

rayane-djouah commented Oct 7, 2024

greg-schroeder commented Nov 1, 2024

melvin-bot bot commented Nov 5, 2024

rayane-djouah commented Nov 5, 2024 •

edited

Loading

greg-schroeder commented Nov 11, 2024

greg-schroeder commented Nov 15, 2024

greg-schroeder commented Nov 20, 2024

melvin-bot bot commented Nov 21, 2024

melvin-bot bot commented Nov 21, 2024

melvin-bot bot commented Nov 22, 2024

rayane-djouah commented Nov 22, 2024

melvin-bot bot commented Nov 22, 2024

melvin-bot bot commented Nov 22, 2024

melvin-bot bot commented Nov 22, 2024

rayane-djouah commented Nov 23, 2024

greg-schroeder commented Dec 1, 2024

[HOLD for payment 2024-11-29] [$250] Room - Create room whisper reappears when interacting with it after workspace is deleted #49940

[HOLD for payment 2024-11-29] [$250] Room - Create room whisper reappears when interacting with it after workspace is deleted #49940

Comments

lanitochka17 commented Sep 30, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Sep 30, 2024

nyomanjyotisa commented Sep 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Nomanahmeda789 commented Sep 30, 2024

Proposal

Muhammad-Maraj-Khan commented Sep 30, 2024

huult commented Sep 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Krishna2323 commented Sep 30, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

melvin-bot bot commented Oct 1, 2024

melvin-bot bot commented Oct 1, 2024

daledah commented Oct 1, 2024 • edited by github-actions bot Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

daledah commented Oct 1, 2024

Proposal updated

daledah commented Oct 1, 2024

Krishna2323 commented Oct 1, 2024

Proposal Updated

greg-schroeder commented Oct 1, 2024

greg-schroeder commented Oct 2, 2024 • edited Loading

melvin-bot bot commented Oct 4, 2024

rayane-djouah commented Oct 4, 2024

melvin-bot bot commented Oct 7, 2024

rayane-djouah commented Oct 7, 2024

greg-schroeder commented Nov 1, 2024

melvin-bot bot commented Nov 5, 2024

rayane-djouah commented Nov 5, 2024 • edited Loading

greg-schroeder commented Nov 11, 2024

greg-schroeder commented Nov 15, 2024

greg-schroeder commented Nov 20, 2024

melvin-bot bot commented Nov 21, 2024

melvin-bot bot commented Nov 21, 2024

melvin-bot bot commented Nov 22, 2024

rayane-djouah commented Nov 22, 2024

melvin-bot bot commented Nov 22, 2024

melvin-bot bot commented Nov 22, 2024

melvin-bot bot commented Nov 22, 2024

rayane-djouah commented Nov 23, 2024

BugZero Checklist:

Regression Test Proposal

greg-schroeder commented Dec 1, 2024

lanitochka17 commented Sep 30, 2024 •

edited by melvin-bot bot

Loading

Krishna2323 commented Sep 30, 2024 •

edited

Loading

Proposal 

What changes do you think we should make in order to solve the problem? 

daledah commented Oct 1, 2024 •

edited by github-actions bot

Loading

greg-schroeder commented Oct 2, 2024 •

edited

Loading

rayane-djouah commented Nov 5, 2024 •

edited

Loading