[HELD on 49802] [$250] Workspaces - 3 dot menu is shown above the preferences dialog window

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Login to an account
2. Go to workspace > click on the 3 dot menu
3. Press cmd + D

Expected Result:

3 dot menu is dismissed and the preferences dialog window is shown

Actual Result:

3 dot menu is shown on top of the preferences dialog window.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6618566_1727537916046.Screen_Recording_2024-09-26_at_1.08.28_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841087840397368741
• Upwork Job ID: 1841087840397368741
• Last Price Increase: 2024-11-05

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[daledah]

Edited by proposal-police: This proposal was edited at 2024-10-01 09:28:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

3 dot menu is shown on top of the preferences dialog window.

What is the root cause of that problem?

Currently we pass props shouldOverlay = true to set the popover menu overlay the current view

App/src/pages/workspace/WorkspacesListRow.tsx

Line 173 in 76c5c81

shouldOverlay

What changes do you think we should make in order to solve the problem?

We should remove props shouldOverlay here

and we should consider other places where props shouldOverlay = true is used

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021841087840397368741

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

@daledah Can you please add more details to the proposal on why the root cause? do some analysis on why it was added?

[bernhardoj]

Looks like my proposal here will solve this issue too.

[parasharrajat]

Awesome, I was looking for something like that. @bernhardoj Can you please post the proposal here and tune it for the issue?

[daledah]

@parasharrajat we are calculated isBehindModal base on shouldOverlay here

App/src/components/ThreeDotsMenu/index.tsx

Line 40 in c7ee85b

const isBehindModal = modal?.willAlertModalBecomeVisible && !modal?.isPopover && !shouldOverlay;

we need to do that because we have some cases where popover is above a modal like three dots in Attachment Modal

do some analysis on why it was added?

this is added in this PR and I think this maybe a mistake because we have some three dots in workspace like Tag, Category... that all set shouldOverlay = false

[bernhardoj]

I think we can work on #49802 since I also propose another thing to improve the debug modal.

[parasharrajat]

This issue will be fixed in #49802. So let's hold it on that @bfitzexpensify

[melvin-bot]

@parasharrajat, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@parasharrajat @bfitzexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[bfitzexpensify]

Still held

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[parasharrajat]

PR will be merged soon.

[bfitzexpensify]

#51659 in review

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@parasharrajat @bfitzexpensify this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[parasharrajat]

this is solved, we can close it now.