[HOLD for payment 2024-12-20] [$250] mWeb - Submit expense- "Hmm it's not here" message gets visible when deleting vague distance Expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.41-10
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go Offline
2. Global Create > Submit expense
3. Select Distance option
4. Disable the internet connection
5. Enter a vague start location, random characters
6. Enter a vague finish location, random characters
7. Finish the submit creation flow
8. Enable the internet connection
9. Click on the close icon of error message displayed

Expected Result:

Delete the vague distance expense without problem

Actual Result:

"Hmm it's not here" message gets visible for a second before deleting the expense

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6621450_1727809746483.Mweb_Hmm_page_before_deleting_vague_location_distance_expense.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021847129435512475314
• Upwork Job ID: 1847129435512475314
• Last Price Increase: 2024-10-25
• Automatic offers:
• rayane-djouah | Reviewer | 104681071
• truph01 | Contributor | 104681072

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[truph01]

Edited by proposal-police: This proposal was edited at 2024-10-18 04:23:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Hmm it's not here" message gets visible for a second before deleting the expense

What is the root cause of that problem?

• We clear the report data and go back in:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 496 to 497 in ea48de3

	const urlToNavigateBack = IOU.cleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
	Navigation.goBack(urlToNavigateBack);

• When the go-back action is not finished, and the onyx data is updated successfully, the "Hmm its not here" screen is displayed for a while.

What changes do you think we should make in order to solve the problem?

• Remove the code:

App/src/pages/home/ReportScreen.tsx

Line 272 in c3d33fc

wasReportAccessibleRef.current = false;

will fix the issue because if the report is visited before, there is no not here page is displayed anymore.

What alternative solutions did you explore? (Optional)

• We should go back successfully and then clear the report data.

• We can do it by:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 496 to 497 in ea48de3

	const urlToNavigateBack = IOU.cleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
	Navigation.goBack(urlToNavigateBack);

                            const {urlToNavigateBack} = IOU.prepareToCleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
                            Navigation.goBack(urlToNavigateBack);
                            InteractionManager.runAfterInteractions(() => {
                                IOU.cleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
                            });

[alexpensify]

Adding this one to my test list and will get to it later this week.

[alexpensify]

No update yet

[melvin-bot]

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alexpensify]

Still on my testing list

[alexpensify]

No update

[melvin-bot]

@alexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021847129435512475314

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[alexpensify]

@rayane-djouah - can you please identify if this proposal will fix this issue? Thanks!

Heads up, I will be offline until Tuesday, October 22, 2024, and will not actively watch over this GitHub during that period.

If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.

[rayane-djouah]

👀

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[truph01]

PR is ready

[alexpensify]

Update: PR is in review!

[alexpensify]

Update: same as last week

[melvin-bot]

This issue has not been updated in over 15 days. @flodnv, @alexpensify, @rayane-djouah, @truph01 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[alexpensify]

Update: PR is moving but under review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: loading indicator display when deleting vague distance Expense #51940

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment automatic offer (Reviewer)
• @truph01 requires payment automatic offer (Contributor)

[melvin-bot]

@rayane-djouah @alexpensify @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[rayane-djouah]

BugZero Checklist:

• Classify the bug:

  Bug classification

  Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

  Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on a PR
  • 2z. Other:

  Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/44142/files#r1884443881

• If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [@alexpensify] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

#### Precondition:

- Account has a workspace

#### Test:

1. Click on Global Create > 'Submit Expense'.
2. Select the 'Distance' option.
3. Disable the internet connection.
4. Enter a vague start location using random characters.
5. Enter a vague end location using random characters.
6. Complete the expense submission flow.
7. Enable the internet connection.
8. Open the distance expense report.
9. Click on the close icon of the displayed error message.
10. Verify that the app navigates back to the workspace IOU report without displaying any intermediate screens such as a loading screen or a "Hmm it's not here".
11. Verify that the vague distance expense is deleted.

Do we agree 👍 or 👎

[alexpensify]

Contributor: @truph01 $250 via Upwork
Contributor+: @rayane-djouah $250 via Upwork

---

Everyone has been paid. I'll work on the test next week.