[$125] Tag - Error occurs when trying to add a tag named "some"

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.42-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Create a workspace.
3. Navigate to Workspace settings > more features > enable tags.
4. Go to tags.
5. Click on add tag.
6. Name the tag "some" and try to save it. (ensure to write it in lowercase.)

Expected Result:

The tag named "some" should be successfully created and saved without any issues.

Actual Result:

The system returns an error stating 'A tag with this name already exists' even though no tag named 'some' is present, which might indicate a system error.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6621111_1727789514419.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841480841839544675
• Upwork Job ID: 1841480841839544675
• Last Price Increase: 2024-10-02

Issue Owner

Current Issue Owner: @yuwenmemon

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-10-01 20:48:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error occurs when trying to add a tag named "some"

What is the root cause of that problem?

We are getting are tags list from here and when it's empty we are returning an array but tags list is supposed to be an {}.When we have values in tags list it becomes an object that's why we don't see this error while editing tag

App/src/libs/PolicyUtils.ts

Lines 292 to 295 in cba1457

	function getTagLists(policyTagList: OnyxEntry<PolicyTagLists>): Array<ValueOf<PolicyTagLists>> {
	if (isEmptyObject(policyTagList)) {
	return [];
	}

And here when it's an empty array we are using an incorrect method to check

App/src/pages/workspace/tags/WorkspaceCreateTagPage.tsx

Line 50 in def32f4

} else if (tags?.[tagName]) {

What changes do you think we should make in order to solve the problem?

We can return {} here instead of an empty []

App/src/libs/PolicyUtils.ts

Lines 292 to 295 in cba1457

	function getTagLists(policyTagList: OnyxEntry<PolicyTagLists>): Array<ValueOf<PolicyTagLists>> {
	if (isEmptyObject(policyTagList)) {
	return [];
	}

We should also check for other places where we have this issue and fix it. We should also fix type errors that comes from this change.

What alternative solutions did you explore? (Optional)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The system returns an error stating 'A tag with this name already exists' even though no tag named 'some' is present, which might indicate a system error.

What is the root cause of that problem?

In

App/src/pages/workspace/tags/WorkspaceCreateTagPage.tsx

Lines 50 to 51 in cba1457

	} else if (tags?.[tagName]) {
	errors.tagName = translate('workspace.tags.existingTagError');

We check if tags has property tagName to determine if the created tag already exist.

However, when we create a new workspace, the tags object is an array:

it will only be updated to an object when a tag is created.

And some is a property of a Javascript's array object, which leads to tags?.[tagName] exists, make the error appears.
The same bug can happen with other array properties aswell, such as every, forEach, etc.

What changes do you think we should make in order to solve the problem?

1. We can fix this from the BE side so the returned Tag is always an object
2. We can change the logic to handle array:

Update

App/src/pages/workspace/tags/WorkspaceCreateTagPage.tsx

Line 50 in cba1457

} else if (tags?.[tagName]) {

to

else if (!Array.isArray(tags) && tags?.[tagName]) {

or

else if (Object.prototype.hasOwnProperty.call(tags, tagName)){

What alternative solutions did you explore? (Optional)

NA

[twisterdotcom]

What a weird bug. Easy to recreate.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021841480841839544675

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

Upwork job price has been updated to $125

[Nodebrute]

I believe this may be a backend issue. The tags are supposed to be {} on the frontend, and we have set them correctly. However, when we create a workspace, the tags are being set to [] instead. I think the backend should ensure that the tags are set to {}.

App/src/libs/actions/Policy/Tag.ts

Line 639 in 3946b22

tags: {},

App/src/libs/PolicyUtils.ts

Line 311 in 3946b22

tags: {},

cc: @allroundexperts @twisterdotcom

[sher999]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error occurs when trying to add a tag named "some"

What is the root cause of that problem?

checking on empty array is returning [Function some]

App/src/pages/workspace/tags/WorkspaceCreateTagPage.tsx

Line 50 in 1ed31aa

} else if (tags?.[tagName]) {

What changes do you think we should make in order to solve the problem?

Check the lenght of the tags array if it is empty js will return false and skip the "else if" condition

 } else if (tags?.[tagName] && tags.length) { 

Checked on staging

ios native

Screen.Recording.2024-10-03.at.2.32.19.AM.mov

What alternative solutions did you explore? (Optional)

[allroundexperts]

@twisterdotcom I think that a backend fix would be better. Can you please pull someone from the internal team to take a look? TY!

[twisterdotcom]

cc @yuwenmemon can you do this?

[yuwenmemon]

Lolwut this is odd

[twisterdotcom]

Open source finds only the best bugs.

[melvin-bot]

@twisterdotcom, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[twisterdotcom]

I don't think we need @allroundexperts here.

[yuwenmemon]

Correct. This should be merged by @mountiny later today hopefully.

[mountiny]

merged

[melvin-bot]

@yuwenmemon, @twisterdotcom Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[twisterdotcom]

This has been on prod for a few days.