-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Track expense - "Just track it" is present from actionable whisper options which causes error #50048
Comments
Triggered auto assignment to @isabelastisser ( |
Triggered auto assignment to @mjasikowski ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Edited by proposal-police: This proposal was edited at 2024-10-02 11:27:10 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.In Step 5, the option "Just track it (don’t submit it)" is present when submitting track expense to someone. What is the root cause of that problem?We are only not showing this option if the
What changes do you think we should make in order to solve the problem?We should add the check
What alternative solutions did you explore? (Optional) |
Regression from #49007 |
Confirmed to be under |
Assigning @fedirjh as the original C+ |
I can take this one @mjasikowski Offending line is here - We can first this with this PR to prevent ever showing the button to anyone not on the beta #50068 But we should really have @fabioh8010 take this as a follow up to prevent showing it if you don't click to this screen from the create menu |
Update, I fixed it in my PR, I'll add @fabioh8010 as a reviewer |
Reviewed from my side and approved! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-11. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-14. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary
BugZero Checklist (@isabelastisser)
|
@isabelastisser, @fedirjh, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I was OOO yesterday. I will review this today! |
I believe the payment summary above is incorrect. I see that @grgia assigned @fabioh8010 to review the PR, so payment should be made to @fabioh8010 only. @grgia @fabioh8010, please confirm before I can make the payment. Thanks! |
@isabelastisser I'm a contractor from an expert agency (Callstack), so no payment is required 🙂 |
Got it, thanks! We are all set then. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+sd34@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
In Step 5, the option "Just track it (don’t submit it)" should not be present when submitting track expense to someone.
Actual Result:
In Step 5, the option "Just track it (don’t submit it)" is present when submitting track expense to someone.
When selecting the option, it ends up tracking the expense again to self DM and this leads to infinite loading and RBR in LHN.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6622007_1727865495696.track_again.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @isabelastisserThe text was updated successfully, but these errors were encountered: