Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Track expense - "Just track it" is present from actionable whisper options which causes error #50048

Closed
6 tasks done
IuliiaHerets opened this issue Oct 2, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+sd34@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Track a manual expense.
  4. Click Submit it to someone from the actionable whisper.
  5. Click Just track it (don’t submit it).
  6. Click Track expense.

Expected Result:

In Step 5, the option "Just track it (don’t submit it)" should not be present when submitting track expense to someone.

Actual Result:

In Step 5, the option "Just track it (don’t submit it)" is present when submitting track expense to someone.
When selecting the option, it ends up tracking the expense again to self DM and this leads to infinite loading and RBR in LHN.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6622007_1727865495696.track_again.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @isabelastisser
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Oct 2, 2024
Copy link

melvin-bot bot commented Oct 2, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 2, 2024
Copy link

melvin-bot bot commented Oct 2, 2024

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nkdengineer
Copy link
Contributor

nkdengineer commented Oct 2, 2024

Edited by proposal-police: This proposal was edited at 2024-10-02 11:27:10 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 5, the option "Just track it (don’t submit it)" is present when submitting track expense to someone.
When selecting the option, it ends up tracking the expense again to self DM and this leads to infinite loading and RBR in LHN.

What is the root cause of that problem?

We are only not showing this option if the selfDMReportID is empty

const shouldDisplayTrackExpenseButton = !!selfDMReportID;

What changes do you think we should make in order to solve the problem?

We should add the check IOUUtils.isMovingTransactionFromTrackExpense to prevent showing this option if we're moving transaction from track expense

const shouldDisplayTrackExpenseButton = !!selfDMReportID && !IOUUtils.isMovingTransactionFromTrackExpense(action);

const shouldDisplayTrackExpenseButton = !!selfDMReportID;

What alternative solutions did you explore? (Optional)

@nkdengineer
Copy link
Contributor

Regression from #49007

@mjasikowski
Copy link
Contributor

Confirmed to be under combinedTrackSubmit beta, therefore not blocking

@mjasikowski mjasikowski added Weekly KSv2 Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 Weekly KSv2 labels Oct 2, 2024
@mjasikowski
Copy link
Contributor

Assigning @fedirjh as the original C+
@fabioh8010 can you leave a comment here so I can assign this issue to you as well?

@grgia
Copy link
Contributor

grgia commented Oct 2, 2024

I can take this one @mjasikowski

Offending line is here -
https://github.com/Expensify/App/blob/main/src/pages/iou/request/step/IOURequestStepParticipants.tsx#L79

We can first this with this PR to prevent ever showing the button to anyone not on the beta #50068

But we should really have @fabioh8010 take this as a follow up to prevent showing it if you don't click to this screen from the create menu

@grgia
Copy link
Contributor

grgia commented Oct 2, 2024

Update, I fixed it in my PR, I'll add @fabioh8010 as a reviewer

@fabioh8010
Copy link
Contributor

Reviewed from my side and approved!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 4, 2024
@melvin-bot melvin-bot bot changed the title Track expense - "Just track it" is present from actionable whisper options which causes error [HOLD for payment 2024-10-11] Track expense - "Just track it" is present from actionable whisper options which causes error Oct 4, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 4, 2024
Copy link

melvin-bot bot commented Oct 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

  • @fedirjh requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Oct 4, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
  • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@fedirjh] Determine if we should create a regression test for this bug.
  • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 7, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-10-11] Track expense - "Just track it" is present from actionable whisper options which causes error [HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Track expense - "Just track it" is present from actionable whisper options which causes error Oct 7, 2024
Copy link

melvin-bot bot commented Oct 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

  • @fedirjh requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Oct 7, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
  • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@fedirjh] Determine if we should create a regression test for this bug.
  • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 11, 2024
Copy link

melvin-bot bot commented Oct 14, 2024

Payment Summary

Upwork Job

  • Reviewer: @fedirjh owed $250 via NewDot

BugZero Checklist (@isabelastisser)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

Copy link

melvin-bot bot commented Oct 14, 2024

@isabelastisser, @fedirjh, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

@isabelastisser
Copy link
Contributor

I was OOO yesterday. I will review this today!

@melvin-bot melvin-bot bot removed the Overdue label Oct 15, 2024
@isabelastisser
Copy link
Contributor

I believe the payment summary above is incorrect. I see that @grgia assigned @fabioh8010 to review the PR, so payment should be made to @fabioh8010 only.

@grgia @fabioh8010, please confirm before I can make the payment. Thanks!

@fabioh8010
Copy link
Contributor

@isabelastisser I'm a contractor from an expert agency (Callstack), so no payment is required 🙂

@isabelastisser
Copy link
Contributor

Got it, thanks! We are all set then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants