Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - group - In group chat, creating split expense shows unexpected error #50091

Closed
1 of 6 tasks
lanitochka17 opened this issue Oct 2, 2024 · 6 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app (use gmail account)
  2. Create a group chat with 2 users
  3. Create a manual split expense

Expected Result:

In group chat, creating split expense must not show unexpected error

Actual Result:

As gmail user, in group chat, creating split expense shows unexpected error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6622291_1727886089341.Pp.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 2, 2024
Copy link

melvin-bot bot commented Oct 2, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@melvin-bot melvin-bot bot added the Overdue label Oct 4, 2024
Copy link

melvin-bot bot commented Oct 7, 2024

@trjExpensify Huh... This is 4 days overdue. Who can take care of this?

@trjExpensify
Copy link
Contributor

trjExpensify commented Oct 8, 2024

@lanitochka17 in these cases, it's super helpful to have the email address of the tester and an indication of the time/date when it happened to narrow the search. I've found it, but it took me longer than necessary if I had those details.

Participants for reference:

image
Throw ExpException - 59714ae343639b41a22589f6b07edad1 ~~ message: '400 Invalid participant in split JSON' exceptionMessage: 'Auth CreateIOUSplit returned an error' exceptionFile: '/git/releases/expensify.com/8036ef0/lib/Auth.php' exceptionLine: '132' exceptionCode: '400'

RequestID

...which looks like it's throwing here.

.. looking at the SplitBill command request, it seems like we might have an empty email for accountID 14909571.

Processing 'SplitBill' for 'expensify.com' from '49.37.221.212' ~~ initialReferer: '<REDACTED>' browserGUID: '66fd6e11351ac' command: 'SplitBill' reportID: '1586659735003557' amount: '87797900' splits: '[{"email":"[email protected]","accountID":18418840,"amount":29265966,"taxAmount":0},{"email":"","accountID":14909571,"isOptimisticAccount":false,"amount":29265967,"iouReportID":"6052722910679159","chatReportID":"1368027836275448","transactionID":"7447705160371163702","reportActionID":"5478681928244891158","createdChatReportActionID":"4179653200119164763","createdIOUReportActionID":"4779679985590943370","reportPreviewReportActionID":"8388445612708174433","transactionThreadReportID":"4177248923736814","createdReportActionIDForThread":"5697035918013480567","taxAmount":0},{"email":"[email protected]","accountID":15075387,"isOptimisticAccount":false,"amount":29265967,"iouReportID":"1764700554582682","chatReportID":"6571789036668188","transactionID":"5351388876721267404","reportActionID":"4447484852141798124","createdChatReportActionID":"4585901085599248401","createdIOUReportActionID":"1052459271737372515","reportPreviewReportActionID":"1246776162341504802","transactionThreadReportID":"8595370910338935","createdReportActionIDForThread":"2042612708939164669","taxAmount":0}]' currency: 'INR' comment: '' category: '' merchant: '(none)' created: '2024-10-02' tag: '' billable: 'false' transactionID: '3783263752286064644' reportActionID: '2538530263361927211' chatType: 'group' taxCode: '' taxAmount: '0' pusherSocketID: '776705.10521043' authToken: '<REDACTED>' referer: 'ecash' platform: 'android' api_setCookie: 'false' email: '[email protected]' isFromDevEnv: 'false' appversion: '9.0.43-1' clientUpdateID: '2194246977' partnerName: 'expensify.com' HTTP_CF_BOT_SCORE: '99' HTTP_CF_JA3_HASH: 'f79b6bad2ad0641e1921aef10262856b'

Pulling those out of the above for ease of viewing:

{"email":"[email protected]","accountID":18418840,"`
`{"email":"","accountID":14909571,"`
`{"email":"[email protected]","accountID":15075387

As for the why? I'm not sure. @youssef-lr might know.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 8, 2024
@trjExpensify
Copy link
Contributor

Awaiting input from, @youssef-lr.

@melvin-bot melvin-bot bot removed the Overdue label Oct 11, 2024
@youssef-lr
Copy link
Contributor

Dupe of #30140, should be fixed once account creation is moved to Auth, cc @neil-marcellini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants