[HOLD for payment 2024-11-21] Can't clear the free trial expired message from Concierge

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @zsgreenwald
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727985469399619

Action Performed:

Precondition: Payment card is added to the account

1. Login to an account which has free trial left
2. observe the LHN has "free trial expired" message

Expected Result:

Free trial expired message should not appear if the free trial is left and payment card added to the account

Actual Result:

Unable discard the "free trial expired" message from the LHN

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

CleanShot.2024-10-03.at.12.47.12.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841979108635835758
• Upwork Job ID: 1841979108635835758
• Last Price Increase: 2024-10-03

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2024-10-03 22:19:26 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can't clear the free trial expired message from Concierge

What is the root cause of that problem?

the free trial expired action is shown if !SubscriptionUtils.doesUserHavePaymentCardAdded()

App/src/pages/settings/Subscription/CardSection/BillingBanner/TrialEndedBillingBanner.tsx

Lines 10 to 20 in 9ebd971

	if (SubscriptionUtils.doesUserHavePaymentCardAdded()) {
	return null;
	}
	return (
	<BillingBanner
	title={translate('subscription.billingBanner.trialEnded.title')}
	subtitle={translate('subscription.billingBanner.trialEnded.subtitle')}
	icon={Illustrations.Tire}
	/>
	);

App/src/libs/SubscriptionUtils.ts

Lines 427 to 432 in bee4bec

	/**
	* Whether the user has a payment card added to its account.
	*/
	function doesUserHavePaymentCardAdded(): boolean {
	return userBillingFundID !== undefined;
	}

The issue seems to be that the ONYXKEYS.NVP_BILLING_FUND_ID key is not being updated by the backend, causing it to remain null.

What changes do you think we should make in order to solve the problem?

1. we can either fix that in the backend
2. or we can use getCardForSubscriptionBilling instead of doesUserHavePaymentCardAdded, which uses the ONYXKEYS.FUND_LIST key instead

    if (SubscriptionUtils.getCardForSubscriptionBilling()) {
        return null;
    }

3. this change should be done here as well where we should add the following condition if (ReportActionsUtils.isActionableAddPaymentCard(action) && shouldRenderAddPaymentCard() && !SubscriptionUtils.getCardForSubscriptionBilling())

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021841979108635835758

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[mallenexpensify]

Removed Help Wanted for a min. @thesahindia , can you review @abzokhattab 's proposal above? Mainly curious if you think this likely needs to be worked on on the backend. Thx

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-10-03 23:58:27 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable discard the "free trial expired" message from the LHN

What is the root cause of that problem?

• The actionable add payment card message are returning from BE, and the "Add payment card" button is always displayed:

App/src/pages/home/report/ReportActionItem.tsx

Lines 400 to 412 in 637b607

	if (ReportActionsUtils.isActionableAddPaymentCard(action) && shouldRenderAddPaymentCard()) {
	return [
	{
	text: 'subscription.cardSection.addCardButton',
	key: `${action.reportActionID}-actionableAddPaymentCard-submit`,
	onPress: () => {
	Navigation.navigate(ROUTES.SETTINGS_SUBSCRIPTION_ADD_PAYMENT_CARD);
	},
	isMediumSized: true,
	isPrimary: true,
	},
	];
	}

As we can see, we don't have a logic to hide that message if there is a payment card.

What changes do you think we should make in order to solve the problem?

• We should hide or disable the "Add payment card" button if user has already added any payment card. So:

App/src/pages/home/report/ReportActionItem.tsx

Line 400 in 637b607

if (ReportActionsUtils.isActionableAddPaymentCard(action) && shouldRenderAddPaymentCard()) {

can be:

        if (ReportActionsUtils.isActionableAddPaymentCard(action) && shouldRenderAddPaymentCard() && !hasPaymentCard) {

• hasPaymentCard can be obtained from a few utils:

1. SubscriptionUtils.doesUserHavePaymentCardAdded()

2. SubscriptionUtils.getCardForSubscriptionBilling()

There two functions should be fix from BE side as well (if needed) to make sure it works properly. Now, as I can see, !!SubscriptionUtils.doesUserHavePaymentCardAdded() is always false.

What alternative solutions did you explore? (Optional)

• If ReportActionsUtils.isActionableAddPaymentCard(action) && hasPaymentCard we can also return false in shouldReportActionBeVisible util function.

• hasPaymentCard come from the main solution.

[mkzie2]

@mallenexpensify I think before user adds a payment card, the "Add payment card" button is displayed:

But after they add any payment card, we just need to hide that button instead of hiding all the message:

What do you think?

[mkzie2]

Proposal updated

[abzokhattab]

Proposal Updated

[thesahindia]

Removed Help Wanted for a min. @thesahindia , can you review @abzokhattab 's proposal above? Mainly curious if you think this likely needs to be worked on on the backend. Thx

We can fix it solely on the front end, but backend changes would be ideal.

I think we should get an engineer here.

🎀 👀 🎀 C+ reviewed ( using it for engineer assignment )

[melvin-bot]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[thesahindia]

Quoting from #50192 (comment)

App/src/libs/SubscriptionUtils.ts

Lines 427 to 432 in bee4bec

	/**
	* Whether the user has a payment card added to its account.
	*/
	function doesUserHavePaymentCardAdded(): boolean {
	return userBillingFundID !== undefined;
	}

The issue seems to be that the ONYXKEYS.NVP_BILLING_FUND_ID key is not being updated by the backend, causing it to remain null.

cc: @youssef-lr

[mkzie2]

@thesahindia The doesUserHavePaymentCardAdded is not related to checking whether we should display the free trial expired message. The issue is that, BE always returns the free trial expired message.

[mkzie2]

@youssef-lr Also, please help check my comment when you have a chance. TY

[melvin-bot]

@youssef-lr, @mallenexpensify, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@youssef-lr, @mallenexpensify, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@youssef-lr, @mallenexpensify, @thesahindia 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[mallenexpensify]

@youssef-lr 👀 above plz.
We need to know if you recommend fixing this on the back or frontend.

[thesahindia]

Just did it.

[youssef-lr]

I just ran the job manually, you should receive the message now.

[thesahindia]

Thanks! Received it now.

[thesahindia]

@youssef-lr, Do we have any dummy cards available for testing? Couldn't find something on Slack.

[mallenexpensify]

@thesahindia the deets in the C+ doc for cards won't help ya, right? If you find a workaroud for your usecase and others C+ can use, can you add them to the C+ doc? thx

I'm back from OOO on Nov 14th, not assigning another BZ because payment won't be due til I'm back. If one is needed please add or post in #contributor-plus to ask for one to be added, thx.

[youssef-lr]

@thesahindia I'm writing from mobile, please google Stripe test cards.

[thesahindia]

@youssef-lr, seems like I can't test this flow. I need to connect to the local backend.

[thesahindia]

Unassigning myself as I didn’t review the PR and am not eligible for any compensation.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hide add payment card button once a card is added #51594

If no regressions arise, payment will be issued on 2024-11-21. 🎊

[melvin-bot]

@youssef-lr @mallenexpensify @youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mallenexpensify]

No compensation due here

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@youssef-lr, @mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

[mallenexpensify]

PR hit production 13 days ago, no issues since, going to close

[melvin-bot]

@youssef-lr, @mallenexpensify Huh... This is 4 days overdue. Who can take care of this?