[$250] [HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• User has saved a long list of searches.

1. Go to staging.new.expensify.com
2. Go to Search.
3. Scroll down the saved search list.

Expected Result:

The saved search list should be scrollable.

Actual Result:

The saved search list is not scrollable when there is a long list.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6624165_1728032604137.20241004_165905.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021845946742438854336
• Upwork Job ID: 1845946742438854336
• Last Price Increase: 2024-10-14

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[jayeshmangwani]

This issue stems from the current PR and is still within the regression period. Wrapping SearchTypeMenu in Animated.View is causing the scroll to stop working.

cc: @SzymczakJ @rayane-djouah @luacmartins

[jayeshmangwani]

Its in production #48258 (comment)

[rayane-djouah]

PR is here: #50244
cc @SzymczakJ @luacmartins

[luacmartins]

Thanks.

[greg-schroeder]

PR on staging. Awaiting deploy to prod

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Saved search list is not scrollable when there is a long list #50244

If no regressions arise, payment will be issued on 2024-10-16. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Okay, original C+ who worked on the initial implementation implemented the fix, but there's a new C+ in this case (@ikevin127) and that's the only payment due here it seems, given the regression

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021845946742438854336

[melvin-bot]

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

[greg-schroeder]

Sending you a manual offer that I'll pay on 10/16 @ikevin127

[ikevin127]

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR: Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258.
• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258 (comment).
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition: User has saved a long list of searches.

1. Go to Search.
2. Scroll down the saved search list.
3. Verify that the saved search list is scrollable.

Do we agree 👍 or 👎.