Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold #51707] Logged out on HybridApp after not using the app for ~12 hours #50358

Closed
2 of 6 tasks
m-natarajan opened this issue Oct 7, 2024 · 24 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Oct 7, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.45-3
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728142235488769

Action Performed:

  1. Delete the HybridApp if you have it installed
  2. Download the latest version from TestFlight
  3. Open the HybridApp
  4. Sign in to an existing account
  5. Kill the app
  6. Wait 4+ hours
  7. Open the HybridApp

Expected Result:

User is not signed out

Actual Result:

“Your session has expired” message appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

IMG_7711

Add any screenshot/video evidence

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 7, 2024
Copy link

melvin-bot bot commented Oct 7, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@m-natarajan m-natarajan removed the Needs Reproduction Reproducible steps needed label Oct 7, 2024
@sakluger sakluger added the Internal Requires API changes or must be handled by Expensify staff label Oct 7, 2024
@sakluger
Copy link
Contributor

sakluger commented Oct 8, 2024

I commented in the original thread - @trjExpensify is working on reproducing at the moment.

@sakluger
Copy link
Contributor

No update

@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@sakluger
Copy link
Contributor

We're still working on reproducing this consistently in the thread.

@melvin-bot melvin-bot bot removed the Overdue label Oct 14, 2024
@muttmuure muttmuure moved this to CRITICAL in [#whatsnext] #quality Oct 15, 2024
@muttmuure muttmuure moved this from CRITICAL to MEDIUM in [#whatsnext] #quality Oct 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

@sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!

@sakluger
Copy link
Contributor

We're still discussing in the Slack thread.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 17, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

@sakluger this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Oct 21, 2024

@sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!

@sakluger
Copy link
Contributor

Not really sure what the next step is here so I asked in the Slack thread: https://expensify.slack.com/archives/C049HHMV9SM/p1728142235488769

@melvin-bot melvin-bot bot removed the Overdue label Oct 22, 2024
@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels Oct 23, 2024
@sakluger
Copy link
Contributor

This behavior is expected for unvalidated accounts - unvalidated accounts are logged out after 2+ hours of inactivity because we don’t give them an infinite session. I updated the OP steps the focus on existing accounts instead of unvalidated ones, and moved the priority to weekly.

@muttmuure
Copy link
Contributor

This is a duplicate - we'll work on it over here since it has a good #quality thread with CallStack on the go: #51185

@github-project-automation github-project-automation bot moved this from MEDIUM to Done in [#whatsnext] #quality Oct 29, 2024
@trjExpensify
Copy link
Contributor

Hmm, gotcha. That issue OP doesn't sound like this issue on mobile (incl. HybridApp). 🤔

Be on a bad connection
Open the ND

ND is stuck at the splash screen and refreshing the screen logs user out

MacOS: Chrome / Safari

The bug I'm, and others are experiencing, doesn't hang on the splash screen. I'm just straight up signed out or hit the "session expired" screen.

@muttmuure muttmuure reopened this Oct 30, 2024
@muttmuure muttmuure moved this from Done to CRITICAL in [#whatsnext] #quality Oct 30, 2024
@muttmuure
Copy link
Contributor

That thread has been a bit of a catch-all for being logged out.

But it sounds like there are a variety of flavours of this, so we can keep all of the issues open while we fix the unit test that should be catching autheticate errors that aren't dismissed when going offline

@mountiny mountiny added the Hot Pick Ready for an engineer to pick up and run with label Oct 30, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Nov 8, 2024
@muttmuure
Copy link
Contributor

Being worked on here too: #51707

@trjExpensify trjExpensify changed the title Logged out on HybridApp after not using the app for ~12 hours [Hold #51707] Logged out on HybridApp after not using the app for ~12 hours Nov 11, 2024
@sakluger
Copy link
Contributor

@muttmuure do you know why we have two GH issues for this bug? Can we consolidate?

@melvin-bot melvin-bot bot removed the Overdue label Nov 12, 2024
@trjExpensify
Copy link
Contributor

Because it's not conclusive yet if that issue solves the mobile/HybridApp issues:

But it sounds like there are a variety of flavours of this, so we can keep all of the issues open while we fix the unit test that should be catching autheticate errors that aren't dismissed when going offline

@muttmuure
Copy link
Contributor

Yeah this one calls out HybridApp, and we also have reports of this happening on web, so let's make sure we catch all of them

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2024
@sakluger
Copy link
Contributor

No updates here for now.

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week)

@muttmuure
Copy link
Contributor

This is merged now - #52727

@muttmuure
Copy link
Contributor

We're not seeing it anymore, I don't think, so let's close this one out.

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Development

No branches or pull requests

7 participants