Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payment due Oct 18]Payment issue for E/App PR#49811 #50413

Closed
melvin-bot bot opened this issue Oct 8, 2024 · 11 comments
Closed

[Payment due Oct 18]Payment issue for E/App PR#49811 #50413

melvin-bot bot opened this issue Oct 8, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Oct 8, 2024

Issue created to compensate the Contributor+ member for their work on #49811
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/431466.
Contributor+ member who reviewed the PR - @mananjadhav.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Oct 8, 2024
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Oct 8, 2024
Copy link
Author

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 8, 2024
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Oct 9, 2024

Looks like PR is under QA review - #49811

I'm going to set this to weekly since it still needs to be in production for 7 days.

Payment summary

Payouts due:

@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels Oct 9, 2024
@mananjadhav
Copy link
Collaborator

This was deployed yesterday and we should update the payout date accordingly.

@mananjadhav
Copy link
Collaborator

Payment date to be set in 3 days. (10/17)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 14, 2024
@Christinadobrzyn Christinadobrzyn changed the title Payment issue for E/App PR#49811 [Payment due Oct 17]Payment issue for E/App PR#49811 Oct 15, 2024
@Christinadobrzyn
Copy link
Contributor

Thanks @mananjadhav! I updated the title to include the payment due date.

Do we need a regression test for this?

@mananjadhav
Copy link
Collaborator

No regression test needed. We're just putting the feature behind beta. Hence no offending PR as well.

@Christinadobrzyn
Copy link
Contributor

Thanks @mananjadhav

We'll pay out based on this payment summary on 10/17 - #50413 (comment)

@Christinadobrzyn
Copy link
Contributor

looks like the PR merged on the 11th of Oct so the 7th day will be 10/18. so we'll pay this out tomorrow!

@Christinadobrzyn Christinadobrzyn changed the title [Payment due Oct 17]Payment issue for E/App PR#49811 [Payment due Oct 18]Payment issue for E/App PR#49811 Oct 17, 2024
@Christinadobrzyn
Copy link
Contributor

Okay, payment day - @mananjadhav, can you please request payment through NewDot? Here's the payment summary

@mananjadhav
Copy link
Collaborator

Done. Thanks @Christinadobrzyn. I think we can close this one out.

@garrettmknight
Copy link
Contributor

$250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

3 participants