[HOLD for payment 2024-11-05] [$250] Expensify Card - Nothing happens after tapping on Learn more button under Settlement frequency

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.46-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Expensify Card feature is enabled.
• Bank account is added to the workspace.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Expensify Card.
3. Click Settings.
4. Click Learn more under Settlement frequency.

Expected Result:

Learn more button should redirect to the relevant site.

Actual Result:

Nothing happens after tapping on Learn more button.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6629282_1728465113806.20241009_170909.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844424240687564403
• Upwork Job ID: 1844424240687564403
• Last Price Increase: 2024-10-17
• Automatic offers:
• situchan | Reviewer | 104542560
• ChavdaSachin | Contributor | 104542564

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 2

[IuliiaHerets]

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens after tapping on Learn more button under Settlement frequency

What is the root cause of that problem?

We haven't added redirect link here.

App/src/pages/workspace/expensifyCard/WorkspaceCardSettingsPage.tsx

Lines 73 to 77 in 3777223

	<TextLink
	href=""
	style={styles.label}
	>
	{translate('common.learnMore')}

What changes do you think we should make in order to solve the problem?

Add appropriate link here.

App/src/pages/workspace/expensifyCard/WorkspaceCardSettingsPage.tsx

Lines 73 to 77 in 3777223

	<TextLink
	href=""
	style={styles.label}
	>
	{translate('common.learnMore')}

We should store link in CONSTS.ts page and link it here

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021844424240687564403

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[ChavdaSachin]

As of now we do not have help page for card settlement-frequency for ND.
Here's the page for OD, internal team should create similar page for ND and then we could update the link.
https://help.expensify.com/articles/expensify-classic/expensify-card/Statements#expensify-card-settlement-frequency

Or team could create a coming soon page like following, and we could link it here and team could work on it later.
https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Billing-page-coming-soon

[garrettmknight]

Thanks @ChavdaSachin - let me check whether this is a known issue or not before proceeding.

@joekaufmanexpensify is this a known, dead link?

[situchan]

Also pulling up engineer to confirm
🎀👀🎀

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[joekaufmanexpensify]

@joekaufmanexpensify is this a known, dead link?

I have not seen this before, but it def should not be a dead link.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@garrettmknight, @yuwenmemon, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[garrettmknight]

Let just set this to go to https://help.expensify.com/articles/new-expensify/expensify-card/Manage-Expensify-Cards

[situchan]

Let's assign @ChavdaSachin for their proposal
🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @yuwenmemon is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ChavdaSachin 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ChavdaSachin]

PR is ready for the review.
cc. @situchan

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• added MANAGE_EXPENSIFY_CARDS_ARTICLE_LINK #51291

If no regressions arise, payment will be issued on 2024-11-05. 🎊

For reference, here are some details about the assignees on this issue:

• @ChavdaSachin requires payment automatic offer (Contributor)
• @situchan requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[situchan]

This was not regression but just missed during the feature implementation of card settings page in #45415.

As part of the Workspace feeds project, I think we can skip regression test for now. We will add the tests for this feature in one go as part of the project.

[garrettmknight]

Payment Summary:

• Contributor: @ChavdaSachin $250 paid via upwork
• Contributor+: @situchan $250 paid via upwork